summaryrefslogtreecommitdiff
path: root/compiler/optimizing/graph_visualizer.cc
Commit message (Collapse)AuthorAgeFilesLines
* Ensure object ArraySet with null value does not need a type check.Roland Levillain2016-03-231-0/+2
| | | | | | | | | | | The art::PrepareForRegisterAllocation visitor can remove an art::BoundType instruction as value input of an art::ArraySet instruction, possibly replacing it with an art::NullConstant. If this happens, remove the need for a type check in this art::ArraySet. Bug: 27638110 Change-Id: I6270f8a8e22822a24d8a5919df427ca9c64d121b
* Integrate BitwiseNegated into shared framework.Artem Serov2016-03-111-3/+3
| | | | | | Share implementation between arm and arm64. Change-Id: I0dd12e772cb23b4c181fd0b1e2a447470b1d8702
* Optimizing: ARM64 negated bitwise operations simplificationKevin Brodsky2016-02-251-0/+4
| | | | | | | | | | | | | | Use negated instructions on ARM64 to replace [bitwise operation + not] patterns, that is: a & ~b (BIC) a | ~b (ORN) a ^ ~b (EON) The simplification only happens if the Not is only used by the bitwise operation. It does not happen if both inputs are Not's (this should be handled by a generic simplification applying De Morgan's laws). Change-Id: I0e112b23fd8b8e10f09bfeff5994508a8ff96e9c
* Revert "Revert "ARM/ARM64: Extend support of instruction combining.""Artem Udovichenko2016-02-251-4/+6
| | | | | | This reverts commit 6b5afdd144d2bb3bf994240797834b5666b2cf98. Change-Id: Ic27a10f02e21109503edd64e6d73d1bb0c6a8ac6
* Extend constant folding to float and double operations.Roland Levillain2016-02-171-0/+7
| | | | Change-Id: I2837064b2ceea587bc171fc520507f13355292c6
* ART: Run SsaBuilder from HGraphBuilderDavid Brazdil2016-02-151-4/+4
| | | | | | | | | | | First step towards merging the two passes, which will later result in HGraphBuilder directly producing SSA form. This CL mostly just updates tests broken by not being able to inspect the pre-SSA form. Using HLocals outside the HGraphBuilder is now deprecated. Bug: 27150508 Change-Id: I00fb6050580f409dcc5aa5b5aa3a536d6e8d759e
* Fix x86-64 Baker's read barrier fast path for CheckCast.Roland Levillain2016-02-111-0/+2
| | | | | | | | | | | Use an art::x86_64::Label instead of an art::x86_64::NearLabel as end label when emitting code for a HCheckCast instruction, as the range of the latter may sometimes be too short when Baker's read barriers are enabled. Bug: 12687968 Change-Id: Ia9742dce65be7d4fb104688f3c4717b65df1fb54
* Revert "Revert "Lift the spill at each irreducible loop block restriction.""Nicolas Geoffray2016-01-281-0/+1
| | | | | | This reverts commit 2818dbcd75ea9beadcba9d18e2f68523108d0cf5. Change-Id: I92b2b60b4f08f50cacfea4132f1c28cfbd628f1a
* Some minor simplifications in code and tests.Aart Bik2016-01-261-0/+2
| | | | | | | | | | | | | Background: This is actually a resubmit of an earlier cl that was reverted because was test was less robust against inlining changes (it assumed a virtual call would never be inlined). original cl: If8ada79dfd70bea991c11d2b18661b951b6c4cd4 revert cl: I739aaaccd0509d02a62ef01e797a6d45bfe941df Change-Id: I952680d60ff488874907f066bfdf156a45b409ba
* Revert "Lift the spill at each irreducible loop block restriction."Bart Sears2016-01-261-1/+0
| | | | | | This reverts commit 79e9f43951c3cfa9ab3b0fea93e5bfdfa7aa5950. Change-Id: I0670618b4076e06bd3f6bf8c385abfd1b651393c
* Lift the spill at each irreducible loop block restriction.Nicolas Geoffray2016-01-261-0/+1
| | | | | | | | | It was not intended to have it this way anyway. This also required to fix GetSiblingAt, to take into account interval holes, and ConnectSplitSibling to re-materialize a constant or a method. Change-Id: Ia5534a93a5413cd0458a251c022d0b655369502b
* Revert "Some minor simplifications in code and tests."Nicolas Geoffray2016-01-221-2/+0
| | | | | | | | Fails 530-checker-loops on arm This reverts commit bf03fcd10a3ffa15468d335f26697b0473e45b36. Change-Id: I739aaaccd0509d02a62ef01e797a6d45bfe941df
* Some minor simplifications in code and tests.Aart Bik2016-01-201-0/+2
| | | | | | Rationale: fell through the cracks of previous "intrinsics" CL. Change-Id: If8ada79dfd70bea991c11d2b18661b951b6c4cd4
* Implement irreducible loop support in optimizing.Nicolas Geoffray2016-01-141-4/+20
| | | | | | | | | | | | | | So we don't fallback to the interpreter in the presence of irreducible loops. Implications: - A loop pre-header does not necessarily dominate a loop header. - Non-constant redundant phis will be kept in loop headers, to satisfy our linear scan register allocation algorithm. - while-graph optimizations, such as gvn, licm, lse, and dce need to know when they are dealing with irreducible loops. Change-Id: I2cea8934ce0b40162d215353497c7f77d6c9137e
* ART: Refactor SsaBuilder for more precise typing infoDavid Brazdil2015-12-311-12/+7
| | | | | | | | | | | | | | | This reverts commit 68289a531484d26214e09f1eadd9833531a3bc3c. Now uses Primitive::Is64BitType instead of Primitive::ComponentSize because it was incorrectly optimized by GCC. Bug: 26208284 Bug: 24252151 Bug: 24252100 Bug: 22538329 Bug: 25786318 Change-Id: Ib39f3da2b92bc5be5d76f4240a77567d82c6bebe
* Revert "ART: Refactor SsaBuilder for more precise typing info"Alex Light2015-12-151-7/+12
| | | | | | | | | | | | | This reverts commit d9510dfc32349eeb4f2145c801f7ba1d5bccfb12. Bug: 26208284 Bug: 24252151 Bug: 24252100 Bug: 22538329 Bug: 25786318 Change-Id: I5f491becdf076ff51d437d490405ec4e1586c010
* ART: Refactor SsaBuilder for more precise typing infoDavid Brazdil2015-12-141-12/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch refactors the SsaBuilder to do the following: 1) All phis are constructed live and marked dead if not used or proved to be conflicting. 2) Primitive type propagation, now not a separate pass, identifies conflicting types and marks corresponding phis dead. 3) When compiling --debuggable, DeadPhiHandling used to revive phis which had only environmental uses but did not attempt to resolve conflicts. This pass was removed as obsolete and is now superseded by primitive type propagation (identifying conflicting phis) and SsaDeadPhiEliminiation (keeping phis live if debuggable + env use). 4) Resolving conflicts requires correct primitive type information on all instructions. This was not the case for ArrayGet instructions which can have ambiguous types in the bytecode. To this end, SsaBuilder now runs reference type propagation and types ArrayGets from the type of the input array. 5) With RTP being run inside the SsaBuilder, it is not necessary to run it as a separate optimization pass. Optimizations can now assume that all instructions of type kPrimNot have reference type info after SsaBuilder (with the exception of NullConstant). 6) Graph now contains a reference type to be assigned to NullConstant. All reference type instructions therefore have RTI, as now enforced by the SsaChecker. Bug: 24252151 Bug: 24252100 Bug: 22538329 Bug: 25786318 Change-Id: I7a3aee1ff66c82d64b4846611c547af17e91d260
* Merge "Revert "Revert "Don't use the compiler driver for method resolution."""Nicolas Geoffray2015-12-021-0/+5
|\
| * Revert "Revert "Don't use the compiler driver for method resolution.""Nicolas Geoffray2015-12-021-0/+5
| | | | | | | | | | | | This reverts commit c88ef3a10c474045a3476a02ae75d07ddd3230b7. Change-Id: I0ed88a48b313a8d28bc39fae40631123aadb13ef
| * Revert "Don't use the compiler driver for method resolution."Nicolas Geoffray2015-12-011-5/+0
| | | | | | | | | | | | | | | | Fails 425 in debuggable mode. This reverts commit 4db0bf9c4db6a09716c3388b7d2f88d534470339. Change-Id: I346df8f75674564fc4fb241c60f23e250fc7f0a7
| * Don't use the compiler driver for method resolution.Nicolas Geoffray2015-12-011-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | The compiler driver makes assumptions that don't hold for the optimizing compiler, and will for example always go to slow path for an invoke-super when there's no verified method. Also fix GenerateInvokeVirtual in the presence of intrinsics. Next change will address some of the TODOs in sharpening.cc. Change-Id: I2b0e543ee9b9bebcadb2d26de29e850c59ad58b9
* | Optimizing: Add checker tests for sharpening.Vladimir Marko2015-12-021-3/+1
|/ | | | | | | This is a follow-up to https://android-review.googlesource.com/184116 . Change-Id: Ib03c424fb673afc5ccce15d7d072b7572b47799a
* ARM64: Use the shifter operands.Alexandre Rames2015-11-251-0/+7
| | | | | | | | | | | | | | | | | | | | | This introduces architecture-specific instruction simplification. On ARM64 we try to merge shifts and sign-extension operations into arithmetic and logical instructions. For example for the Java code int res = a + (b << 5); we would generate lsl w3, w2, #5 add w0, w1, w3 and we now generate add w0, w1, w2, lsl #5 Change-Id: Ic03bdff44a1c12e21ddff1b0513bd32a730742b7
* ARM64: Add support for multiply-accumulate.Alexandre Rames2015-11-201-0/+6
| | | | Change-Id: I88dc313df520480f3fd16bbabda27f9435d25368
* Merge "Allow NullConstant to be untyped in GraphVisualiser."Calin Juravle2015-11-191-0/+12
|\
| * Allow NullConstant to be untyped in GraphVisualiser.Mark Mendell2015-11-191-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The NullConstant may be added to the graph during other passes that happen between ReferenceTypePropagation and Inliner (e.g. InstructionSimplifier). If the inliner doesn't run or doesn't inline anything, the NullConstant remains untyped. The infrastructure to properly type NullConstants everywhere is to complex to add for the benefits Bug: 25786318 Change-Id: I904a3e605b57f8cac9936e82f19a4994c7b1a82a Signed-off-by: Mark Mendell <mark.p.mendell@intel.com>
* | Fix ClinitCheck pruning.Vladimir Marko2015-11-191-0/+3
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure we merge the ClinitCheck only with LoadClass and HInvokeStaticOrDirect that is a part of the very same dex instruction. This fixes incorrect stack traces from class initializers (wrong dex pcs). Rewrite the pruning to do all the ClinitCheck merging when we see the ClinitCheck, instead of merging ClinitCheck into LoadClass and then LoadClass into HInvokeStaticOrDirect. When we later see an HInvokeStaticOrDirect with an explicit check (i.e. not merged), we know that some other instruction is doing the check and the invoke doesn't need to, so we mark it as not requiring the check at all. (Previously it would have been marked as having an implicit check.) Remove the restriction on merging with inlined invoke static as this is not necessary anymore. This was a workaround for X.test(): invoke-static C.foo() [1] C.foo(): invoke-static C.bar() [2] After inlining and GVN we have X.test(): LoadClass C (from [1]) ClinitCheck C (from [1], to be merged to LoadClass) InvokeStaticOrDirect C.bar() (from [2]) and the LoadClass must not be merged into the invoke as this would cause the resolution trampoline to see an inlined frame from the not-yet-loaded class C during the stack walk and try to load the class. However, we're not allowed to load new classes at that point, so an attempt to do so leads to an assertion failure. With this CL, LoadClass is not merged when it comes from a different instruction, so we can guarantee that all inlined frames seen by the stack walk in the resolution trampoline belong to already loaded classes. Change-Id: I2b8da8d4f295355dce17141f0fab2dace126684d
* Revert "Revert "Run type propagation after inliner only when needed.""Calin Juravle2015-11-111-6/+3
| | | | | | This reverts commit 271743601650308c7ac5c7a3ec35025d8130a298. Change-Id: I173e27a0a4d7d54f90ca459eb48d280d1d40ab70
* ART: Refactor iteration over normal/exceptional successorsDavid Brazdil2015-11-101-4/+2
| | | | | | | Add helper methods on HBasicBlock which return ArrayRef with the suitable sub-array of the `successors_` list. Change-Id: I66c83bb56f2984d7550bf77c48110af4087515a8
* Revert "Run type propagation after inliner only when needed."Calin Juravle2015-10-261-3/+6
| | | | | | This reverts commit 4e5dd521063beae1706410419f19c7e224db50fe. Change-Id: I0de261d14dd3f71abe05f9bc71744820cf23b937
* Run type propagation after inliner only when needed.Calin Juravle2015-10-231-6/+3
| | | | | | | | Currently we run a type propagation pass unconditionally after the inliner. This change looks at the returned value (if any) and runs a minimal type propagation only if its type has changed. Change-Id: I0dd72bd481219081e8a978d2632426afc980d73a
* Merge "Add DCHECKs to ArenaVector and ScopedArenaVector."Vladimir Marko2015-10-081-2/+2
|\
| * Add DCHECKs to ArenaVector and ScopedArenaVector.Vladimir Marko2015-10-081-2/+2
| | | | | | | | | | | | | | | | | | | | Implement dchecked_vector<> template that DCHECK()s element access and insert()/emplace()/erase() positions. Change the ArenaVector<> and ScopedArenaVector<> aliases to use the new template instead of std::vector<>. Remove DCHECK()s that have now become unnecessary from the Optimizing compiler. Change-Id: Ib8506bd30d223f68f52bd4476c76d9991acacadc
* | Make sure classes with different access checks are not GVN-edCalin Juravle2015-10-081-0/+2
|/ | | | Change-Id: I89f72fef3be35a4dd9585d97d03a3150386e0891
* Add support for unresolved classes in optimizing.Calin Juravle2015-10-061-1/+4
| | | | Change-Id: I0e299a81e560eb9cb0737ec46125dffc99333b54
* Revert "Revert "Support unresolved fields in optimizing"Calin Juravle2015-10-021-0/+16
| | | | | | | | | | | | The CL also changes the calling convetion for 64bit static field set to use kArg2 instead of kArg1. This allows optimizing to keep the asumptions: - arm pairs are always of form (even_reg, odd_reg) - ecx_edx is not used as a register on x86. This reverts commit e6f49b47b6a4dc9c7684e4483757872cfc7ff1a1. Change-Id: I93159917565824084abc96775f31be1a4249f2f3
* Use dominance information for null optimization in write barrier.Nicolas Geoffray2015-09-291-0/+5
| | | | Change-Id: I8b57dafcd321c9afa1bbfc6a0674cbea15cbf10c
* Revert "Support unresolved fields in optimizing"Calin Juravle2015-09-171-16/+0
| | | | | | | | breaks debuggable tests. This reverts commit 23a8e35481face09183a24b9d11e505597c75ebb. Change-Id: I8e60b5c8f48525975f25d19e5e8066c1c94bd2e5
* Support unresolved fields in optimizingCalin Juravle2015-09-171-0/+16
| | | | Change-Id: I9941fa5fcb6ef0a7a253c7a0b479a44a0210aad4
* Support unresolved methods in OptimizingCalin Juravle2015-09-171-0/+5
| | | | Change-Id: If2da02b50d2fa668cd58f134a005f1752e7746b1
* Optimizing: Tag arena allocations in HGraph.Vladimir Marko2015-09-161-2/+2
| | | | | | | | Replace GrowableArray with ArenaVector in HGraph and related classes HEnvironment, HLoopInformation, HInvoke and HPhi, and tag allocations with new arena allocation types. Change-Id: I3d79897af405b9a1a5b98bfc372e70fe0b3bc40d
* Optimizing: Tag basic block allocations with their source.Vladimir Marko2015-09-081-5/+4
| | | | | | | | | | Replace GrowableArray with ArenaVector in HBasicBlock and, to track the source of allocations, assign one new and two Quick's arena allocation types to these vectors. Rename kArenaAllocSuccessor to kArenaAllocSuccessors. Bug: 23736311 Change-Id: Ib52e51698890675bde61f007fe6039338cf1a025
* Revert "Optimizing: Tag basic block allocations with their source."Vladimir Marko2015-09-031-4/+5
| | | | | | | | Reverting so that we can have more discussion about the STL API. This reverts commit 91e11c0c840193c6822e66846020b6647de243d5. Change-Id: I187fe52f2c16b6e7c5c9d49c42921eb6c7063dba
* Optimizing: Tag basic block allocations with their source.Vladimir Marko2015-09-031-5/+4
| | | | | | | | | | Replace GrowableArray with ArenaVector in HBasicBlock and, to track the source of allocations, assign one new and two Quick's arena allocation types to these vectors. Rename kArenaAllocSuccessor to kArenaAllocSuccessors. Bug: 23736311 Change-Id: I984aef6e615ae2380a532f5c6726af21015f43f5
* Merge "Revert "Revert "Revert "Revert "Use the object class as top in ↵Calin Juravle2015-07-291-22/+13
|\ | | | | | | reference type propagation"""""
| * Revert "Revert "Revert "Revert "Use the object class as top in reference ↵Calin Juravle2015-07-291-22/+13
| | | | | | | | | | | | | | | | type propagation"""" This reverts commit b734808d0c93af98ec4e3539fdb0a8c0787263b0. Change-Id: Ifd925f166761bcb9be2268ff0fc9fa3a72f00c6f
* | Merge "Revert "Revert "Revert "Revert "Fixes and improvements in ↵Calin Juravle2015-07-291-4/+10
|\| | | | | | | ReferenceTypePropagation"""""
| * Revert "Revert "Revert "Revert "Fixes and improvements in ↵Calin Juravle2015-07-281-4/+10
| | | | | | | | | | | | | | | | ReferenceTypePropagation"""" This reverts commit e344a8070d4549d513413c06767abf8a2c5e9709. Change-Id: I400fab0e02ce3c11376cc1f3ae9c7cf2c82ffcc1
| * Revert "Revert "Revert "Fixes and improvements in ReferenceTypePropagation"""Calin Juravle2015-07-281-10/+4
| | | | | | | | | | | | This reverts commit 00e3b38be4b280d6d7a7e843cd336ffbd2ba4365. Change-Id: I4dbadb2d7312a410f1c56283f063dd82156cf702
| * Revert "Revert "Fixes and improvements in ReferenceTypePropagation""Calin Juravle2015-07-271-4/+10
| | | | | | | | | | | | This reverts commit 9b0096ba77e7e61bc2dcbbf954831dcae54a6c27. Change-Id: I824f16e800ca32e646577d5e1e0d593887ccead1
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-23 06:58:33 +0000