From 4952dfd16a0f839559ffa78f5016394caf85294f Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Wed, 30 Nov 2011 19:23:22 -0800 Subject: Ensure input events are processed in-order in the application. As it turns out, it used to be possible for there to be multiple input events simultaneously in flight in an application. Although it worked, it made it hard to reason about what was going on. The problem was somewhat exacerbated by the introduction of a queue of "InputEventMessage" objects as part of an earlier latency optimization. This change restores order from chaos and greatly simplifies the invariants related to input event dispatch within the application. Change-Id: I6de5fe61c1fe2ac3dd33edf770d949044df8a019 --- core/java/android/view/InputQueue.java | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) (limited to 'core/java/android/view/InputQueue.java') diff --git a/core/java/android/view/InputQueue.java b/core/java/android/view/InputQueue.java index 5735b6397cf0..12065184ccda 100644 --- a/core/java/android/view/InputQueue.java +++ b/core/java/android/view/InputQueue.java @@ -114,19 +114,12 @@ public final class InputQueue { } @SuppressWarnings("unused") - private static void dispatchKeyEvent(InputHandler inputHandler, - KeyEvent event, long finishedToken) { + private static void dispatchInputEvent(InputHandler inputHandler, + InputEvent event, long finishedToken) { FinishedCallback finishedCallback = FinishedCallback.obtain(finishedToken); - inputHandler.handleKey(event, finishedCallback); + inputHandler.handleInputEvent(event, finishedCallback); } - @SuppressWarnings("unused") - private static void dispatchMotionEvent(InputHandler inputHandler, - MotionEvent event, long finishedToken) { - FinishedCallback finishedCallback = FinishedCallback.obtain(finishedToken); - inputHandler.handleMotion(event, finishedCallback); - } - /** * A callback that must be invoked to when finished processing an event. * @hide -- cgit v1.2.3