From 5af7d62e27ff7db2b185482b842df5ebda19d46c Mon Sep 17 00:00:00 2001 From: Robert Carr Date: Tue, 17 Mar 2020 12:04:20 -0700 Subject: SurfaceView: Release SurfacePackage when done We release the SurfaceControl assosciated with a Surface package when accepting a new SurfacePackage, or at time of detached-from-window this way we don't rely on the finalize method. Bug: 149591513 Test: Existing tests pass Change-Id: Ic0f7259394836ee094ed49db73b5986b778b450f --- core/java/android/view/SurfaceControlViewHost.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'core/java/android/view/SurfaceControlViewHost.java') diff --git a/core/java/android/view/SurfaceControlViewHost.java b/core/java/android/view/SurfaceControlViewHost.java index b587fbe24767..e8fc1ea6e8cf 100644 --- a/core/java/android/view/SurfaceControlViewHost.java +++ b/core/java/android/view/SurfaceControlViewHost.java @@ -98,7 +98,10 @@ public class SurfaceControlViewHost { } /** - * Release the SurfaceControl associated with the SurfacePackage. + * Release the {@link SurfaceControl} associated with this package. + * It's not necessary to call this if you pass the package to + * {@link SurfaceView#setChildSurfacePackage} as {@link SurfaceView} will + * take ownership in that case. */ public void release() { if (mSurfaceControl != null) { -- cgit v1.2.3