From 00a5b99229e41c173afd3071f15aaa725f531814 Mon Sep 17 00:00:00 2001 From: Bjorn Bringert Date: Mon, 20 Jul 2009 15:36:24 +0100 Subject: Ignore unneeded soft keyboard in ACTV height calc Before, if dropDownAlwaysVisible was false, the soft keyboard height was always taken into account when calculating the available vertical space for the AutoCompleteTextView drop-down height. This meant that the drop-down would never pop over the soft keyboard when navigating in the drop-down list. This change makes the drop-down pop over the soft keyboard when the keyboard is not needed, regardless of the value of dropDownAlwaysVisible. Fixes http://b/issue?id=1978935 --- core/java/android/widget/AutoCompleteTextView.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'core/java/android/widget/AutoCompleteTextView.java') diff --git a/core/java/android/widget/AutoCompleteTextView.java b/core/java/android/widget/AutoCompleteTextView.java index 0df587f1bda7..4bc00de33e81 100644 --- a/core/java/android/widget/AutoCompleteTextView.java +++ b/core/java/android/widget/AutoCompleteTextView.java @@ -1296,11 +1296,8 @@ public class AutoCompleteTextView extends EditText implements Filter.FilterListe } } - // Max height available on the screen for a popup. If this AutoCompleteTextView has - // the dropDownAlwaysVisible attribute, and the input method is not currently required, - // we then we ask for the height ignoring any bottom decorations like the input method. - // Otherwise we respect the input method. - boolean ignoreBottomDecorations = mDropDownAlwaysVisible && + // Max height available on the screen for a popup. + boolean ignoreBottomDecorations = mPopup.getInputMethodMode() == PopupWindow.INPUT_METHOD_NOT_NEEDED; final int maxHeight = mPopup.getMaxAvailableHeight( getDropDownAnchorView(), mDropDownVerticalOffset, ignoreBottomDecorations); -- cgit v1.2.3