From e6ab4493c6fc9e2a5af68b16cdb4b047edf6b048 Mon Sep 17 00:00:00 2001 From: Aaron Huang Date: Thu, 9 Dec 2021 16:18:06 +0800 Subject: Remove isUnsafeBuild() from IpSecAlgorithm IpSec is going to move to Connectivity mainline module so hidden API usage should be removed. There's no formal API could be an alternative for Build.IS_ENG. Considering isUnsafeBuild() is not a really helpful method because it only prints the log in eng build. Therefore, remove it. Bug: 204153604 Test: FrameworksNetTests Change-Id: Ic354e12423629b0d72e8087843893953a0c8c465 --- framework-t/src/android/net/IpSecAlgorithm.java | 8 -------- 1 file changed, 8 deletions(-) (limited to 'framework-t/src/android/net/IpSecAlgorithm.java') diff --git a/framework-t/src/android/net/IpSecAlgorithm.java b/framework-t/src/android/net/IpSecAlgorithm.java index 840af28b77..5e647fe2f9 100644 --- a/framework-t/src/android/net/IpSecAlgorithm.java +++ b/framework-t/src/android/net/IpSecAlgorithm.java @@ -469,20 +469,12 @@ public final class IpSecAlgorithm implements Parcelable { } } - // Because encryption keys are sensitive and userdebug builds are used by large user pools - // such as beta testers, we only allow sensitive info such as keys on eng builds. - private static boolean isUnsafeBuild() { - return Build.IS_DEBUGGABLE && Build.IS_ENG; - } - @Override @NonNull public String toString() { return new StringBuilder() .append("{mName=") .append(mName) - .append(", mKey=") - .append(isUnsafeBuild() ? HexDump.toHexString(mKey) : "") .append(", mTruncLenBits=") .append(mTruncLenBits) .append("}") -- cgit v1.2.3