diff options
Diffstat (limited to 'fs_mgr/liblp')
| -rw-r--r-- | fs_mgr/liblp/builder_test.cpp | 2 | ||||
| -rw-r--r-- | fs_mgr/liblp/device_test.cpp | 2 | ||||
| -rw-r--r-- | fs_mgr/liblp/partition_opener.cpp | 2 | ||||
| -rw-r--r-- | fs_mgr/liblp/reader.cpp | 4 | ||||
| -rw-r--r-- | fs_mgr/liblp/writer.cpp | 4 |
5 files changed, 7 insertions, 7 deletions
diff --git a/fs_mgr/liblp/builder_test.cpp b/fs_mgr/liblp/builder_test.cpp index a21e09e4f2..e4b617a51b 100644 --- a/fs_mgr/liblp/builder_test.cpp +++ b/fs_mgr/liblp/builder_test.cpp @@ -234,7 +234,7 @@ TEST_F(BuilderTest, InternalPartitionAlignment) { EXPECT_EQ(lba, aligned_lba); } - // Sanity check one extent. + // Check one extent. EXPECT_EQ(exported->extents.back().target_data, 3072); } diff --git a/fs_mgr/liblp/device_test.cpp b/fs_mgr/liblp/device_test.cpp index 6af9d94db7..236fd8dd3b 100644 --- a/fs_mgr/liblp/device_test.cpp +++ b/fs_mgr/liblp/device_test.cpp @@ -47,7 +47,7 @@ TEST_F(DeviceTest, BlockDeviceInfo) { BlockDeviceInfo device_info; ASSERT_TRUE(opener.GetInfo(fs_mgr_get_super_partition_name(), &device_info)); - // Sanity check that the device doesn't give us some weird inefficient + // Check that the device doesn't give us some weird inefficient // alignment. EXPECT_EQ(device_info.alignment % LP_SECTOR_SIZE, 0); EXPECT_EQ(device_info.logical_block_size % LP_SECTOR_SIZE, 0); diff --git a/fs_mgr/liblp/partition_opener.cpp b/fs_mgr/liblp/partition_opener.cpp index 1d4db85250..3d3dde6f2f 100644 --- a/fs_mgr/liblp/partition_opener.cpp +++ b/fs_mgr/liblp/partition_opener.cpp @@ -49,7 +49,7 @@ std::string GetPartitionAbsolutePath(const std::string& path) { // Dynamic System Update is installed to an sdcard, which won't be in // the boot device list. // - // We whitelist because most devices in /dev/block are not valid for + // mmcblk* is allowed because most devices in /dev/block are not valid for // storing fiemaps. if (android::base::StartsWith(path, "mmcblk")) { return "/dev/block/" + path; diff --git a/fs_mgr/liblp/reader.cpp b/fs_mgr/liblp/reader.cpp index e6fd9f72a4..24ccc0f9de 100644 --- a/fs_mgr/liblp/reader.cpp +++ b/fs_mgr/liblp/reader.cpp @@ -174,7 +174,7 @@ static bool ReadMetadataHeader(Reader* reader, LpMetadata* metadata) { return false; } - // Do basic sanity checks before computing the checksum. + // Do basic validity checks before computing the checksum. if (header.magic != LP_METADATA_HEADER_MAGIC) { LERROR << "Logical partition metadata has invalid magic value."; return false; @@ -255,7 +255,7 @@ static std::unique_ptr<LpMetadata> ParseMetadata(const LpMetadataGeometry& geome LpMetadataHeader& header = metadata->header; - // Sanity check the table size. + // Check the table size. if (header.tables_size > geometry.metadata_max_size) { LERROR << "Invalid partition metadata header table size."; return nullptr; diff --git a/fs_mgr/liblp/writer.cpp b/fs_mgr/liblp/writer.cpp index 8bf1ee9232..2708efa156 100644 --- a/fs_mgr/liblp/writer.cpp +++ b/fs_mgr/liblp/writer.cpp @@ -81,8 +81,8 @@ std::string SerializeMetadata(const LpMetadata& input) { return header_blob + tables; } -// Perform sanity checks so we don't accidentally overwrite valid metadata -// with potentially invalid metadata, or random partition data with metadata. +// Perform checks so we don't accidentally overwrite valid metadata with +// potentially invalid metadata, or random partition data with metadata. static bool ValidateAndSerializeMetadata([[maybe_unused]] const IPartitionOpener& opener, const LpMetadata& metadata, const std::string& slot_suffix, std::string* blob) { |
