/* * Copyright (C) 2018 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ #define LOG_TAG "resolv" #include #include #include #include #include #include "dns_responder.h" #include "getaddrinfo.h" #include "gethnamaddr.h" #include "resolv_cache.h" #include "stats.pb.h" #define NAME(variable) #variable // TODO: make this dynamic and stop depending on implementation details. constexpr unsigned int TEST_NETID = 30; // Specifying 0 in ai_socktype or ai_protocol of struct addrinfo indicates that any type or // protocol can be returned by getaddrinfo(). constexpr unsigned int ANY = 0; namespace android { namespace net { using android::base::StringPrintf; using android::net::NetworkDnsEventReported; using android::netdutils::ScopedAddrinfo; // Minimize class ResolverTest to be class TestBase because class TestBase doesn't need all member // functions of class ResolverTest and class DnsResponderClient. class TestBase : public ::testing::Test { protected: void SetUp() override { // Create cache for test resolv_create_cache_for_net(TEST_NETID); } void TearDown() override { // Delete cache for test resolv_delete_cache_for_net(TEST_NETID); } static std::string ToString(const hostent* he) { if (he == nullptr) return ""; char buffer[INET6_ADDRSTRLEN]; if (!inet_ntop(he->h_addrtype, he->h_addr_list[0], buffer, sizeof(buffer))) { return ""; } return buffer; } static std::string ToString(const addrinfo* ai) { if (!ai) return ""; for (const auto* aip = ai; aip != nullptr; aip = aip->ai_next) { char host[NI_MAXHOST]; int rv = getnameinfo(aip->ai_addr, aip->ai_addrlen, host, sizeof(host), nullptr, 0, NI_NUMERICHOST); if (rv != 0) return gai_strerror(rv); return host; } return ""; } size_t GetNumQueries(const test::DNSResponder& dns, const char* name) const { auto queries = dns.queries(); size_t found = 0; for (const auto& p : queries) { if (p.first == name) { ++found; } } return found; } const char* mDefaultSearchDomains = "example.com"; const res_params mDefaultParams_Binder = { .sample_validity = 300, .success_threshold = 25, .min_samples = 8, .max_samples = 8, .base_timeout_msec = 1000, .retry_count = 2, }; const android_net_context mNetcontext = { .app_netid = TEST_NETID, .app_mark = MARK_UNSET, .dns_netid = TEST_NETID, .dns_mark = MARK_UNSET, .uid = NET_CONTEXT_INVALID_UID, }; // Illegal hostnames static constexpr char kBadCharAfterPeriodHost[] = "hello.example.^com."; static constexpr char kBadCharBeforePeriodHost[] = "hello.example^.com."; static constexpr char kBadCharAtTheEndHost[] = "hello.example.com^."; static constexpr char kBadCharInTheMiddleOfLabelHost[] = "hello.ex^ample.com."; }; class ResolvGetAddrInfoTest : public TestBase {}; class GetHostByNameForNetContextTest : public TestBase {}; TEST_F(ResolvGetAddrInfoTest, InvalidParameters) { // Both null "netcontext" and null "res" of resolv_getaddrinfo() are not tested // here because they are checked by assert() without returning any error number. // Invalid hostname and servname. // Both hostname and servname are null pointers. Expect error number EAI_NONAME. { addrinfo* result = nullptr; NetworkDnsEventReported event; int rv = resolv_getaddrinfo(nullptr /*hostname*/, nullptr /*servname*/, nullptr /*hints*/, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_EQ(EAI_NONAME, rv); } // Invalid hints. // These place holders are used to test function call with unrequired parameters. // The content is not important because function call returns error directly if // there have any unrequired parameter. char placeholder_cname[] = "invalid_cname"; sockaddr placeholder_addr = {}; addrinfo placeholder_next = {}; static const struct TestConfig { int ai_flags; socklen_t ai_addrlen; char* ai_canonname; sockaddr* ai_addr; addrinfo* ai_next; int expected_eai_error; std::string asParameters() const { return StringPrintf("0x%x/%u/%s/%p/%p", ai_flags, ai_addrlen, ai_canonname ? ai_canonname : "(null)", (void*)ai_addr, (void*)ai_next); } } testConfigs[]{ {0, sizeof(in_addr) /*bad*/, nullptr, nullptr, nullptr, EAI_BADHINTS}, {0, 0, placeholder_cname /*bad*/, nullptr, nullptr, EAI_BADHINTS}, {0, 0, nullptr, &placeholder_addr /*bad*/, nullptr, EAI_BADHINTS}, {0, 0, nullptr, nullptr, &placeholder_next /*bad*/, EAI_BADHINTS}, {AI_ALL /*bad*/, 0, nullptr, nullptr, nullptr, EAI_BADFLAGS}, {AI_V4MAPPED_CFG /*bad*/, 0, nullptr, nullptr, nullptr, EAI_BADFLAGS}, {AI_V4MAPPED /*bad*/, 0, nullptr, nullptr, nullptr, EAI_BADFLAGS}, {AI_DEFAULT /*bad*/, 0, nullptr, nullptr, nullptr, EAI_BADFLAGS}, }; for (const auto& config : testConfigs) { SCOPED_TRACE(config.asParameters()); addrinfo* result = nullptr; // In current test configuration set, ai_family, ai_protocol and ai_socktype are not // checked because other fields cause hints error check failed first. const addrinfo hints = { .ai_flags = config.ai_flags, .ai_family = AF_UNSPEC, .ai_socktype = ANY, .ai_protocol = ANY, .ai_addrlen = config.ai_addrlen, .ai_canonname = config.ai_canonname, .ai_addr = config.ai_addr, .ai_next = config.ai_next, }; NetworkDnsEventReported event; int rv = resolv_getaddrinfo("localhost", nullptr /*servname*/, &hints, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_EQ(config.expected_eai_error, rv); } } TEST_F(ResolvGetAddrInfoTest, InvalidParameters_Family) { for (int family = 0; family < AF_MAX; ++family) { if (family == AF_UNSPEC || family == AF_INET || family == AF_INET6) { continue; // skip supported family } SCOPED_TRACE(StringPrintf("family: %d", family)); addrinfo* result = nullptr; const addrinfo hints = { .ai_family = family, // unsupported family }; NetworkDnsEventReported event; int rv = resolv_getaddrinfo("localhost", nullptr /*servname*/, &hints, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_EQ(EAI_FAMILY, rv); } } TEST_F(ResolvGetAddrInfoTest, InvalidParameters_SocketType) { for (const auto& family : {AF_INET, AF_INET6, AF_UNSPEC}) { for (int protocol = 0; protocol < IPPROTO_MAX; ++protocol) { // Socket types which are not in explore_options. for (const auto& socktype : {SOCK_RDM, SOCK_SEQPACKET, SOCK_DCCP, SOCK_PACKET}) { const addrinfo hints = { .ai_family = family, .ai_protocol = protocol, .ai_socktype = socktype, }; for (const char* service : {static_cast(nullptr), // service is null "80", "", // empty service name "ftp", "65536", // out of valid port range from 0 to 65535 "invalid"}) { SCOPED_TRACE(StringPrintf("family: %d, socktype: %d, protocol: %d, service: %s", family, socktype, protocol, service ? service : "service is nullptr")); addrinfo* result = nullptr; NetworkDnsEventReported event; int rv = resolv_getaddrinfo("localhost", service, &hints, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_EQ(EAI_SOCKTYPE, rv); } } } } } TEST_F(ResolvGetAddrInfoTest, InvalidParameters_MeaningfulSocktypeAndProtocolCombination) { static const int families[] = {PF_INET, PF_INET6, PF_UNSPEC}; // Skip to test socket type SOCK_RAW in meaningful combination (explore_options[]) of // system\netd\resolv\getaddrinfo.cpp. In explore_options[], the socket type SOCK_RAW always // comes with protocol ANY which causes skipping meaningful socktype/protocol combination // check. So it nerver returns error number EAI_BADHINTS which we want to test in this test // case. static const int socktypes[] = {SOCK_STREAM, SOCK_DGRAM}; // If both socktype/protocol are specified, check non-meaningful combination returns // expected error number EAI_BADHINTS. See meaningful combination in explore_options[] of // system\netd\resolv\getaddrinfo.cpp. for (const auto& family : families) { for (const auto& socktype : socktypes) { for (int protocol = 0; protocol < IPPROTO_MAX; ++protocol) { SCOPED_TRACE(StringPrintf("family: %d, socktype: %d, protocol: %d", family, socktype, protocol)); // Both socktype/protocol need to be specified. if (!socktype || !protocol) continue; // Skip meaningful combination in explore_options[] of // system\netd\resolv\getaddrinfo.cpp. if ((family == AF_INET6 && socktype == SOCK_DGRAM && protocol == IPPROTO_UDP) || (family == AF_INET6 && socktype == SOCK_STREAM && protocol == IPPROTO_TCP) || (family == AF_INET && socktype == SOCK_DGRAM && protocol == IPPROTO_UDP) || (family == AF_INET && socktype == SOCK_STREAM && protocol == IPPROTO_TCP) || (family == AF_UNSPEC && socktype == SOCK_DGRAM && protocol == IPPROTO_UDP) || (family == AF_UNSPEC && socktype == SOCK_STREAM && protocol == IPPROTO_TCP)) { continue; } addrinfo* result = nullptr; const addrinfo hints = { .ai_family = family, .ai_protocol = protocol, .ai_socktype = socktype, }; NetworkDnsEventReported event; int rv = resolv_getaddrinfo("localhost", nullptr /*servname*/, &hints, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_EQ(EAI_BADHINTS, rv); } } } } // The test configs are used for verifying the error path of get_port(). // Note that the EAI_SOCKTYPE verification are moved to an independent // test case because validateHints() verify invalid socket type early now. // See also InvalidParameters_SocketType. TEST_F(ResolvGetAddrInfoTest, InvalidParameters_PortNameAndNumber) { constexpr char http_portno[] = "80"; constexpr char invalid_portno[] = "65536"; // out of valid port range from 0 to 65535 constexpr char http_portname[] = "http"; constexpr char invalid_portname[] = "invalid_portname"; static const struct TestConfig { int ai_flags; int ai_family; int ai_socktype; const char* servname; int expected_eai_error; std::string asParameters() const { return StringPrintf("0x%x/%d/%d/%s", ai_flags, ai_family, ai_socktype, servname ? servname : "(null)"); } } testConfigs[]{ {0, AF_INET, SOCK_RAW /*bad*/, http_portno, EAI_SERVICE}, {0, AF_INET6, SOCK_RAW /*bad*/, http_portno, EAI_SERVICE}, {0, AF_UNSPEC, SOCK_RAW /*bad*/, http_portno, EAI_SERVICE}, {0, AF_INET, ANY, invalid_portno /*bad*/, EAI_SERVICE}, {0, AF_INET, SOCK_STREAM, invalid_portno /*bad*/, EAI_SERVICE}, {0, AF_INET, SOCK_DGRAM, invalid_portno /*bad*/, EAI_SERVICE}, {0, AF_INET6, ANY, invalid_portno /*bad*/, EAI_SERVICE}, {0, AF_INET6, SOCK_STREAM, invalid_portno /*bad*/, EAI_SERVICE}, {0, AF_INET6, SOCK_DGRAM, invalid_portno /*bad*/, EAI_SERVICE}, {0, AF_UNSPEC, ANY, invalid_portno /*bad*/, EAI_SERVICE}, {0, AF_UNSPEC, SOCK_STREAM, invalid_portno /*bad*/, EAI_SERVICE}, {0, AF_UNSPEC, SOCK_DGRAM, invalid_portno /*bad*/, EAI_SERVICE}, {AI_NUMERICSERV, AF_INET, ANY, http_portname /*bad*/, EAI_NONAME}, {AI_NUMERICSERV, AF_INET, SOCK_STREAM, http_portname /*bad*/, EAI_NONAME}, {AI_NUMERICSERV, AF_INET, SOCK_DGRAM, http_portname /*bad*/, EAI_NONAME}, {AI_NUMERICSERV, AF_INET6, ANY, http_portname /*bad*/, EAI_NONAME}, {AI_NUMERICSERV, AF_INET6, SOCK_STREAM, http_portname /*bad*/, EAI_NONAME}, {AI_NUMERICSERV, AF_INET6, SOCK_DGRAM, http_portname /*bad*/, EAI_NONAME}, {AI_NUMERICSERV, AF_UNSPEC, ANY, http_portname /*bad*/, EAI_NONAME}, {AI_NUMERICSERV, AF_UNSPEC, SOCK_STREAM, http_portname /*bad*/, EAI_NONAME}, {AI_NUMERICSERV, AF_UNSPEC, SOCK_DGRAM, http_portname /*bad*/, EAI_NONAME}, {0, AF_INET, ANY, invalid_portname /*bad*/, EAI_SERVICE}, {0, AF_INET, SOCK_STREAM, invalid_portname /*bad*/, EAI_SERVICE}, {0, AF_INET, SOCK_DGRAM, invalid_portname /*bad*/, EAI_SERVICE}, {0, AF_INET6, ANY, invalid_portname /*bad*/, EAI_SERVICE}, {0, AF_INET6, SOCK_STREAM, invalid_portname /*bad*/, EAI_SERVICE}, {0, AF_INET6, SOCK_DGRAM, invalid_portname /*bad*/, EAI_SERVICE}, {0, AF_UNSPEC, ANY, invalid_portname /*bad*/, EAI_SERVICE}, {0, AF_UNSPEC, SOCK_STREAM, invalid_portname /*bad*/, EAI_SERVICE}, {0, AF_UNSPEC, SOCK_DGRAM, invalid_portname /*bad*/, EAI_SERVICE}, }; for (const auto& config : testConfigs) { const std::string testParameters = config.asParameters(); SCOPED_TRACE(testParameters); const addrinfo hints = { .ai_flags = config.ai_flags, .ai_family = config.ai_family, .ai_socktype = config.ai_socktype, }; addrinfo* result = nullptr; NetworkDnsEventReported event; int rv = resolv_getaddrinfo("localhost", config.servname, &hints, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_EQ(config.expected_eai_error, rv); } } TEST_F(ResolvGetAddrInfoTest, AlphabeticalHostname_NoData) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; constexpr char v4_host_name[] = "v4only.example.com."; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); dns.addMapping(v4_host_name, ns_type::ns_t_a, "1.2.3.3"); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); dns.clearQueries(); // Want AAAA answer but DNS server has A answer only. addrinfo* result = nullptr; const addrinfo hints = {.ai_family = AF_INET6}; NetworkDnsEventReported event; int rv = resolv_getaddrinfo("v4only", nullptr, &hints, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_LE(1U, GetNumQueries(dns, v4_host_name)); EXPECT_EQ(nullptr, result); EXPECT_EQ(EAI_NODATA, rv); } TEST_F(ResolvGetAddrInfoTest, AlphabeticalHostname) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; constexpr char host_name[] = "sawadee.example.com."; constexpr char v4addr[] = "1.2.3.4"; constexpr char v6addr[] = "::1.2.3.4"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); dns.addMapping(host_name, ns_type::ns_t_a, v4addr); dns.addMapping(host_name, ns_type::ns_t_aaaa, v6addr); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); static const struct TestConfig { int ai_family; const std::string expected_addr; } testConfigs[]{ {AF_INET, v4addr}, {AF_INET6, v6addr}, }; for (const auto& config : testConfigs) { SCOPED_TRACE(StringPrintf("family: %d", config.ai_family)); dns.clearQueries(); addrinfo* result = nullptr; const addrinfo hints = {.ai_family = config.ai_family}; NetworkDnsEventReported event; int rv = resolv_getaddrinfo("sawadee", nullptr, &hints, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_EQ(0, rv); EXPECT_TRUE(result != nullptr); EXPECT_EQ(1U, GetNumQueries(dns, host_name)); EXPECT_EQ(config.expected_addr, ToString(result)); } } TEST_F(ResolvGetAddrInfoTest, IllegalHostname) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); // Illegal hostname is verified by res_hnok() in system/netd/resolv/res_comp.cpp. static constexpr char const* illegalHostnames[] = { kBadCharAfterPeriodHost, kBadCharBeforePeriodHost, kBadCharAtTheEndHost, kBadCharInTheMiddleOfLabelHost, }; for (const auto& hostname : illegalHostnames) { // Expect to get no address because hostname format is illegal. // // Ex: // ANSWER SECTION: // a.ex^ample.com. IN A 1.2.3.3 // a.ex^ample.com. IN AAAA 2001:db8::42 // // In this example, querying "a.ex^ample.com" should get no address because // "a.ex^ample.com" has an illegal char '^' in the middle of label. dns.addMapping(hostname, ns_type::ns_t_a, "1.2.3.3"); dns.addMapping(hostname, ns_type::ns_t_aaaa, "2001:db8::42"); for (const auto& family : {AF_INET, AF_INET6, AF_UNSPEC}) { SCOPED_TRACE(StringPrintf("family: %d, config.name: %s", family, hostname)); addrinfo* res = nullptr; const addrinfo hints = {.ai_family = family}; NetworkDnsEventReported event; int rv = resolv_getaddrinfo(hostname, nullptr, &hints, &mNetcontext, &res, &event); ScopedAddrinfo result(res); EXPECT_EQ(nullptr, result); EXPECT_EQ(EAI_FAIL, rv); } } } TEST_F(ResolvGetAddrInfoTest, ServerResponseError) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; constexpr char host_name[] = "hello.example.com."; static const struct TestConfig { ns_rcode rcode; int expected_eai_error; // Only test failure RCODE [1..5] in RFC 1035 section 4.1.1 and skip successful RCODE 0 // which means no error. } testConfigs[]{ // clang-format off {ns_rcode::ns_r_formerr, EAI_FAIL}, {ns_rcode::ns_r_servfail, EAI_AGAIN}, {ns_rcode::ns_r_nxdomain, EAI_NODATA}, {ns_rcode::ns_r_notimpl, EAI_FAIL}, {ns_rcode::ns_r_refused, EAI_FAIL}, // clang-format on }; for (const auto& config : testConfigs) { SCOPED_TRACE(StringPrintf("rcode: %d", config.rcode)); test::DNSResponder dns(listen_addr, listen_srv, config.rcode /*response specific rcode*/); dns.addMapping(host_name, ns_type::ns_t_a, "1.2.3.4"); dns.setResponseProbability(0.0); // always ignore requests and response preset rcode ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); addrinfo* result = nullptr; const addrinfo hints = {.ai_family = AF_UNSPEC}; NetworkDnsEventReported event; int rv = resolv_getaddrinfo(host_name, nullptr, &hints, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_EQ(config.expected_eai_error, rv); } } // TODO: Add private DNS server timeout test. TEST_F(ResolvGetAddrInfoTest, ServerTimeout) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; constexpr char host_name[] = "hello.example.com."; test::DNSResponder dns(listen_addr, listen_srv, static_cast(-1) /*no response*/); dns.addMapping(host_name, ns_type::ns_t_a, "1.2.3.4"); dns.setResponseProbability(0.0); // always ignore requests and don't response ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); addrinfo* result = nullptr; const addrinfo hints = {.ai_family = AF_UNSPEC}; NetworkDnsEventReported event; int rv = resolv_getaddrinfo("hello", nullptr, &hints, &mNetcontext, &result, &event); ScopedAddrinfo result_cleanup(result); EXPECT_EQ(NETD_RESOLV_TIMEOUT, rv); } TEST_F(ResolvGetAddrInfoTest, CnamesNoIpAddress) { constexpr char ACNAME[] = "acname"; // expect a cname in answer constexpr char CNAMES[] = "cnames"; // expect cname chain in answer constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); dns.addMapping("cnames.example.com.", ns_type::ns_t_cname, "acname.example.com."); dns.addMapping("acname.example.com.", ns_type::ns_t_cname, "hello.example.com."); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); static const struct TestConfig { const char* name; int family; } testConfigs[]{ // clang-format off {ACNAME, AF_INET}, {ACNAME, AF_INET6}, {ACNAME, AF_UNSPEC}, {CNAMES, AF_INET}, {CNAMES, AF_INET6}, {CNAMES, AF_UNSPEC}, // clang-format on }; for (const auto& config : testConfigs) { SCOPED_TRACE( StringPrintf("config.family: %d, config.name: %s", config.family, config.name)); addrinfo* res = nullptr; const addrinfo hints = {.ai_family = config.family}; NetworkDnsEventReported event; int rv = resolv_getaddrinfo(config.name, nullptr, &hints, &mNetcontext, &res, &event); ScopedAddrinfo result(res); EXPECT_EQ(nullptr, result); EXPECT_EQ(EAI_FAIL, rv); } } TEST_F(ResolvGetAddrInfoTest, CnamesBrokenChainByIllegalCname) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); static const struct TestConfig { const char* name; const char* cname; std::string asHostName() const { return StringPrintf("%s.example.com.", name); } // Illegal cname is verified by res_hnok() in system/netd/resolv/res_comp.cpp. } testConfigs[]{ // clang-format off {NAME(kBadCharAfterPeriodHost), kBadCharAfterPeriodHost}, {NAME(kBadCharBeforePeriodHost), kBadCharBeforePeriodHost}, {NAME(kBadCharAtTheEndHost), kBadCharAtTheEndHost}, {NAME(kBadCharInTheMiddleOfLabelHost), kBadCharInTheMiddleOfLabelHost}, // clang-format on }; for (const auto& config : testConfigs) { const std::string testHostName = config.asHostName(); // Expect to get no address because the cname chain is broken by an illegal cname format. // // Ex: // ANSWER SECTION: // hello.example.com. IN CNAME a.ex^ample.com. // a.ex^ample.com. IN A 1.2.3.3 // a.ex^ample.com. IN AAAA 2001:db8::42 // // In this example, querying hello.example.com should get no address because // "a.ex^ample.com" has an illegal char '^' in the middle of label. dns.addMapping(testHostName.c_str(), ns_type::ns_t_cname, config.cname); dns.addMapping(config.cname, ns_type::ns_t_a, "1.2.3.3"); dns.addMapping(config.cname, ns_type::ns_t_aaaa, "2001:db8::42"); for (const auto& family : {AF_INET, AF_INET6, AF_UNSPEC}) { SCOPED_TRACE( StringPrintf("family: %d, testHostName: %s", family, testHostName.c_str())); addrinfo* res = nullptr; const addrinfo hints = {.ai_family = family}; NetworkDnsEventReported event; int rv = resolv_getaddrinfo(config.name, nullptr, &hints, &mNetcontext, &res, &event); ScopedAddrinfo result(res); EXPECT_EQ(nullptr, result); EXPECT_EQ(EAI_FAIL, rv); } } } TEST_F(ResolvGetAddrInfoTest, CnamesInfiniteLoop) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); dns.addMapping("hello.example.com.", ns_type::ns_t_cname, "a.example.com."); dns.addMapping("a.example.com.", ns_type::ns_t_cname, "hello.example.com."); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); for (const auto& family : {AF_INET, AF_INET6, AF_UNSPEC}) { SCOPED_TRACE(StringPrintf("family: %d", family)); addrinfo* res = nullptr; const addrinfo hints = {.ai_family = family}; NetworkDnsEventReported event; int rv = resolv_getaddrinfo("hello", nullptr, &hints, &mNetcontext, &res, &event); ScopedAddrinfo result(res); EXPECT_EQ(nullptr, result); EXPECT_EQ(EAI_FAIL, rv); } } TEST_F(GetHostByNameForNetContextTest, AlphabeticalHostname) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; constexpr char host_name[] = "jiababuei.example.com."; constexpr char v4addr[] = "1.2.3.4"; constexpr char v6addr[] = "::1.2.3.4"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); dns.addMapping(host_name, ns_type::ns_t_a, v4addr); dns.addMapping(host_name, ns_type::ns_t_aaaa, v6addr); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); static const struct TestConfig { int ai_family; const std::string expected_addr; } testConfigs[]{ {AF_INET, v4addr}, {AF_INET6, v6addr}, }; for (const auto& config : testConfigs) { SCOPED_TRACE(StringPrintf("family: %d", config.ai_family)); dns.clearQueries(); hostent* hp = nullptr; NetworkDnsEventReported event; int rv = android_gethostbynamefornetcontext("jiababuei", config.ai_family, &mNetcontext, &hp, &event); EXPECT_EQ(0, rv); EXPECT_TRUE(hp != nullptr); EXPECT_EQ(1U, GetNumQueries(dns, host_name)); EXPECT_EQ(config.expected_addr, ToString(hp)); } } TEST_F(GetHostByNameForNetContextTest, IllegalHostname) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); // Illegal hostname is verified by res_hnok() in system/netd/resolv/res_comp.cpp. static constexpr char const* illegalHostnames[] = { kBadCharAfterPeriodHost, kBadCharBeforePeriodHost, kBadCharAtTheEndHost, kBadCharInTheMiddleOfLabelHost, }; for (const auto& hostname : illegalHostnames) { // Expect to get no address because hostname format is illegal. // // Ex: // ANSWER SECTION: // a.ex^ample.com. IN A 1.2.3.3 // a.ex^ample.com. IN AAAA 2001:db8::42 // // In this example, querying "a.ex^ample.com" should get no address because // "a.ex^ample.com" has an illegal char '^' in the middle of label. dns.addMapping(hostname, ns_type::ns_t_a, "1.2.3.3"); dns.addMapping(hostname, ns_type::ns_t_aaaa, "2001:db8::42"); for (const auto& family : {AF_INET, AF_INET6}) { SCOPED_TRACE(StringPrintf("family: %d, config.name: %s", family, hostname)); struct hostent* hp = nullptr; NetworkDnsEventReported event; int rv = android_gethostbynamefornetcontext(hostname, family, &mNetcontext, &hp, &event); EXPECT_EQ(nullptr, hp); EXPECT_EQ(EAI_FAIL, rv); } } } TEST_F(GetHostByNameForNetContextTest, NoData) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; constexpr char v4_host_name[] = "v4only.example.com."; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); dns.addMapping(v4_host_name, ns_type::ns_t_a, "1.2.3.3"); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); dns.clearQueries(); // Want AAAA answer but DNS server has A answer only. hostent* hp = nullptr; NetworkDnsEventReported event; int rv = android_gethostbynamefornetcontext("v4only", AF_INET6, &mNetcontext, &hp, &event); EXPECT_LE(1U, GetNumQueries(dns, v4_host_name)); EXPECT_EQ(nullptr, hp); EXPECT_EQ(EAI_NODATA, rv); } TEST_F(GetHostByNameForNetContextTest, ServerResponseError) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; constexpr char host_name[] = "hello.example.com."; static const struct TestConfig { ns_rcode rcode; int expected_eai_error; // expected result // Only test failure RCODE [1..5] in RFC 1035 section 4.1.1 and skip successful RCODE 0 // which means no error. Note that the return error codes aren't mapped by rcode in the // test case SERVFAIL, NOTIMP and REFUSED. See the comment of res_nsend() // in system\netd\resolv\res_query.cpp for more detail. } testConfigs[]{ // clang-format off {ns_rcode::ns_r_formerr, EAI_FAIL}, {ns_rcode::ns_r_servfail, EAI_AGAIN}, // Not mapped by rcode. {ns_rcode::ns_r_nxdomain, EAI_NODATA}, {ns_rcode::ns_r_notimpl, EAI_AGAIN}, // Not mapped by rcode. {ns_rcode::ns_r_refused, EAI_AGAIN}, // Not mapped by rcode. // clang-format on }; for (const auto& config : testConfigs) { SCOPED_TRACE(StringPrintf("rcode: %d", config.rcode)); test::DNSResponder dns(listen_addr, listen_srv, config.rcode /*response specific rcode*/); dns.addMapping(host_name, ns_type::ns_t_a, "1.2.3.4"); dns.setResponseProbability(0.0); // always ignore requests and response preset rcode ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); hostent* hp = nullptr; NetworkDnsEventReported event; int rv = android_gethostbynamefornetcontext(host_name, AF_INET, &mNetcontext, &hp, &event); EXPECT_EQ(nullptr, hp); EXPECT_EQ(config.expected_eai_error, rv); } } // TODO: Add private DNS server timeout test. TEST_F(GetHostByNameForNetContextTest, ServerTimeout) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; constexpr char host_name[] = "hello.example.com."; test::DNSResponder dns(listen_addr, listen_srv, static_cast(-1) /*no response*/); dns.addMapping(host_name, ns_type::ns_t_a, "1.2.3.4"); dns.setResponseProbability(0.0); // always ignore requests and don't response ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); hostent* hp = nullptr; NetworkDnsEventReported event; int rv = android_gethostbynamefornetcontext(host_name, AF_INET, &mNetcontext, &hp, &event); EXPECT_EQ(NETD_RESOLV_TIMEOUT, rv); } TEST_F(GetHostByNameForNetContextTest, CnamesNoIpAddress) { constexpr char ACNAME[] = "acname"; // expect a cname in answer constexpr char CNAMES[] = "cnames"; // expect cname chain in answer constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); dns.addMapping("cnames.example.com.", ns_type::ns_t_cname, "acname.example.com."); dns.addMapping("acname.example.com.", ns_type::ns_t_cname, "hello.example.com."); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); static const struct TestConfig { const char* name; int family; } testConfigs[]{ {ACNAME, AF_INET}, {ACNAME, AF_INET6}, {CNAMES, AF_INET}, {CNAMES, AF_INET6}, }; for (const auto& config : testConfigs) { SCOPED_TRACE( StringPrintf("config.family: %d, config.name: %s", config.family, config.name)); struct hostent* hp = nullptr; NetworkDnsEventReported event; int rv = android_gethostbynamefornetcontext(config.name, config.family, &mNetcontext, &hp, &event); EXPECT_EQ(nullptr, hp); EXPECT_EQ(EAI_FAIL, rv); } } TEST_F(GetHostByNameForNetContextTest, CnamesBrokenChainByIllegalCname) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); static const struct TestConfig { const char* name; const char* cname; std::string asHostName() const { return StringPrintf("%s.example.com.", name); } // Illegal cname is verified by res_hnok() in system/netd/resolv/res_comp.cpp } testConfigs[]{ // clang-format off {NAME(kBadCharAfterPeriodHost), kBadCharAfterPeriodHost}, {NAME(kBadCharBeforePeriodHost), kBadCharBeforePeriodHost}, {NAME(kBadCharAtTheEndHost), kBadCharAtTheEndHost}, {NAME(kBadCharInTheMiddleOfLabelHost), kBadCharInTheMiddleOfLabelHost}, // clang-format on }; for (const auto& config : testConfigs) { const std::string testHostName = config.asHostName(); // Expect to get no address because the cname chain is broken by an illegal cname format. // // Ex: // ANSWER SECTION: // hello.example.com. IN CNAME a.ex^ample.com. // a.ex^ample.com. IN A 1.2.3.3 // a.ex^ample.com. IN AAAA 2001:db8::42 // // In this example, querying hello.example.com should get no address because // "a.ex^ample.com" has an illegal char '^' in the middle of label. dns.addMapping(testHostName.c_str(), ns_type::ns_t_cname, config.cname); dns.addMapping(config.cname, ns_type::ns_t_a, "1.2.3.3"); dns.addMapping(config.cname, ns_type::ns_t_aaaa, "2001:db8::42"); for (const auto& family : {AF_INET, AF_INET6}) { SCOPED_TRACE( StringPrintf("family: %d, testHostName: %s", family, testHostName.c_str())); struct hostent* hp = nullptr; NetworkDnsEventReported event; int rv = android_gethostbynamefornetcontext(config.name, family, &mNetcontext, &hp, &event); EXPECT_EQ(nullptr, hp); EXPECT_EQ(EAI_FAIL, rv); } } } TEST_F(GetHostByNameForNetContextTest, CnamesInfiniteLoop) { constexpr char listen_addr[] = "127.0.0.3"; constexpr char listen_srv[] = "53"; test::DNSResponder dns(listen_addr, listen_srv, ns_rcode::ns_r_servfail); dns.addMapping("hello.example.com.", ns_type::ns_t_cname, "a.example.com."); dns.addMapping("a.example.com.", ns_type::ns_t_cname, "hello.example.com."); ASSERT_TRUE(dns.startServer()); const char* servers[] = {listen_addr}; ASSERT_EQ(0, resolv_set_nameservers(TEST_NETID, servers, std::size(servers), mDefaultSearchDomains, &mDefaultParams_Binder)); for (const auto& family : {AF_INET, AF_INET6}) { SCOPED_TRACE(StringPrintf("family: %d", family)); struct hostent* hp = nullptr; NetworkDnsEventReported event; int rv = android_gethostbynamefornetcontext("hello", family, &mNetcontext, &hp, &event); EXPECT_EQ(nullptr, hp); EXPECT_EQ(EAI_FAIL, rv); } } // Note that local host file function, files_getaddrinfo(), of resolv_getaddrinfo() // is not tested because it only returns a boolean (success or failure) without any error number. // TODO: Simplify the DNS server configuration, DNSResponder and resolv_set_nameservers, as // ResolverTest does. // TODO: Add test for resolv_getaddrinfo(). // - DNS response message parsing. // - Unexpected type of resource record (RR). // - Invalid length CNAME, or QNAME. // - Unexpected amount of questions. // - CNAME RDATA with the domain name which has null label(s). // TODO: Add test for android_gethostbynamefornetcontext(). // - Invalid parameters. // - DNS response message parsing. // - Unexpected type of resource record (RR). // - Invalid length CNAME, or QNAME. // - Unexpected amount of questions. // - CNAME RDATA with the domain name which has null label(s). // TODO: Add test for android_gethostbyaddrfornetcontext(). } // end of namespace net } // end of namespace android