diff options
| author | Evgenii Stepanov <eugenis@google.com> | 2020-07-20 15:52:06 -0700 |
|---|---|---|
| committer | Evgenii Stepanov <eugenis@google.com> | 2020-07-23 14:27:53 -0700 |
| commit | ac7ffe344e6aa5b96c47a3ba2388b71f19abb955 (patch) | |
| tree | f7123a2be6eab3518bf7433c65075e8a733bfebe /tests | |
| parent | 1e4793561f4af8d591d25d70d82691968feadddb (diff) | |
Remove stack address check in cfi_basic test.
This is not actually a property that is guaranteed by the bionic
implementation of CFI shadow. Since the gaps between libraries are not
completely inaccessible, it is possible for a stack mapping to sneak in,
which would cause the callback to register in the test library.
This is not a correctness issue in CFI as the actual __cfi_check
callback will reject such address anyway, at a small CPU cost.
Bug: 156218352
Test: CtsBionicTestCases-cfi_test#basic
Change-Id: I8d04fb7132e1eac2a8abfbc48a37c8eac6e25a09
(cherry picked from commit 0f6b504e0c682e7c3d377416dacfe57b6c59f1b8)
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/cfi_test.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/tests/cfi_test.cpp b/tests/cfi_test.cpp index e155e1a84..b4522ec8b 100644 --- a/tests/cfi_test.cpp +++ b/tests/cfi_test.cpp @@ -85,9 +85,6 @@ TEST(cfi_test, basic) { EXPECT_EQ(get_global_address(), get_last_address()); EXPECT_EQ(c, get_count()); - // CFI check for a stack address. This is always invalid and gets the process killed. - EXPECT_DEATH(__cfi_slowpath(45, reinterpret_cast<void*>(&c)), ""); - // CFI check for a heap address. This is always invalid and gets the process killed. void* p = malloc(4096); EXPECT_DEATH(__cfi_slowpath(46, p), ""); |