[C++] $(eval) stops when first character is '#'

Regression when compared to GNU make behaviour.

Test case:

 $ cat ../Makefile.comment-in-macro
 .PHONY: all

 define _rule
 # comment
 all:
        :
 endef

 $(eval $(_rule))

 $ make -f Makefile.comment-in-macro
 :
 $ ckati --ninja --ninja_dir . --gen_all_targets -f Makefile.comment-in-macro
 *** No targets.

Fixes https://github.com/google/kati/issues/74

2 files changed, 9 insertions, 4 deletions

diff --git a/func.cc b/func.cc
index a7d1c8c..ab584c9 100644
--- a/func.cc
+++ b/func.cc
@@ -458,10 +458,6 @@ void EvalFunc(const vector<Value*>& args, Evaluator* ev, string*) {
   //const string text = args[0]->Eval(ev);
   string* text = new string;
   args[0]->Eval(ev, text);
-  if ((*text)[0] == '#') {
-    delete text;
-    return;
-  }
   if (ev->avoid_io()) {
     KATI_WARN("%s:%d: *warning*: $(eval) in a recipe is not recommended: %s",
               LOCF(ev->loc()), text->c_str());
diff --git a/testcase/eval_starts_with_comment.mk b/testcase/eval_starts_with_comment.mk
new file mode 100644
index 0000000..c3adca4
--- /dev/null
+++ b/testcase/eval_starts_with_comment.mk
@@ -0,0 +1,9 @@
+.PHONY: test
+
+define _rule
+# comment
+test:
+	echo PASS
+endef
+
+$(eval $(_rule))