diff options
| author | Dan Willemsen <dwillemsen@google.com> | 2016-09-29 20:09:47 -0700 |
|---|---|---|
| committer | Dan Willemsen <dwillemsen@google.com> | 2016-09-29 22:21:10 -0700 |
| commit | f87d49e41a5dd57733d02f3990c91dc38e557dad (patch) | |
| tree | 9533b73a9ec811257ed79f12467e50d83df0d2fd /var.h | |
| parent | 5e45e973c38c92c42cc86aa5dafeca13e6823b5f (diff) | |
Support marking variables as readonly
When the magic variable .KATI_READONLY is set to a variable name, any
further attempts to modify the named variable will result in an error.
FOO := bar
.KATI_READONLY := FOO
FOO := baz # Error!
This is useful to make some global configuration readonly so that
another makefile cannot change it. In Android, we emulated this by
backing up some global configuration before including the Android.mk
files, then comparing the current values to the backed up values after
they've been included. But this means we don't know the location that
modified the variable, just that something did. And it's not perfect,
since the backup can also be changed.
Something similar to this could be implemented with `override`, but then
setting the variable silently fails, and it still could be overriden
with another override.
Diffstat (limited to 'var.h')
| -rw-r--r-- | var.h | 8 |
1 files changed, 7 insertions, 1 deletions
@@ -56,8 +56,14 @@ class Var : public Evaluable { virtual string DebugString() const = 0; + bool ReadOnly() const { return readonly_; } + void SetReadOnly() { readonly_ = true; } + protected: Var(); + + private: + bool readonly_; }; class SimpleVar : public Var { @@ -177,7 +183,7 @@ class Vars : public unordered_map<Symbol, Var*> { Var* Lookup(Symbol name) const; - void Assign(Symbol name, Var* v); + void Assign(Symbol name, Var* v, bool* readonly); static void add_used_env_vars(Symbol v); |
