summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyle Repinski <repinski23@gmail.com>2015-01-01 20:51:13 -0600
committerKyle Repinski <repinski23@gmail.com>2015-01-01 20:51:13 -0600
commit89b0c6386e3b421ffe36eaf773704f23a83909bc (patch)
treecaae6171da41ee1b9dbf989f30016fade65143cd
parent237d578c27e9e08868c494cf553538e5b57f56ca (diff)
Make TARGET_KERNEL_CUSTOM_TOOLCHAIN conditional, expand on comments.
-rw-r--r--BoardConfig.mk8
1 files changed, 7 insertions, 1 deletions
diff --git a/BoardConfig.mk b/BoardConfig.mk
index b206aa4..0794b5d 100644
--- a/BoardConfig.mk
+++ b/BoardConfig.mk
@@ -48,8 +48,14 @@ BOARD_KERNEL_BASE := 0x80000000
TARGET_KERNEL_CONFIG := fml_tuna_defconfig
TARGET_KERNEL_SOURCE := kernel/samsung/tuna
-# GCC 4.8 somehow breaks the eMMC patch applied on boot-up for VYL00M eMMCs on maguro
+# GCC 4.8 somehow breaks the eMMC patch applied on boot-up for VYL00M eMMCs on maguro.
+# While this can be worked around, I don't trust it for anything. All tuna kernel devs
+# seem to be in agreement on 4.8 being terrible for the kernel, and it's not just tuna
+# that has issues with it. GCC 4.9 is better than 4.8 at least though; so, if we're not
+# using GCC 4.9 for the kernel build, force GCC 4.7, which is rock-solid for kernels.
+ifneq ($(TARGET_GCC_VERSION_OTHER),4.9)
TARGET_KERNEL_CUSTOM_TOOLCHAIN := arm-eabi-4.7
+endif
TARGET_PREBUILT_KERNEL := $(DEVICE_FOLDER)/kernel