aboutsummaryrefslogtreecommitdiff
path: root/gm/mixedtextblobs.cpp
diff options
context:
space:
mode:
authorLeon Scroggins <scroggo@google.com>2017-11-15 13:49:19 +0000
committerSkia Commit-Bot <skia-commit-bot@chromium.org>2017-11-15 13:49:27 +0000
commit2009c20309a2a91d1fb9020385b56eeae06a1fb1 (patch)
tree57bd836a783eaa2d0eec1ab7ab283f79c2e48003 /gm/mixedtextblobs.cpp
parent2b6f614dac7c984ffd10cb59c499c9bd872d9695 (diff)
Revert "Fix webp bug compositing alpha frames on opaque"
This reverts commit 42bae8faa4b9b6a3341b15c6ac7c6b466e95625c. Reason for revert: Breaking GMs. A more extensive fix is needed. Original change's description: > Fix webp bug compositing alpha frames on opaque > > select_xform_alpha is used to determine how the color transform should > handle alpha values. In a similar way, we're using it here to determine > whether to premultiply pixels before blending them. In this case, the > source is unpremul, so we should be premultiplying them, but since we > are compositing on an opaque frame, the dst must be opaque and > select_xform_alpha returns kOpaque. As a result, we do not premultiply > (and even hint to the transform that the pixels are opaque). Since this > all applies to the pre-blended pixels, we should not care that the dst > is opaque. So drop the call to select_xform_alpha and just use the alpha > type of the source. This matches the comment on the lines above. > > Add the test image that failed (https://mathiasbynens.be/demo/animated-webp) > > Change-Id: Ibd13c1f067bdf369ce1c882d4f6057aadccfa313 > Reviewed-on: https://skia-review.googlesource.com/71560 > Commit-Queue: Leon Scroggins <scroggo@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,scroggo@google.com Change-Id: I6f535ff9b773a93e02a0358b830291594a6e738c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/71720 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
Diffstat (limited to 'gm/mixedtextblobs.cpp')
0 files changed, 0 insertions, 0 deletions