diff options
| author | senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2011-05-19 19:58:58 +0000 |
|---|---|---|
| committer | senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2011-05-19 19:58:58 +0000 |
| commit | 64cc579efa7e416c7298ed159d76b074b283c0f9 (patch) | |
| tree | 67a25945efd79dd7e76afa3126c01032a4086891 /samplecode/SampleComplexClip.cpp | |
| parent | 9e0f2ee0333244de11cc8e41c667bc676bc3d1a5 (diff) | |
The plain Makefile was using -Wall, but the gyp build wasn't. This CL turns on
-Wall -Wextra and -Wno-unused in common.gypi. This revealed a lot of warnings
(and some actual bugs), all of which I fixed here. This is pretty mindless
stuff for the most part (order of intialization, missing initializers, && within
||, etc), but will allow us to build cleanly with -Wall and -Wextra (and
-Werror, if we so choose).
I put defaults into switches that were missing cases. I could put in the actual
missing enums instead if that's desired. I could also assert on missing enums
instead of break, if that's desired. I wasn't sure how to test the stuff in
"animator", so that should be looked at a bit more closely.
Review URL: http://codereview.appspot.com/4547055/
git-svn-id: http://skia.googlecode.com/svn/trunk@1386 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'samplecode/SampleComplexClip.cpp')
| -rw-r--r-- | samplecode/SampleComplexClip.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/samplecode/SampleComplexClip.cpp b/samplecode/SampleComplexClip.cpp index 8ee078b2fa..672d0555c5 100644 --- a/samplecode/SampleComplexClip.cpp +++ b/samplecode/SampleComplexClip.cpp @@ -88,7 +88,7 @@ protected: canvas->save(); for (int invA = 0; invA < 2; ++invA) { - for (int op = 0; op < SK_ARRAY_COUNT(gOps); ++op) { + for (size_t op = 0; op < SK_ARRAY_COUNT(gOps); ++op) { int idx = invA * SK_ARRAY_COUNT(gOps) + op; if (!(idx % 3)) { canvas->restore(); |