diff options
| author | TreeHugger Robot <treehugger-gerrit@google.com> | 2020-05-13 22:42:56 +0000 |
|---|---|---|
| committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2020-05-13 22:42:56 +0000 |
| commit | 7c19660f438e897b68451ea2cf8e4515a0806fcf (patch) | |
| tree | 123546762b09fad69e776fb410b0501b5e31622c | |
| parent | 22d1212d000e772fdbd46b54ec7534006f681d10 (diff) | |
| parent | 4d857ccce56327ae6eb0e086d98f9f0e169fbb42 (diff) | |
Merge "Revert tab key behavior on multiline EditTexts." into rvc-dev am: 4d857ccce5
Change-Id: I81f0a872137da5f7063cb767c60fce9e3c9a705d
| -rw-r--r-- | core/java/android/widget/TextView.java | 22 |
1 files changed, 2 insertions, 20 deletions
diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java index 29914aababe3..226f57976ec8 100644 --- a/core/java/android/widget/TextView.java +++ b/core/java/android/widget/TextView.java @@ -8315,23 +8315,6 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener return false; } - /** - * Returns true if pressing TAB in this field advances focus instead - * of inserting the character. Insert tabs only in multi-line editors. - */ - private boolean shouldAdvanceFocusOnTab() { - if (getKeyListener() != null && !mSingleLine && mEditor != null - && (mEditor.mInputType & EditorInfo.TYPE_MASK_CLASS) - == EditorInfo.TYPE_CLASS_TEXT) { - int multilineFlags = EditorInfo.TYPE_TEXT_FLAG_IME_MULTI_LINE - | EditorInfo.TYPE_TEXT_FLAG_MULTI_LINE; - if ((mEditor.mInputType & multilineFlags) != 0) { - return false; - } - } - return true; - } - private boolean isDirectionalNavigationKey(int keyCode) { switch(keyCode) { case KeyEvent.KEYCODE_DPAD_UP: @@ -8400,9 +8383,8 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener case KeyEvent.KEYCODE_TAB: if (event.hasNoModifiers() || event.hasModifiers(KeyEvent.META_SHIFT_ON)) { - if (shouldAdvanceFocusOnTab()) { - return KEY_EVENT_NOT_HANDLED; - } + // Tab is used to move focus. + return KEY_EVENT_NOT_HANDLED; } break; |
