summaryrefslogtreecommitdiff
path: root/core/java/android/app/Dialog.java
diff options
context:
space:
mode:
authorRomain Guy <romainguy@google.com>2012-05-04 17:18:29 -0700
committerRomain Guy <romainguy@google.com>2012-05-04 17:18:29 -0700
commit05e1c3a6913e049c7972ac727f57b7d3bf8d8552 (patch)
tree5b87a6ce7a270402dade7ba25dd2e324b6e3a645 /core/java/android/app/Dialog.java
parentc9c23196a11bda6fbc1c44f6d170b3626b036474 (diff)
Don't check whether dismiss() is called on the UI thread
Bug #6436642 An app invoking dismiss() during a draw pass could cause crashes. This change makes the code simpler too. Change-Id: Iba89a8522e23d02f87697cfeec6cc713a1462669
Diffstat (limited to 'core/java/android/app/Dialog.java')
-rw-r--r--core/java/android/app/Dialog.java9
1 files changed, 1 insertions, 8 deletions
diff --git a/core/java/android/app/Dialog.java b/core/java/android/app/Dialog.java
index f04ff6a6b9a5..4a5b8ebd4645 100644
--- a/core/java/android/app/Dialog.java
+++ b/core/java/android/app/Dialog.java
@@ -103,7 +103,6 @@ public class Dialog implements DialogInterface, Window.Callback,
private boolean mShowing = false;
private boolean mCanceled = false;
- private final Thread mUiThread;
private final Handler mHandler = new Handler();
private static final int DISMISS = 0x43;
@@ -162,7 +161,6 @@ public class Dialog implements DialogInterface, Window.Callback,
w.setCallback(this);
w.setWindowManager(mWindowManager, null, null);
w.setGravity(Gravity.CENTER);
- mUiThread = Thread.currentThread();
mListenersHandler = new ListenersHandler(this);
}
@@ -299,12 +297,7 @@ public class Dialog implements DialogInterface, Window.Callback,
* that in {@link #onStop}.
*/
public void dismiss() {
- if (Thread.currentThread() != mUiThread) {
- mHandler.post(mDismissAction);
- } else {
- mHandler.removeCallbacks(mDismissAction);
- mDismissAction.run();
- }
+ mHandler.post(mDismissAction);
}
void dismissDialog() {