diff options
| author | Kweku Adams <kwekua@google.com> | 2018-01-23 13:33:12 -0800 |
|---|---|---|
| committer | Kweku Adams <kwekua@google.com> | 2018-01-23 13:36:23 -0800 |
| commit | bc84aecc76b75fb8a4fa9df10f3cc84dbaf4a5d4 (patch) | |
| tree | 31bc8c72c02d4aa43a59124e44f3ed7e3145298d /core/java/android/app/NotificationChannelGroup.java | |
| parent | fc027600b5da36e0b60054b51a4ad8af606a7ec4 (diff) | |
Fixing bugs in Notification proto dumping.
Also changing method signatures to be more in line with our convention.
Based on some of the changes I went through, it looks like:
1. We were only legitimately saving the very last NotificationRecord
that was dumped.
2. We weren't dumping any NotificationChannels into
NotificationChannelGroup protos.
Bug: 65750824
Test: Android builds
Change-Id: I8c1ef90cf69d8ea00a7bad0c67445741056e23ef
Diffstat (limited to 'core/java/android/app/NotificationChannelGroup.java')
| -rw-r--r-- | core/java/android/app/NotificationChannelGroup.java | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/core/java/android/app/NotificationChannelGroup.java b/core/java/android/app/NotificationChannelGroup.java index 5cb7fb7a6707..16166f7cf1cf 100644 --- a/core/java/android/app/NotificationChannelGroup.java +++ b/core/java/android/app/NotificationChannelGroup.java @@ -298,13 +298,17 @@ public final class NotificationChannelGroup implements Parcelable { } /** @hide */ - public void toProto(ProtoOutputStream proto) { + public void writeToProto(ProtoOutputStream proto, long fieldId) { + final long token = proto.start(fieldId); + proto.write(NotificationChannelGroupProto.ID, mId); proto.write(NotificationChannelGroupProto.NAME, mName.toString()); proto.write(NotificationChannelGroupProto.DESCRIPTION, mDescription); proto.write(NotificationChannelGroupProto.IS_BLOCKED, mBlocked); for (NotificationChannel channel : mChannels) { - channel.toProto(proto); + channel.writeToProto(proto, NotificationChannelGroupProto.CHANNELS); } + + proto.end(token); } } |
