diff options
| author | Tony Mak <tonymak@google.com> | 2022-02-01 20:32:36 +0000 |
|---|---|---|
| committer | Tony Mak <tonymak@google.com> | 2022-02-01 20:47:26 +0000 |
| commit | 11bd64482249c9257ee22390de15f69f9c834247 (patch) | |
| tree | 0d76d90c18f0f9ad4ff583b36de968323673ebee /core/java/android/inputmethodservice/InputMethodService.java | |
| parent | e685a9dd493a95925fa16ab42a7d9c0ad6956b21 (diff) | |
Fix the empty selection issue when onCreateActionMode returns false
One of the optimizations ag/12911059 did was calling
SelectionModifierCursorController.show() before
startActionModeInternal(). The rationale was that if we start the action
mode first, SelectionModifierCursorController.show() would end up
invalidating the action mode twice unnecessarily, once for each handle.
However, with this optimization, we are calling
SelectionModifierCursorController.show() even when onCreateActionMode
returns false.
Reverted this particular optimization to fix the issue.
Added a test which was failing without this fix but passing with it.
Fixes: 199380016
Fixes: 214341747
Test: atest TextViewActivityTest
Change-Id: I793f76a23978cbbbbde2d16e8a522615174bcdd5
Diffstat (limited to 'core/java/android/inputmethodservice/InputMethodService.java')
0 files changed, 0 insertions, 0 deletions