diff options
| author | Yohei Yukawa <yukawa@google.com> | 2022-02-04 12:49:21 -0800 |
|---|---|---|
| committer | Yohei Yukawa <yukawa@google.com> | 2022-02-04 12:49:21 -0800 |
| commit | bf122b9f946d8d6bf99aa1793da4c2dd43c27a06 (patch) | |
| tree | db86943b3c06297685d9b686aa41209141c03090 /core/java/android/inputmethodservice/NavigationBarController.java | |
| parent | fbd689e9520e06e020a8231bde7960cf97f69c2c (diff) | |
Have both NAVIGATION_HINT_IME{,_SWITCHER}_SHOWN
This is a mechanical renaming CL with no behavior change.
Somehow NAVIGATION_HINT_IME_SHOWN was set when the IME switcher needs
to be shown, not when the IME is shown. This CL aims to avoid future
confusions by also introducing
NAVIGATION_HINT_IME_SWITCHER_SHOWN
then setting NAVIGATION_HINT_IME_SHOWN when the IME is actually shown.
This CL also updates NavigationBarTest to verify those flags.
Bug: 192412909
Bug: 217755059
Test: atest SystemUITests:NavigationBarTest
Change-Id: I8bdd58d040689953072c7f384ece2bca677265e1
Diffstat (limited to 'core/java/android/inputmethodservice/NavigationBarController.java')
| -rw-r--r-- | core/java/android/inputmethodservice/NavigationBarController.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/java/android/inputmethodservice/NavigationBarController.java b/core/java/android/inputmethodservice/NavigationBarController.java index 83fc7276eabc..c3bb381bb740 100644 --- a/core/java/android/inputmethodservice/NavigationBarController.java +++ b/core/java/android/inputmethodservice/NavigationBarController.java @@ -219,7 +219,7 @@ final class NavigationBarController { // TODO(b/213337792): Set NAVIGATION_HINT_IME_SHOWN only when necessary. final int hints = StatusBarManager.NAVIGATION_HINT_BACK_ALT | (mShouldShowImeSwitcherWhenImeIsShown - ? StatusBarManager.NAVIGATION_HINT_IME_SHOWN + ? StatusBarManager.NAVIGATION_HINT_IME_SWITCHER_SHOWN : 0); navigationBarView.setNavigationIconHints(hints); } @@ -470,7 +470,7 @@ final class NavigationBarController { } final int hints = StatusBarManager.NAVIGATION_HINT_BACK_ALT | (shouldShowImeSwitcherWhenImeIsShown - ? StatusBarManager.NAVIGATION_HINT_IME_SHOWN : 0); + ? StatusBarManager.NAVIGATION_HINT_IME_SWITCHER_SHOWN : 0); navigationBarView.setNavigationIconHints(hints); } |
