diff options
| author | Yohei Yukawa <yukawa@google.com> | 2021-07-16 12:09:37 -0700 |
|---|---|---|
| committer | Yohei Yukawa <yukawa@google.com> | 2021-07-16 12:09:37 -0700 |
| commit | 3f7c4a3c0d504ae9dba1013574e48a9df205380b (patch) | |
| tree | fdadc1e561f18fc8c838d95237cc804da1769b71 /core/java/android/inputmethodservice/RemoteInputConnection.java | |
| parent | c577086e39b857e787a230403c8125b6785b995f (diff) | |
Check MissingMethodFlags.COMMIT_CORRECTION at the right place
This is a follow up CL to my previous CL [1], which aimed to put an
early-exit check for
InputConnection#commitCorrection(CorrectionInfo)
but mistakenly put it in
InputConnection#commitCompletion(CompletionInfo).
With this CL the early-exit check will be placed at the right place.
[1]: I3c58fadd924fad72cb984f0c23d3099fd0295c64
19a80a1e807acd00bec999eaac7812da6ffce954
Fix: 193907158
Test: atest CtsInputMethodTestCases:InputConnectionEndToEndTest
Change-Id: I497628165072c73d0e279f89afe0d8730531ecfc
Diffstat (limited to 'core/java/android/inputmethodservice/RemoteInputConnection.java')
| -rw-r--r-- | core/java/android/inputmethodservice/RemoteInputConnection.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/core/java/android/inputmethodservice/RemoteInputConnection.java b/core/java/android/inputmethodservice/RemoteInputConnection.java index 4fa98be75b46..ff6265f8d699 100644 --- a/core/java/android/inputmethodservice/RemoteInputConnection.java +++ b/core/java/android/inputmethodservice/RemoteInputConnection.java @@ -247,15 +247,15 @@ final class RemoteInputConnection implements InputConnection { @AnyThread public boolean commitCompletion(CompletionInfo text) { - if (isMethodMissing(MissingMethodFlags.COMMIT_CORRECTION)) { - // This method is not implemented. - return false; - } return mInvoker.commitCompletion(text); } @AnyThread public boolean commitCorrection(CorrectionInfo correctionInfo) { + if (isMethodMissing(MissingMethodFlags.COMMIT_CORRECTION)) { + // This method is not implemented. + return false; + } return mInvoker.commitCorrection(correctionInfo); } |
