summaryrefslogtreecommitdiff
path: root/core/java/android/inputmethodservice/SoftInputWindow.java
diff options
context:
space:
mode:
authorYohei Yukawa <yukawa@google.com>2022-01-03 16:49:24 -0800
committerYohei Yukawa <yukawa@google.com>2022-01-03 16:49:24 -0800
commitef936ff07dcf97bb5f6ccabc411367aaeb0cdb06 (patch)
tree7490fc5c0099f7c65d02054a6050f330a46aa099 /core/java/android/inputmethodservice/SoftInputWindow.java
parentc2dc611aca82dddb5a4fdc88ec168d5c3aa868fb (diff)
Deprecate SoftInputWindowProto.{name,window_type,gravity,takes_focus}
This is a follow up CL to my previous CL [1], which made it clear that the following 4 tracing fields in SoftInputWindowProto had always been logged with the same values. - name: "InputMethod" - window_type: WindowManager.LayoutParams.TYPE_INPUT_METHOD - gravity: Gravity.BOTTOM - takes_focus: false This CL simply deprecates those fields in favor of simplicity and smaller code size. There should be no behavior change unless IME tracing is enabled. [1]: I619ae6011f5e66dba126931719569a97513eaa7e ea7801bd267f98fba10741b88bc900aef9f84121 Bug: 192412909 Test: IME tracing still works Change-Id: I04b59307ecf2c692282c7882ac839f77c94b938f
Diffstat (limited to 'core/java/android/inputmethodservice/SoftInputWindow.java')
-rw-r--r--core/java/android/inputmethodservice/SoftInputWindow.java10
1 files changed, 0 insertions, 10 deletions
diff --git a/core/java/android/inputmethodservice/SoftInputWindow.java b/core/java/android/inputmethodservice/SoftInputWindow.java
index 66288d6d3efe..6c8eb41d8724 100644
--- a/core/java/android/inputmethodservice/SoftInputWindow.java
+++ b/core/java/android/inputmethodservice/SoftInputWindow.java
@@ -17,11 +17,7 @@
package android.inputmethodservice;
import static android.inputmethodservice.SoftInputWindowProto.BOUNDS;
-import static android.inputmethodservice.SoftInputWindowProto.GRAVITY;
-import static android.inputmethodservice.SoftInputWindowProto.NAME;
-import static android.inputmethodservice.SoftInputWindowProto.TAKES_FOCUS;
import static android.inputmethodservice.SoftInputWindowProto.WINDOW_STATE;
-import static android.inputmethodservice.SoftInputWindowProto.WINDOW_TYPE;
import static java.lang.annotation.RetentionPolicy.SOURCE;
@@ -33,7 +29,6 @@ import android.os.Debug;
import android.os.IBinder;
import android.util.Log;
import android.util.proto.ProtoOutputStream;
-import android.view.Gravity;
import android.view.KeyEvent;
import android.view.MotionEvent;
import android.view.View;
@@ -268,11 +263,6 @@ final class SoftInputWindow extends Dialog {
void dumpDebug(ProtoOutputStream proto, long fieldId) {
final long token = proto.start(fieldId);
- // TODO(b/192412909): Deprecate the following 4 entries, as they are all constant.
- proto.write(NAME, "InputMethod");
- proto.write(WINDOW_TYPE, WindowManager.LayoutParams.TYPE_INPUT_METHOD);
- proto.write(GRAVITY, Gravity.BOTTOM);
- proto.write(TAKES_FOCUS, false);
mBounds.dumpDebug(proto, BOUNDS);
proto.write(WINDOW_STATE, mWindowState);
proto.end(token);