summaryrefslogtreecommitdiff
path: root/core/java/android/text/TextShaper.java
diff options
context:
space:
mode:
authorSeigo Nonaka <nona@google.com>2020-10-19 23:14:04 -0700
committerSeigo Nonaka <nona@google.com>2020-10-19 23:31:35 -0700
commit170e0949f3c67decaa67d3fcce6a9776268691ff (patch)
treedc52a8c628df2c8f25088f7181b29678fa17cc25 /core/java/android/text/TextShaper.java
parent276718dee090fd9613c6149dee89e87619f97ee5 (diff)
Fix wrong offset of BiDi text by TextShaper
This CL includes: - Fix relative offset of BidiRun by reviving width calculation in TextLine. - Fix bidi level buffer offset. It shuold be relative to the substring, but the absolute offset was passed. - Removed paint argument from PositionedGlyph which is not used. Bug: 171275519 Test: atest android.graphics.text.cts.TextRunShaperTest Test: atest android.text.cts.TextShaperTest Change-Id: I36949089d744bdfae61995210b2051866a7510ac
Diffstat (limited to 'core/java/android/text/TextShaper.java')
-rw-r--r--core/java/android/text/TextShaper.java6
1 files changed, 5 insertions, 1 deletions
diff --git a/core/java/android/text/TextShaper.java b/core/java/android/text/TextShaper.java
index dd2570401b3e..02fd7b4470f0 100644
--- a/core/java/android/text/TextShaper.java
+++ b/core/java/android/text/TextShaper.java
@@ -198,6 +198,10 @@ public class TextShaper {
/**
* Shape multi-styled text.
*
+ * In the LTR context, the shape result will go from left to right, thus you may want to draw
+ * glyphs from left most position of the canvas. In the RTL context, the shape result will go
+ * from right to left, thus you may want to draw glyphs from right most position of the canvas.
+ *
* @param text a styled text.
* @param start a start index of shaping target in the text.
* @param count a length of shaping target in the text.
@@ -215,7 +219,7 @@ public class TextShaper {
try {
tl.set(paint, text, start, start + count,
mp.getParagraphDir(),
- mp.getDirections(start, start + count),
+ mp.getDirections(0, count),
false /* tabstop is not supported */,
null,
-1, -1 // ellipsis is not supported.