summaryrefslogtreecommitdiff
path: root/core/java/android/widget/DateTimeView.java
diff options
context:
space:
mode:
authorCalvin Pan <calvinpan@google.com>2022-01-17 12:05:48 +0800
committerCalvin Pan <calvinpan@google.com>2022-01-26 11:55:11 +0800
commite4692b7caecfab2adddb0907318e124b3f7a48ab (patch)
tree601f92c5e8f61c2cbc3845475f5d938cbff00fa5 /core/java/android/widget/DateTimeView.java
parentd593f653452ac58a00dae5610fa6deb03af1a2f2 (diff)
Clean <plurals> in DateTimeView
Bug: 199230228 Test: make Change-Id: Ib484fc0c59f7900b751f4e782dd67c000cc855bb
Diffstat (limited to 'core/java/android/widget/DateTimeView.java')
-rw-r--r--core/java/android/widget/DateTimeView.java87
1 files changed, 41 insertions, 46 deletions
diff --git a/core/java/android/widget/DateTimeView.java b/core/java/android/widget/DateTimeView.java
index 955552289c3a..2c6264783f56 100644
--- a/core/java/android/widget/DateTimeView.java
+++ b/core/java/android/widget/DateTimeView.java
@@ -33,6 +33,7 @@ import android.database.ContentObserver;
import android.os.Build;
import android.os.Handler;
import android.util.AttributeSet;
+import android.util.PluralsMessageFormatter;
import android.view.accessibility.AccessibilityNodeInfo;
import android.view.inspector.InspectableProperty;
import android.widget.RemoteViews.RemoteView;
@@ -48,6 +49,8 @@ import java.time.ZoneId;
import java.time.temporal.JulianFields;
import java.util.ArrayList;
import java.util.Date;
+import java.util.HashMap;
+import java.util.Map;
//
// TODO
@@ -260,19 +263,17 @@ public class DateTimeView extends TextView {
return;
} else if (duration < HOUR_IN_MILLIS) {
count = (int)(duration / MINUTE_IN_MILLIS);
- result = String.format(getContext().getResources().getQuantityString(past
- ? com.android.internal.R.plurals.duration_minutes_shortest
- : com.android.internal.R.plurals.duration_minutes_shortest_future,
- count),
+ result = getContext().getResources().getString(past
+ ? com.android.internal.R.string.duration_minutes_shortest
+ : com.android.internal.R.string.duration_minutes_shortest_future,
count);
millisIncrease = MINUTE_IN_MILLIS;
} else if (duration < DAY_IN_MILLIS) {
count = (int)(duration / HOUR_IN_MILLIS);
- result = String.format(getContext().getResources().getQuantityString(past
- ? com.android.internal.R.plurals.duration_hours_shortest
- : com.android.internal.R.plurals.duration_hours_shortest_future,
- count),
- count);
+ result = getContext().getResources().getString(past
+ ? com.android.internal.R.string.duration_hours_shortest
+ : com.android.internal.R.string.duration_hours_shortest_future,
+ count);
millisIncrease = HOUR_IN_MILLIS;
} else if (duration < YEAR_IN_MILLIS) {
// In weird cases it can become 0 because of daylight savings
@@ -281,10 +282,9 @@ public class DateTimeView extends TextView {
LocalDateTime localNow = toLocalDateTime(now, zoneId);
count = Math.max(Math.abs(dayDistance(localDateTime, localNow)), 1);
- result = String.format(getContext().getResources().getQuantityString(past
- ? com.android.internal.R.plurals.duration_days_shortest
- : com.android.internal.R.plurals.duration_days_shortest_future,
- count),
+ result = getContext().getResources().getString(past
+ ? com.android.internal.R.string.duration_days_shortest
+ : com.android.internal.R.string.duration_days_shortest_future,
count);
if (past || count != 1) {
mUpdateTimeMillis = computeNextMidnight(localNow, zoneId);
@@ -295,10 +295,9 @@ public class DateTimeView extends TextView {
} else {
count = (int)(duration / YEAR_IN_MILLIS);
- result = String.format(getContext().getResources().getQuantityString(past
- ? com.android.internal.R.plurals.duration_years_shortest
- : com.android.internal.R.plurals.duration_years_shortest_future,
- count),
+ result = getContext().getResources().getString(past
+ ? com.android.internal.R.string.duration_years_shortest
+ : com.android.internal.R.string.duration_years_shortest_future,
count);
millisIncrease = YEAR_IN_MILLIS;
}
@@ -363,26 +362,25 @@ public class DateTimeView extends TextView {
int count;
boolean past = (now >= mTimeMillis);
String result;
+ Map<String, Object> arguments = new HashMap<>();
if (duration < MINUTE_IN_MILLIS) {
result = mNowText;
} else if (duration < HOUR_IN_MILLIS) {
count = (int)(duration / MINUTE_IN_MILLIS);
- result = String.format(getContext().getResources().getQuantityString(past
- ? com.android.internal.
- R.plurals.duration_minutes_relative
- : com.android.internal.
- R.plurals.duration_minutes_relative_future,
- count),
- count);
+ arguments.put("count", count);
+ result = PluralsMessageFormatter.format(
+ getContext().getResources(),
+ arguments,
+ past ? R.string.duration_minutes_relative
+ : R.string.duration_minutes_relative_future);
} else if (duration < DAY_IN_MILLIS) {
count = (int)(duration / HOUR_IN_MILLIS);
- result = String.format(getContext().getResources().getQuantityString(past
- ? com.android.internal.
- R.plurals.duration_hours_relative
- : com.android.internal.
- R.plurals.duration_hours_relative_future,
- count),
- count);
+ arguments.put("count", count);
+ result = PluralsMessageFormatter.format(
+ getContext().getResources(),
+ arguments,
+ past ? R.string.duration_hours_relative
+ : R.string.duration_hours_relative_future);
} else if (duration < YEAR_IN_MILLIS) {
// In weird cases it can become 0 because of daylight savings
LocalDateTime localDateTime = mLocalTime;
@@ -390,23 +388,20 @@ public class DateTimeView extends TextView {
LocalDateTime localNow = toLocalDateTime(now, zoneId);
count = Math.max(Math.abs(dayDistance(localDateTime, localNow)), 1);
- result = String.format(getContext().getResources().getQuantityString(past
- ? com.android.internal.
- R.plurals.duration_days_relative
- : com.android.internal.
- R.plurals.duration_days_relative_future,
- count),
- count);
-
+ arguments.put("count", count);
+ result = PluralsMessageFormatter.format(
+ getContext().getResources(),
+ arguments,
+ past ? R.string.duration_days_relative
+ : R.string.duration_days_relative_future);
} else {
count = (int)(duration / YEAR_IN_MILLIS);
- result = String.format(getContext().getResources().getQuantityString(past
- ? com.android.internal.
- R.plurals.duration_years_relative
- : com.android.internal.
- R.plurals.duration_years_relative_future,
- count),
- count);
+ arguments.put("count", count);
+ result = PluralsMessageFormatter.format(
+ getContext().getResources(),
+ arguments,
+ past ? R.string.duration_years_relative
+ : R.string.duration_years_relative_future);
}
info.setText(result);
}