summaryrefslogtreecommitdiff
path: root/core/java/android/window/TaskOrganizerTaskEmbedder.java
diff options
context:
space:
mode:
authorHongwei Wang <hwwang@google.com>2020-07-31 11:36:13 -0700
committerHongwei Wang <hwwang@google.com>2020-09-02 18:13:48 +0000
commitf820ea88adae263b8ff23f8ee76f10fd3c8eba49 (patch)
tree14b2c8773e9a559b5d49ce7b02a5b66825a03061 /core/java/android/window/TaskOrganizerTaskEmbedder.java
parent9de9f13ef26dd1f0305040493a396c5a54a8f600 (diff)
Make WindowOrganizer and TaskOrganizer non-static
This is to allow unit test against TaskOrganizer, WindowOrganizer for interations between Shell and WM core. To test on WM side ``` when(mWindowOrganizer.getWindowOrganizerController()) .thenReturn(mockedWindowOrganizerController); when(mockedWindowOrganizerController.getTaskOrganizerController()) .thenReturn(mockedTaskOrganizerController) doSomeTest(); verify(mockedWindowOrganizerController).somethingHappended(); verify(mockedTaskOrganizerController).somethingHappended(); ``` To test on Shell side ``` ShellTaskOrganizer organizer = new ShellTaskOrganizer( mockedTaskOrganizerController) doSomeTest() verify(mockedTaskOrganizerController).somethingHappended(); ``` Removed also - Singleton pattern in TaskOrganizer and DisplayAreaOrganizer as it's redundant to what's in WindowOrganizer - static getController methods in both TaskOrganizer and DisplayAreaOrganizer as we prefer non-static for testability - static methods in TaskOrganizer in general - static methods in WindowManagerProxy in general Bug: 161711455 Bug: 149338177 Test: make sure everything still works Test: atest WmTests:WindowOrganizerTests \ WmTests:DisplayAreaOrganizerTest Change-Id: I978d20c7b87e73d0f6d22f7ab08188e4d12d745c
Diffstat (limited to 'core/java/android/window/TaskOrganizerTaskEmbedder.java')
-rw-r--r--core/java/android/window/TaskOrganizerTaskEmbedder.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/core/java/android/window/TaskOrganizerTaskEmbedder.java b/core/java/android/window/TaskOrganizerTaskEmbedder.java
index eb9dfed7f644..1e293df38cf8 100644
--- a/core/java/android/window/TaskOrganizerTaskEmbedder.java
+++ b/core/java/android/window/TaskOrganizerTaskEmbedder.java
@@ -109,7 +109,7 @@ public class TaskOrganizerTaskEmbedder extends TaskEmbedder {
}
WindowContainerTransaction wct = new WindowContainerTransaction();
wct.setHidden(mTaskToken, false /* hidden */);
- WindowOrganizer.applyTransaction(wct);
+ mTaskOrganizer.applyTransaction(wct);
// TODO(b/151449487): Only call callback once we enable synchronization
if (mListener != null) {
mListener.onTaskVisibilityChanged(getTaskId(), true);
@@ -133,7 +133,7 @@ public class TaskOrganizerTaskEmbedder extends TaskEmbedder {
}
WindowContainerTransaction wct = new WindowContainerTransaction();
wct.setHidden(mTaskToken, true /* hidden */);
- WindowOrganizer.applyTransaction(wct);
+ mTaskOrganizer.applyTransaction(wct);
// TODO(b/151449487): Only call callback once we enable synchronization
if (mListener != null) {
mListener.onTaskVisibilityChanged(getTaskId(), false);
@@ -165,7 +165,7 @@ public class TaskOrganizerTaskEmbedder extends TaskEmbedder {
WindowContainerTransaction wct = new WindowContainerTransaction();
wct.setBounds(mTaskToken, screenBounds);
// TODO(b/151449487): Enable synchronization
- WindowOrganizer.applyTransaction(wct);
+ mTaskOrganizer.applyTransaction(wct);
}
/**