summaryrefslogtreecommitdiff
path: root/core/java/android
diff options
context:
space:
mode:
authornharold <nharold@google.com>2017-10-05 00:44:37 +0000
committerandroid-build-merger <android-build-merger@google.com>2017-10-05 00:44:37 +0000
commit0bdb9a6e003a83abc804c70f2c29714ec586cfe2 (patch)
tree8c7259d2feb352d4fe36d460a1825e086b5b83ce /core/java/android
parentae61e0c6e82c187c8fabf5a40c0bffa8f1923215 (diff)
parent5ade9a228d6ee174230706894be0149eea32abbf (diff)
Merge "Cosmetic Cleanups for IpSecService"
am: 5ade9a228d Change-Id: If47968dbd55f8f38f9e8dda4d78a0e2e41827da8
Diffstat (limited to 'core/java/android')
-rw-r--r--core/java/android/net/IpSecConfig.java3
-rw-r--r--core/java/android/net/IpSecTransform.java2
2 files changed, 2 insertions, 3 deletions
diff --git a/core/java/android/net/IpSecConfig.java b/core/java/android/net/IpSecConfig.java
index ceccc07c3c43..632b7fc07f0c 100644
--- a/core/java/android/net/IpSecConfig.java
+++ b/core/java/android/net/IpSecConfig.java
@@ -34,7 +34,7 @@ public final class IpSecConfig implements Parcelable {
// Preventing this from being null simplifies Java->Native binder
private String mRemoteAddress = "";
- // The underlying network interface that represents the "gateway" Network
+ // The underlying Network that represents the "gateway" Network
// for outbound packets. It may also be used to select packets.
private Network mNetwork;
@@ -273,6 +273,7 @@ public final class IpSecConfig implements Parcelable {
};
@VisibleForTesting
+ /** Equals method used for testing */
public static boolean equals(IpSecConfig lhs, IpSecConfig rhs) {
if (lhs == null || rhs == null) return (lhs == rhs);
return (lhs.mMode == rhs.mMode
diff --git a/core/java/android/net/IpSecTransform.java b/core/java/android/net/IpSecTransform.java
index 529cf1a4956e..e15a2c672c20 100644
--- a/core/java/android/net/IpSecTransform.java
+++ b/core/java/android/net/IpSecTransform.java
@@ -409,8 +409,6 @@ public final class IpSecTransform implements AutoCloseable {
public IpSecTransform buildTransportModeTransform(InetAddress remoteAddress)
throws IpSecManager.ResourceUnavailableException,
IpSecManager.SpiUnavailableException, IOException {
- //FIXME: argument validation here
- //throw new IllegalArgumentException("Natt Keepalive requires UDP Encapsulation");
mConfig.setMode(MODE_TRANSPORT);
mConfig.setRemoteAddress(remoteAddress.getHostAddress());
return new IpSecTransform(mContext, mConfig).activate();