diff options
| author | Romain Guy <romainguy@google.com> | 2011-01-18 20:27:22 -0800 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2011-01-18 20:27:22 -0800 |
| commit | 3cd030a4fe229155b252cee003c78e2467ff4d82 (patch) | |
| tree | 9fbc9bae2110c0706ccd684fda68e29829c5d25a /core/java/android | |
| parent | f38bddbeb42988c7960e20585aeee9ae64f4b985 (diff) | |
| parent | 7890fe2da4719bf72b4fbcbef20a555d5fbd94bb (diff) | |
Merge "Don't pass a null View to OnListItemClickListener. Bug #3365153" into honeycomb
Diffstat (limited to 'core/java/android')
| -rw-r--r-- | core/java/android/widget/AbsListView.java | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/core/java/android/widget/AbsListView.java b/core/java/android/widget/AbsListView.java index d8f597207dac..5ef358bc3314 100644 --- a/core/java/android/widget/AbsListView.java +++ b/core/java/android/widget/AbsListView.java @@ -2439,8 +2439,12 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te if (adapter != null && mItemCount > 0 && motionPosition != INVALID_POSITION && motionPosition < adapter.getCount() && sameWindow()) { - performItemClick(getChildAt(motionPosition - mFirstPosition), motionPosition, - adapter.getItemId(motionPosition)); + final View view = getChildAt(motionPosition - mFirstPosition); + // If there is no view, something bad happened (the view scrolled off the + // screen, etc.) and we should cancel the click + if (view != null) { + performItemClick(view, motionPosition, adapter.getItemId(motionPosition)); + } } } } |
