diff options
| author | android-build-team Robot <android-build-team-robot@google.com> | 2018-06-07 07:20:41 +0000 |
|---|---|---|
| committer | android-build-team Robot <android-build-team-robot@google.com> | 2018-06-07 07:20:41 +0000 |
| commit | 7fee5aa93c232f3ba7c6364bbd8dba8f026a5c64 (patch) | |
| tree | 5212ef9959a8e9c07c1b54258cd375ad4349a6a9 /core/java/android | |
| parent | e43aa62c982350bd3954a5fc8b9c42bc08b03df0 (diff) | |
| parent | a76360ddf1f709d71ac9efe55739f071ce843ca5 (diff) | |
Snap for 4826885 from a76360ddf1f709d71ac9efe55739f071ce843ca5 to pi-release
Change-Id: I38823c8a96dd5a25943a4218ae1c254a2f7feb46
Diffstat (limited to 'core/java/android')
| -rw-r--r-- | core/java/android/app/Notification.java | 22 | ||||
| -rw-r--r-- | core/java/android/content/Intent.java | 1 | ||||
| -rw-r--r-- | core/java/android/widget/DateTimeView.java | 6 | ||||
| -rw-r--r-- | core/java/android/widget/Editor.java | 7 |
4 files changed, 15 insertions, 21 deletions
diff --git a/core/java/android/app/Notification.java b/core/java/android/app/Notification.java index 8d56c3ecec15..1ea93a419113 100644 --- a/core/java/android/app/Notification.java +++ b/core/java/android/app/Notification.java @@ -2676,7 +2676,8 @@ public class Notification implements Parcelable return true; } for (int i = 0; i < firstAs.length; i++) { - if (!Objects.equals(firstAs[i].title, secondAs[i].title)) { + if (!Objects.equals(String.valueOf(firstAs[i].title), + String.valueOf(secondAs[i].title))) { return true; } RemoteInput[] firstRs = firstAs[i].getRemoteInputs(); @@ -2691,25 +2692,10 @@ public class Notification implements Parcelable return true; } for (int j = 0; j < firstRs.length; j++) { - if (!Objects.equals(firstRs[j].getLabel(), secondRs[j].getLabel())) { + if (!Objects.equals(String.valueOf(firstRs[j].getLabel()), + String.valueOf(secondRs[j].getLabel()))) { return true; } - CharSequence[] firstCs = firstRs[j].getChoices(); - CharSequence[] secondCs = secondRs[j].getChoices(); - if (firstCs == null) { - firstCs = new CharSequence[0]; - } - if (secondCs == null) { - secondCs = new CharSequence[0]; - } - if (firstCs.length != secondCs.length) { - return true; - } - for (int k = 0; k < firstCs.length; k++) { - if (!Objects.equals(firstCs[k], secondCs[k])) { - return true; - } - } } } } diff --git a/core/java/android/content/Intent.java b/core/java/android/content/Intent.java index 1bc3bc9732eb..3dfabdd74a86 100644 --- a/core/java/android/content/Intent.java +++ b/core/java/android/content/Intent.java @@ -6994,6 +6994,7 @@ public class Intent implements Parcelable, Cloneable { "<INTENT> specifications include these flags and arguments:", " [-a <ACTION>] [-d <DATA_URI>] [-t <MIME_TYPE>]", " [-c <CATEGORY> [-c <CATEGORY>] ...]", + " [-n <COMPONENT_NAME>]", " [-e|--es <EXTRA_KEY> <EXTRA_STRING_VALUE> ...]", " [--esn <EXTRA_KEY> ...]", " [--ez <EXTRA_KEY> <EXTRA_BOOLEAN_VALUE> ...]", diff --git a/core/java/android/widget/DateTimeView.java b/core/java/android/widget/DateTimeView.java index a22f345bb2fc..621a745053eb 100644 --- a/core/java/android/widget/DateTimeView.java +++ b/core/java/android/widget/DateTimeView.java @@ -450,8 +450,10 @@ public class DateTimeView extends TextView { public void removeView(DateTimeView v) { synchronized (mAttachedViews) { - mAttachedViews.remove(v); - if (mAttachedViews.isEmpty()) { + final boolean removed = mAttachedViews.remove(v); + // Only unregister once when we remove the last view in the list otherwise we risk + // trying to unregister a receiver that is no longer registered. + if (removed && mAttachedViews.isEmpty()) { unregister(getApplicationContextIfAvailable(v.getContext())); } } diff --git a/core/java/android/widget/Editor.java b/core/java/android/widget/Editor.java index 10de4497c05c..d07721a3c27a 100644 --- a/core/java/android/widget/Editor.java +++ b/core/java/android/widget/Editor.java @@ -1688,6 +1688,11 @@ public class Editor { if (ims == null) { return false; } + final boolean wasContentChanged = ims.mContentChanged; + if (!wasContentChanged && !ims.mSelectionModeChanged) { + return false; + } + ims.mContentChanged = false; ims.mSelectionModeChanged = false; final ExtractedTextRequest req = ims.mExtractedTextRequest; if (req == null) { @@ -1703,7 +1708,7 @@ public class Editor { + " end=" + ims.mChangedEnd + " delta=" + ims.mChangedDelta); } - if (ims.mChangedStart < 0 && !ims.mContentChanged) { + if (ims.mChangedStart < 0 && !wasContentChanged) { ims.mChangedStart = EXTRACT_NOTHING; } if (extractTextInternal(req, ims.mChangedStart, ims.mChangedEnd, |
