diff options
| author | Yohei Yukawa <yukawa@google.com> | 2018-09-22 13:13:10 -0700 |
|---|---|---|
| committer | Yohei Yukawa <yukawa@google.com> | 2018-09-22 13:13:10 -0700 |
| commit | e2fa39ec3d7c690e04d8debb3e3988d96ed2cf20 (patch) | |
| tree | 422a15168a386a31c1d5a2a2f049b11bc3e06c2c /core/java/android | |
| parent | 21ba5d4f3f75365dd3251da6da0a8aa0c9ca0423 (diff) | |
Use PooledLambda.obtainMessage() when possible
As its JavaDoc says, in most of cases PooledLambda.obtainMessage() is
a better choice than PooledLambda.obtainRunnable().
If PooledLambda.obtainRunnable() is really necessary, let's make sure
to call recycleOnUse() whenever possible.
Test: presubmit
Change-Id: I3dbe500f49c0df187f2ffefd11c71836696dfd4e
Diffstat (limited to 'core/java/android')
| -rw-r--r-- | core/java/android/app/ActivityThread.java | 2 | ||||
| -rw-r--r-- | core/java/android/app/UiAutomation.java | 5 |
2 files changed, 3 insertions, 4 deletions
diff --git a/core/java/android/app/ActivityThread.java b/core/java/android/app/ActivityThread.java index 31e9a2d5daaf..6754df9ac6fd 100644 --- a/core/java/android/app/ActivityThread.java +++ b/core/java/android/app/ActivityThread.java @@ -1541,7 +1541,7 @@ public final class ActivityThread extends ClientTransactionHandler { public void scheduleTrimMemory(int level) { final Runnable r = PooledLambda.obtainRunnable(ActivityThread::handleTrimMemory, - ActivityThread.this, level); + ActivityThread.this, level).recycleOnUse(); // Schedule trimming memory after drawing the frame to minimize jank-risk. Choreographer choreographer = Choreographer.getMainThreadInstance(); if (choreographer != null) { diff --git a/core/java/android/app/UiAutomation.java b/core/java/android/app/UiAutomation.java index c0903b65737c..5a25f5aed161 100644 --- a/core/java/android/app/UiAutomation.java +++ b/core/java/android/app/UiAutomation.java @@ -1197,10 +1197,9 @@ public final class UiAutomation { } if (listener != null) { // Calling out only without a lock held. - mLocalCallbackHandler.post(PooledLambda.obtainRunnable( + mLocalCallbackHandler.sendMessage(PooledLambda.obtainMessage( OnAccessibilityEventListener::onAccessibilityEvent, - listener, AccessibilityEvent.obtain(event)) - .recycleOnUse()); + listener, AccessibilityEvent.obtain(event))); } } |