diff options
| author | TreeHugger Robot <treehugger-gerrit@google.com> | 2019-05-14 17:56:10 +0000 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2019-05-14 17:56:10 +0000 |
| commit | 6eb7f58ea7416e80dfe98920eb6610193e75ef50 (patch) | |
| tree | f9a2d498e6e93b4cafa5c7174c4d869322621317 /core/java | |
| parent | c3bfdf5267958a1c792e958f5e2d3f8306f28776 (diff) | |
| parent | a0e313a88917ce428924cc5deb5f573e69bef07f (diff) | |
Merge "Report request failure when binder died in remote service." into qt-dev
Diffstat (limited to 'core/java')
| -rw-r--r-- | core/java/com/android/internal/infra/AbstractRemoteService.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/core/java/com/android/internal/infra/AbstractRemoteService.java b/core/java/com/android/internal/infra/AbstractRemoteService.java index 64f885770336..3900f1674c13 100644 --- a/core/java/com/android/internal/infra/AbstractRemoteService.java +++ b/core/java/com/android/internal/infra/AbstractRemoteService.java @@ -231,6 +231,7 @@ public abstract class AbstractRemoteService<S extends AbstractRemoteService<S, I @SuppressWarnings("unchecked") // TODO(b/117779333): fix this warning final S castService = (S) this; mVultureCallback.onServiceDied(castService); + handleBindFailure(); } // Note: we are dumping without a lock held so this is a bit racy but @@ -406,7 +407,8 @@ public abstract class AbstractRemoteService<S extends AbstractRemoteService<S, I @NonNull BasePendingRequest<S, I> pendingRequest); /** - * Called if {@link Context#bindServiceAsUser} returns {@code false}. + * Called if {@link Context#bindServiceAsUser} returns {@code false}, or + * if {@link DeathRecipient#binderDied()} is called. */ abstract void handleBindFailure(); @@ -431,8 +433,6 @@ public abstract class AbstractRemoteService<S extends AbstractRemoteService<S, I mBinding = false; if (!mServiceDied) { - // TODO(b/126266412): merge these 2 calls? - handleBindFailure(); handleBinderDied(); } } |
