summaryrefslogtreecommitdiff
path: root/core/java
diff options
context:
space:
mode:
authorMisha Wagner <mishaw@google.com>2018-11-07 12:38:07 +0000
committerMisha Wagner <mishaw@google.com>2018-11-07 12:42:13 +0000
commitcf7a07d0f40612e7de5a7f0902e1060c92dfa28a (patch)
tree804104b59056072933e70cfcbe31c401044d5853 /core/java
parentc6c856912b69d6db00ec026f9fe2b38b1cfcc715 (diff)
Reduce amount of logging on failed proc file reading
We expect some proc file reading to fail when processes or threads finish execution while we traverse their proc files. We should not pollute logs when this traversal fails. Test: Inspected `adb logcat` Change-Id: Id811a1e6b5084a8a3a903a892a99e317d1e3ac7f
Diffstat (limited to 'core/java')
-rw-r--r--core/java/com/android/internal/os/KernelCpuThreadReader.java2
-rw-r--r--core/java/com/android/internal/os/ProcStatsUtil.java6
2 files changed, 6 insertions, 2 deletions
diff --git a/core/java/com/android/internal/os/KernelCpuThreadReader.java b/core/java/com/android/internal/os/KernelCpuThreadReader.java
index 6b277a0bd512..7c82a7eb97c4 100644
--- a/core/java/com/android/internal/os/KernelCpuThreadReader.java
+++ b/core/java/com/android/internal/os/KernelCpuThreadReader.java
@@ -173,7 +173,7 @@ public class KernelCpuThreadReader {
}
}
} catch (IOException e) {
- Slog.w(TAG, "Failed to iterate over thread paths", e);
+ // Expected when a process finishes
return null;
}
diff --git a/core/java/com/android/internal/os/ProcStatsUtil.java b/core/java/com/android/internal/os/ProcStatsUtil.java
index 3d4df890852e..0002447fda2a 100644
--- a/core/java/com/android/internal/os/ProcStatsUtil.java
+++ b/core/java/com/android/internal/os/ProcStatsUtil.java
@@ -32,6 +32,8 @@ import java.io.IOException;
@VisibleForTesting(visibility = VisibleForTesting.Visibility.PROTECTED)
public final class ProcStatsUtil {
+ private static final boolean DEBUG = false;
+
private static final String TAG = "ProcStatsUtil";
/**
@@ -141,7 +143,9 @@ public final class ProcStatsUtil {
}
return byteStream.toString();
} catch (IOException e) {
- Slog.w(TAG, "Failed to open proc file", e);
+ if (DEBUG) {
+ Slog.d(TAG, "Failed to open proc file", e);
+ }
return null;
} finally {
StrictMode.setThreadPolicy(savedPolicy);