summaryrefslogtreecommitdiff
path: root/core/java/android/transition
Commit message (Collapse)AuthorAgeFilesLines
* resolve merge conflicts of 358f0d4fc8c248498cf113c41e043877a14e89a1 to masterJeff Sharkey2020-12-081-0/+6
|\ | | | | | | | | | | | | Bug: 174932174 Test: I solemnly swear I tested this conflict resolution. Exempt-From-Owner-Approval: refactoring with team leads buy-in Change-Id: I9262a08ffc1ccede8e519d0eed90ed2bfcf0232c
| * Improve OWNERS coverage across frameworks/base/.Jeff Sharkey2020-12-081-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As general background, OWNERS files expedite code reviews by helping code authors quickly find relevant reviewers, and they also ensure that stakeholders are involved in code changes in their areas. Some teams under frameworks/base/ have been using OWNERS files successfully for many years, and we're ready to expand them to cover more areas. Here's the historical coverage statistics for the last two years of changes before these new OWNERS changes land: -- 56% of changes are fully covered by OWNERS -- 17% of changes are partially covered by OWNERS -- 25% of changes have no OWNERS coverage Working closely with team leads, we've now identified clear OWNERS on a per-package basis, and we're using "include" directives whenever possible to to simplify future maintenance. With this extensive effort, we've now improved our coverage as follows: -- 98% of changes are fully covered by OWNERS -- 1% of changes are partially covered by OWNERS -- 1% of changes have no OWNERS coverage This specific change is automatically generated by a script from detailed ownership information confirmed by team leads. Bug: 174932174 Test: manual Exempt-From-Owner-Approval: refactoring with team leads buy-in Merged-In: I9789c97c1de8e5d962b48c29c57d82fe83729eba Change-Id: I9789c97c1de8e5d962b48c29c57d82fe83729eba
| * Add maxTargetSdk restriction to unused APIs.Mathew Inwood2020-11-042-4/+6
| | | | | | | | | | | | | | | | | | | | | | These are APIs that have @UnsupportedAppUsage but for which we don't have any evidence of them currently being used, so should be safe to remove from the unsupported list. Bug: 170729553 Test: Treehugger Merged-In: I626caf7c1fe46c5ab1f39c2895b42a34319f771a Change-Id: I54e5ecd11e76ca1de3c5893e3a98b0108e735413
| * Use new UnsupportedAppUsage annotation.Artur Satayev2020-01-094-4/+4
| | | | | | | | | | | | | | | | | | Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library. Bug: 145132366 Test: m && diff unsupportedappusage_index.csv Change-Id: I288969b0c22fa3a63bc2e71bb5009fe4a927e154 Merged-In: I288969b0c22fa3a63bc2e71bb5009fe4a927e154
* | Add maxTargetSdk restriction to unused APIs.Mathew Inwood2020-10-292-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are APIs that have @UnsupportedAppUsage but for which we don't have any evidence of them currently being used, so should be safe to remove from the unsupported list. This is a resubmit of ag/12929664 with some APIs excluded that caused test failures; see bugs 171886397, 171888296, 171864568. APIs excluded: Landroid/bluetooth/le/ScanRecord;->parseFromBytes([B)Landroid/bluetooth/le/ScanRecord; Landroid/os/Process;->myPpid()I Landroid/os/SharedMemory;->getFd()I Landroid/hardware/input/InputManager;->INJECT_INPUT_EVENT_MODE_WAIT_FOR_FINISH:I Bug: 170729553 Test: Treehugger Change-Id: I8285daa8530260251ecad6f3f38f98e263629ca7
* | Revert "Add maxTargetSdk restriction to unused APIs."Hongwei Wang2020-10-282-6/+4
| | | | | | | | | | | | | | | | | | This reverts commit 72f07d6a8a32db4a0dedd7682a0b3385be2b9cd6. Reason for revert: Droidcop-triggered revert due to breakage https://android-build.googleplex.com/builds/quarterdeck?testMethod=testAppZygotePreload&testClass=android.app.cts.ServiceTest&atpConfigName=suite%2Ftest-mapping-presubmit-retry_cloud-tf&testModule=CtsAppTestCases&fkbb=6936597&lkbb=6936969&lkgb=6936551&testResults=true&branch=git_master&target=cf_x86_phone-userdebug>, bug b/171886397 Bug: 171886397 Change-Id: Ibe0f0430a3451477c1ee8ef56a596e91ea1e7672
* | Add maxTargetSdk restriction to unused APIs.Mathew Inwood2020-10-272-4/+6
| | | | | | | | | | | | | | | | | | | | These are APIs that have @UnsupportedAppUsage but for which we don't have any evidence of them currently being used, so should be safe to remove from the unsupported list. Bug: 170729553 Test: Treehugger Change-Id: I4c8fd0006f950de9955242e93968fb0996ceb372
* | Add @Nullable annotation to the parameter of Object.equals() methods.Roman Kalukiewicz2020-10-152-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Those annotations could be inferred by some tools (like Kotlin), but the https://checkerframework.org/ doesn't check inherited annotations complaining about all equals() invocations that get nullable argument. The change was generated by running find . -name \*.java | xargs sed -i 's/public boolean equals(Object /public boolean equals(@Nullable Object /' in the frameworks/base directory and by automatically adding and formatting required imports if needed. No manual edits. Bug: 170883422 Test: Annotation change only. Should have not impact. Exempt-From-Owner-Approval: Mechanical change not specific to any component. Change-Id: I5eedb571c9d78862115dfdc5dae1cf2a35343580
* | Use new UnsupportedAppUsage annotation.Artur Satayev2020-01-074-4/+4
|/ | | | | | | | Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library. Bug: 145132366 Test: m && diff unsupportedappusage_index.csv Change-Id: I288969b0c22fa3a63bc2e71bb5009fe4a927e154
* Not to remove the same animator twiceyoshiki iguchi2019-04-151-9/+14
| | | | | | | | | | | | | | | | Transition.forceToEnd may be called during the execution of method itself. In that case, an item of the map was removed during the previous iteration and ArrayIndexOutOfBoundsException was raised. This CL updates the loop to iterate the copy of map instead of the original map instance, so we don't break the iteration and see exception anymore. Bug: 120675604 Test: Ran 'cts-tradefed run commandAndExit cts --module CtsWidgetTestCases --test android.widget.cts.ToolbarTest#testMenuOverflowSubmenu' 20 times and no failure was observed. Change-Id: Iaba2f74f29d6ed22f84d92e0d4ca106cdfca904c
* Change platform Scene.getCurrentScene parameter from View to ViewGroupAndrey Kulikov2018-12-171-10/+10
| | | | | | | | | API Review request to use ViewGroup here as Scene roots can only be ViewGroup Bug: 120504681 Test: none Change in AndroidX: aosp/841919 Change-Id: I6fb857bc68d2afca54fe7d366fe8490d03c947a9
* Made View.setLeftTopRightBottom() publicAndrey Kulikov2018-11-291-2/+3
| | | | | | | | | | | It will allow to call this method in AndroidX Transition without reflection. ChangeBounds#BOTTOM_RIGHT_ONLY_PROPERTY,POSITION_PROPERTY are restricted now as well as developers can just use setLeftTopRightBottom method instead (it was used as a performance optimization in third-party transitions backport) Bug: 117521189 Bug: 117521197 Bug: 117521053 Test: new test added for the method Change-Id: I0a29bc8cf0b3357e49f6be14270993a21a6dfeee
* Restrict unsupported API usage to Scene#mEnterAction/mExitAction/setCurrentSceneAndrey Kulikov2018-11-291-3/+4
| | | | | | | | | | | They were used via reflection in older versions of support transitions. Starting from 26.0.0 it is not in use and there is no need to allow this usages. Developers should update to the newer version of support libraries/androidx Bug: 117521462 Bug: 117521646 Test: none Change-Id: Ia1d5516a58c0deec68091d719065621fc588591b
* Merge "Make transitions Scene.getCurrentScene() public"TreeHugger Robot2018-11-011-5/+9
|\
| * Make transitions Scene.getCurrentScene() publicAndrey Kulikov2018-11-011-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I pretty sure the getter method Scene.getCurrentScene() should be promoted to be public. This method is the only option for developers to understand is the sceneRoot already in the scene they need. Otherwise they have to introduce their own states and sync it with all scene changes which is more error-prone. To make it simpler to developers we can just make the method public. As an example of usage: void displayMessages(List<Message> messages) { if (!messages.isEmpty()) { if (Scene.getCurrentScene(root) != messagesScene) { TransitionManager.go(messagesScene); MyAnalytics.trackDisplayMessages(); (... more initialization ... ) } messagesView.display(messages); } } Test: added a cts test for getCurrentScene Change in AndroidX: aosp/807055 Bug: 118720709 Change-Id: Ic90e3576a82b5ab9a88e38e396efd49875968011
* | Improve platform TransitionSet behaviorAndrey Kulikov2018-10-311-5/+11
|/ | | | | | | | | | | | | | | | | 1) Allow override values for a children of TransitionSet. For example for usages like this: TransitionSet set = new TransitionSet().setDuration(300); Fade fade = new Fade(); set.addTransition(fade); fade.setDuration(100); The result duration applied for fade transition is still 300. And it breaks all the flexibility of configuring sets. The reason of it is clone() method which will be executed in beginDelayedTransition. And as part of clone() implementation of TransitionSet the children will be re-added to the new cloned set and set's duration will be re-applied again. To fix it I changed how we add transitions into set in clone(). 2) Recently we had a bug about TransitionSet will crash during inflation if we provide duration for it via xml. I fixed similar issue for applying a path motion. Test: added new tests for both issues Change in AndroidX: aosp/803493 Bug: 64644617 Change-Id: If205845a83e29d49f8cced8a53d9f56a4ad740aa
* Merge "Reuse overlay view between two Visibility transitions"TreeHugger Robot2018-10-293-68/+107
|\
| * Reuse overlay view between two Visibility transitionsAndrey Kulikov2018-10-183-68/+107
| | | | | | | | | | | | | | | | | | | | Bug: 31362791 Instead of creating a new screenshot of the view every time previous visibility transition already did it or just added our startView to the overlay we can cache it and apply the animation to the same reused view. So the behaviour is the same(and expected) like in the case when no overlay is used. Test: test added in VisibilityTest Fix in AndroidX: aosp/772713 Change-Id: Iba4ab168722595eb19b9c681649a976462a5532b
* | Remove transition listener in MultiListener and FragmentTransitionAndrey Kulikov2018-10-221-0/+1
|/ | | | | | | | | | Found two places where we forgot to remove TransitionListener in onTransitionEnd. I think it is important to clear it as if you reuse a transition object it will be leaked together with some views Test: n/a Bug: 64643817 Fixes in AndroidX: aosp/793641, aosp/795753 Change-Id: Iae0a9945a4158776f1a75c806c1f29efc049f96b
* Fix crash in RecyclerView if it's view is animated by TransitionsAndrey Kulikov2018-10-151-4/+20
| | | | | | | | | | | | | | | | | When it is happening: a) Disappear Visibility transition is applied to the recyclerview(and it's children) b) Transition added the View to the ViewOverlay for an animation c) Transition is first paused before being canceled (for example when the new reversed transition wants to start after user click) d) In Visibility.onPause() we call suppressLayout(false) for RecyclerView e) RecyclerView starts layouting and tries to use our view, but it is currently added to the overlay f) So it crashes on attempt to call addView Fix: Detach a view from overlay in Visibility transition while it is paused. Attach it back in onTransitionResume if the view is still not used by someone else like RecyclerView. Bug: 33609996 Fix in AndroidX: I18d8327b338be442ec30b15fe53a99d1a2974888 Test: cts tests for Transitions Change-Id: I74f138617c8afbac9f6efa4ee9a1f4e961306c9e
* Merge "Fix ChangeImageTransform for drawables without intrinsic size"TreeHugger Robot2018-09-281-32/+13
|\
| * Fix ChangeImageTransform for drawables without intrinsic sizeAndrey Kulikov2018-09-281-32/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 68489306 If we use a drawable like ColorDrawable for an ImageView it has intrinsicWidth and intrinsicHeight == -1. 1) Simplified matrix calculation in ChangeImageTransform.captureValues. It makes no sense to return null as a matrix because later in createAnimator it will be considered as the identity matrix. For cases when drawableSize == -1 instead we can just use view.getImageMatrix() which would be the identity matrix. 2) There is an additional check in createAnimator() to start an empty animation if the drawable width or height is 0. But actually it worth to use it also for cases when width or height is -1, as if it goes into else branch matrix transformations will try to incorrectly change the bounds of the drawable to (0, 0, -1, -1). 3) And also actually there is a bug in createNullAnimator() method, we can't provide nulls as values for ObjectAnimator.ofObject, as later it will crash on PropertyValuesHolder.setObjectValues(Object... values) because of "values[0].getClass()". So I changed it to provide some nonnull values like Matrix.IDENTITY_MATRIX. It is not important what to provide here as NULL_MATRIX_EVALUATOR will not use the values anyway. 4) Also I found a bug in ImageView.animateTransform(). If we provide null matrix if will try to update the drawable bounds to the view size but will not take into account paddings(in the same way like configureBounds()). Test: Tested manually on the sample app from the bug and added new tests for both cases: with view bounds change and without it Change-Id: I0750de56f4a011e06b340ed342884b59896d92dc
* | Keep scene change code in framework transitions in sync with AndroidXAndrey Kulikov2018-09-281-11/+10
|/ | | | | | Bug: 65536124 Test: cts/TransitionManagerTest Change-Id: I976f07899c7d6ef68acbcc207ddb07ae5ac7f28f
* Call Scene's exit action when use TransitionManager.go() with null transitionAndrey Kulikov2018-09-271-5/+11
| | | | | | | | | Bug: 65536124 When we pass null for TransitionManager.go() there is a special logic where we forgot to call previousScene.exit(), only newscene.enter() is called. Test: added unit tests and tested manually Change-Id: Ibd4d5a2cc17bbfe4aaa586357446da28d4b355af
* Fix IntDef's usages in the platform TransitionsAndrey Kulikov2018-09-073-4/+6
| | | | | | | | | | | | Bug: 68490704 1) Add annotation in some places where it was missed: constructors of Fade and Slide 2) Add Fade.IN and Fade.OUT into a set of allowed values for Visibility.MODE IntDef. Without it Lint will false alarm on this line: new Fade().setMode(Fade.IN); It should be allowed as Fade.IN is just a proxy value for Visibility.MODE_IN. Test: n/a Change-Id: I56d8ba5f49b1cf8f6a61357f58ac76312e7cf037
* Add @UnsupportedAppUsage annotationsMathew Inwood2018-08-304-0/+15
| | | | | | | | | | | | | | | For all remaining unannotated code. This is an automatically generated CL. See go/UnsupportedAppUsage for more details. Exempted-From-Owner-Approval: Mechanical changes to the codebase which have been approved by Android API council and announced on android-eng@ Bug: 110868826 Test: m Change-Id: I67c8b71ea535ebffb10bf577948bd4ccb8ca069d
* Merge "Code reformatting for upcoming automated code changes." am: ↵Mathew Inwood2018-08-211-2/+3
|\ | | | | | | | | | | | | | | 3b2cd9244d am: 0c875607f0 am: 6b9e65bea3 Change-Id: I5ca0de51793f574d7dc54b16e5427673bc5950f9
| * Code reformatting for upcoming automated code changes.Mathew Inwood2018-08-171-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | Adding annotations to individual fields cannot be easily done when there are two fields defined in a single statement. Put each definition in a statement of its own. See go/UnsupportedAppUsage for more context. Bug: 110868826 Test: m Change-Id: I34e163d0984fcb666c1ea8788791f5a7740c8892
* | Fix broken links in @see tags in framework docs.Aurimas Liutikas2018-06-041-4/+2
| | | | | | | | | | | | | | | | | | | | doclava was accidentally suppressing all these broken links in @see tags. This CL fixes issues so we can start enfocing checks for broken @see links. Test: make docs Change-Id: If7830ece85f8d1f27c991eae282230814726e115 Exempt-From-Owner-Approval: Fixing @see javadoc link issues that are currently completely broken
* | Fix race condition with GC in TransitionManagerYuichi Araki2018-05-021-7/+9
| | | | | | | | | | Test: Built Change-Id: I605b32dc7f86b63ba6ce539fcd13174558feb125
* | Merge "Don't clear focus during transition animations" into pi-dev am: ↵Evan Rosky2018-05-011-32/+32
|\| | | | | | | | | | | | | | | 09ba7e0bae am: 13f13935ea Change-Id: Id5e4345720f6307c1809cc0e36a144f1ddf8365b
| * Don't clear focus during transition animationsEvan Rosky2018-04-231-32/+32
| | | | | | | | | | | | | | | | | | | | If a view is suppressing layout, it is probably part of a transition animation. In this case, we don't want to defocus a focused view which may eventually have a size. Bug: 78302781 Test: issue in bug is resolved. Transition CTS tests still pass Change-Id: I983f41bcd68056d2150d4db29c781b63a2c321c2
* | Transfer Interpolator from TransitionSet to child TransitionsGeorge Mount2018-03-161-3/+47
|/ | | | | | | | | | | | | Bug: 74831546 TransitionSet interpolator was never being used in child transitions. This transfers the interpolator by setting the interpolator of the children as they are added or when the interpolator is set. It also works for other settings: epicenter, path motion, and propagation. Test: Ie8ce23fe15e6193fdb2909606e442bd2912a4c5a Change-Id: Ia9e35639f025d14c6497fa30abf75252ff3b1423
* Switch to public API versionJohn Reck2018-02-121-15/+10
| | | | | | | | Use the public API version of the same thing that the private API access was doing. No behavior change. Test: built Change-Id: I4a9032cfb1d4e699f72df3b079ef363d308419e8
* Merge "Fix bug in calculating path in ArcMotion"TreeHugger Robot2018-02-081-2/+8
|\
| * Fix bug in calculating path in ArcMotionGeorge Mount2018-02-071-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 73077523 When the path is perfectly horizontal, ArcMotion was calculating a Path that had NaN values. This corrects that problem by special casing horizontal and vertical paths. Test: manual with app that discovered the problem Test: manual with test app Test: I30d51206194e3c68ea145d3a81e05a461c4e0ca8 Change-Id: Ic1a70b79290847726fc7994d1224fd77024e0610
* | Avoid improperly removing views during transitionsGeorge Mount2018-02-022-1/+9
|/ | | | | | | | | | | | | | | | | | | | | Bug: 65715616 There are two places where views were being removed improperly during transitions. The first was when making a copy of a view. Because of hardware bitmaps, views were being moved to the overlay so that the image could be copied. This CL moves the view back into its parent after copying the image. The second location is where the view was being considered an overlay. When a view is in the starting scene and the view in the end scene cannot be used, the starting scene view was being moved to the overlay. This is only valid when the view is alowed to be removed. Instead, a bitmap copy of the view is moved to the overlay. Test: manual testing Test: I0456d8a699525b08b044236c558b2d84b48c29a6 Change-Id: Ieb32b146cf65e3ff4ed6d7bb8325e74763dbd2d5
* Add more IntDef prefixes for auto-documenting.Jeff Sharkey2017-12-131-1/+4
| | | | | | | Test: builds, boots Bug: 70177949 Exempt-From-Owner-Approval: annotation-only changes Change-Id: I76dde6054e06f52240bd4b1a0f196dcb74623608
* Fix Transition test failure.George Mount2017-09-291-4/+14
| | | | | | | | | | | | Bug: 67049319 TransitionUtils was returning null when the View wasn't attached, but Visibility transitions can do that intentionally. This CL temporarily adds detached views to the view hierarchy as part of an overlay while creating the hardware bitmap representation. Test: ran transition CTS tests Change-Id: Ie335619953653dce0224514f0d5c9c8eb00ee1a9
* Merge "Associate RenderNodes created for hw bitmap w/ views" into oc-mr1-devDoris Liu2017-09-281-3/+3
|\
| * Associate RenderNodes created for hw bitmap w/ viewsDoris Liu2017-09-271-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In transition animations, in order to capture the content of a view or a drawable in a hw bitmap, a RenderNode needs to be created. The RenderNode was previously setup with no owning view. As a result, in cases where RenderNode animations are triggered by the draw calls in displaylist recording, these animations would fail for lack of a view to animate on. This CL ensures that when RenderNodes are created for the purpose of populating content in a hw bitmap in transitions, there's always a view associated with each RenderNode. BUG: 65160121 Test: Force to repro crash by changing press state during hw bitmap creation, which triggers a ripple animation that led to the otherwise timing dependent and hard to repro crash. Change-Id: I2b4ba95cad25a94d50b3904e775606f737e960e3
* | Fix crash when creating a HW Bitmap on a detached viewDoris Liu2017-09-251-1/+4
|/ | | | | | | BUG: 65160121 Test: Unable to repro the crash before or after the fix Change-Id: I84fa28557c67a6672b8d82443d4da7be4f28a50d
* Use hardware bitmap for shared element snapshots.George Mount2017-08-231-6/+17
| | | | | | | | | | | | | | | Bug: 64851247 Drawing to software bitmaps does not support many features, most especially hardware bitmaps. This changes the implementation to using hardware bitmaps for View snapshots. Also fixed broken TransitionTest discovered while testing. Test: I4ede02db67e578ea4a25069b683f1989c611e06c Change-Id: I185bbfe1f789055c9efdba5297a74e481607afaf
* Fix ChangeClipBounds to set final clip to null.George Mount2017-04-201-1/+14
| | | | | | | | | | | Bug 35227753 ChangeClipBounds wasn't setting the final clip to null after its transition if the end clip was supposed to be null. Test: I9089e0c84718d219cfda266a99fd3dffdbae8512 Change-Id: If928454b30807ccc6b34ed4dfbb14857d99d43be
* Ensure bounds are updated together.George Mount2017-04-071-8/+8
| | | | | | | | | | | Bug 37156683 The animator was setting the value twice on the first run, so the bounds was being set improperly as the top/left was being set from a different frame than the bottom/right. Test: I534cc4d7534cff1206ea8c2b222e0c0852fc0e9c Change-Id: I6fb047d2fa4d0ed0db3b44107f9815a65f1f2676
* Excluded Views don't go through Transition.George Mount2017-03-131-1/+3
| | | | | | | | | | | | | | | | Bug 35832096 When entering or exiting Views were excluded, they were still being set to INVISIBLE during the exit transition. This made them disappear instantly. Instead, I've reverted back to the original implementation by not affecting excluded Views during the transition. This CL walks the transition and removes excluded Views from the enter/exit from being affected. Test: I5b1b75dd12a3914e35c1d0fb641850981a19f9c3 Change-Id: I2b00ba95575420bae690b1cd8d4894c98401da79
* Recycle TypedArrays in Fade and TransitionInflaterYuichi Araki2017-02-102-0/+3
| | | | | Test: Builds Change-Id: I91e214eafc87850dca6986af2054e5edca46e724
* Merge "Fix doc for setReparentWithOverlay"Yuichi Araki2017-02-071-3/+4
|\
| * Fix doc for setReparentWithOverlayYuichi Araki2017-02-031-3/+4
| | | | | | | | | | Test: Doc fix only Change-Id: I8d89be7c87cf95fd2c7799fdd8286acc13102e46
* | Merge "Extract and unhide TransitionListenerAdapter"Ben Weiss2017-02-064-30/+63
|\ \ | |/ |/|
generated by cgit v1.2.3 (git 2.25.1) at 2026-01-11 16:57:48 +0000