summaryrefslogtreecommitdiff
path: root/core/java/android/webkit/SafeBrowsingResponse.java
Commit message (Collapse)AuthorAgeFilesLines
* WebView: deprecate accidentally-exposed constructorsNate Fischer2018-09-251-0/+6
| | | | | | | | | | | | | | This deprecates public-exposed constructors. These constructors were exposed by accident. These classes shouldn't be instantiated by applications, but should only be instantiated by WebView. In some cases, the app should get a singleton instance using a #getInstance method. In these cases, we document this explicitly in the deprecation note. Bug: 110807530 Test: make docs, manually verify docs look good. Change-Id: Ibe73b3399c9ced0cf4fbb01e1df13564476df252
* WebView: fix SafeBrowsingResponse javadoc bugNate Fischer2018-09-121-2/+2
| | | | | | | | | | | | | | | | | | | No change to logic, only minor javadoc change. This fixes javadoc in SafeBrowsingResponse.java. Previously, the first (and only) sentence did not end in a period (it ended with a quote character). The Android javadoc parser doesn't handle this well--it requires a period followed immediately by some whitespace character. This wasn't a big issue because this was the only sentence. However, if we ever add a second sentence, both sentences will appear as the one-line "synopsis doc" for the methods. See http://go/android-api-guidelines#heading=h.teqny5h9ohqc for details. Bug: 115441402 Test: make docs Change-Id: Ic363ed1ecf3d169d598ae85d55297d0a520a6604
* Merge "WebView: remove "</p>" tags from docs"Nate Fischer2017-09-141-1/+0
|\
| * WebView: remove "</p>" tags from docsNate Fischer2017-09-111-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Docs change only, no change to logic. This removes closing "</p>" tags from WebView API docs, as per API guidelines. This also adds a trailing newline to a <pre> block for consistency. Other than the modified <pre> block, this has no reader-visible change, it merely complies with best practices from Android API guidelines. Bug: 65381884 Test: make docs (and manually compare before/after for differences) Change-Id: I2f911a43b88a8897d9d1b5c7945360580491883d
* | WebView: wrap Java literals with {@code}Nate Fischer2017-09-051-3/+3
|/ | | | | | | | | | | | | | | | Docs change only. This wraps some Java literals (true, false, null) with {@code} blocks, as per Android API guidelines. This also addresses other presubmit errors: * fix lines that have become too long * fix broken import order and unused imports Bug: 65213517 Test: make docs (and manually verify things look better) Change-Id: Idc7fe28d40bea7bd1edcad539b75fa9c689b8d46
* WebView: add WebView#getSafeBrowsingPrivacyPolicyUrl() APINate Fischer2017-08-101-0/+5
| | | | | | | | | | | | This adds a dedicated API for fetching a URL for the Safe Browsing reporting privacy policy. This URL should be displayed by applications on custom Safe Browsing interstitials. Bug: 64077668 Test: make update-api (it compiles and javadocs look good) Change-Id: I2873260edcaa924e68517c8679079e147b9995f4
* WebView: fix SafeBrowsingResponse javadocsNate Fischer2017-08-081-3/+3
| | | | | | | | | | | | | | Docs change only. This fixes javadoc errors in SafeBrowsingResponse.java: * Typo: capital "B" in "onSafeBrowsingHit" * Add full package names * Add parameter lists to all linked methods Bug: 64077668 Test: make update-api and check javadocs manually Change-Id: I5e7b0e59ba865619b252f7e9e431ffac6e1bab1f
* Fix broken javadocs.Jeff Sharkey2017-08-061-1/+1
| | | | | | Bug: 64337634 Test: make -j32 doc-comment-check-docs Change-Id: I20fdd3dcddef09111d35946c41c596c7689effa6
* WebView: Fix SafeBrowsingResponse APINate Fischer2017-07-121-3/+3
| | | | | | | | | The methods were previously package-private by mistake. This fixes them to be public. Bug: 63615582, 62723291 Test: N/A Change-Id: Ie9095f861213a70fd655561f911385bdd06632b3
* Add SafeBrowsingResponse abstract classNate Fischer2017-07-111-0/+47
This adds a new class called SafeBrowsingResponse to replace the ValueCallback parameter for WebViewClient#onSafeBrowsingHit. This class contains specific methods for each of the available actions. This also removes the SAFE_BROWSING_ACTION_* constants from the WebViewClient class. Bug: 62723291 Test: N/A Change-Id: Ie4fe878ea470f7aea7a716ae9edb80b53b73e172