| Commit message (Collapse) | Author | Age | Files | Lines |
| |\
| |
| |
| |
| |
| |
| | |
https://android.googlesource.com/platform/frameworks/base into t13.0
Android 13.0.0 Release 52 (TQ3A.230605.012)
Change-Id: Ic80f318636f1f70bbd009504352ddde511d0dead
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Including new tokens for shades base color and ColorScheme updates
Test: atest ColorSchemeTest
Test: atest ThemeOverlayControllerTest
Test: atest SystemPaletteTest
Bug: 241778903
Change-Id: I45a398245ae45adbfe58d32e11a4d18097e3eca1
|
| |\|
| |
| |
| |
| |
| |
| |
| | |
https://android.googlesource.com/platform/frameworks/base into t13.0
Android 13.0.0 release 35
Change-Id: I709958b2f015d1774b2ece25894467c3a279f93c
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Definition of Monochromatic Theme and feature flag.
Test: atest ColorSchemeTest
Bug: 241778903
Change-Id: I3c729d9cb8f9eccb2e435849bd50a88513d99c0a
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chroma is capped to 40 for light colors of L* 90 and above for valid
reasons. However, assigning the capped value to "chroma" fails to
account for the fact that chroma is an argument passed to the method,
so the capping effect persists across iterations. This unintentionally
affects and limits the chroma of *all* shades because the first
iteration of the loop is L*=90.
As a result, almost all colors are less chromatic than the intended
chroma >= 48. Fix the issue by assigning capped chroma to a temporary
per-iteration variable.
Change-Id: I18102d0072c89535e27f23fdb98af7c83864ff7e
Signed-off-by: jhonboy121 <alfredmathew05@gmail.com>
|
| |
|
|
|
|
|
|
|
| |
Fixes an IndexOutOfBoundsException in stringForColor whenever the
value is between 0 and 15. Integer#toHexString does not zero pad.
Bug: 234413479
Test: atest ColorSchemeTest#testToString
Change-Id: I50f95ee8f2b1924bb1778b66ed39fa40685ef7e2
|
| |
|
|
|
|
| |
Test: atest ColorSchemeTest, atest SystemPaletteTest
Bug: 213314628
Change-Id: I9ac96a2343afa0fd56b3e9ae8e8073f4ff5c1480
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
ThemeOverlayController's is being used by designers for verification.
To make that easier, the dumpsys now includes HCT coordinates, hex codes
w/o alpha channel, and the seed color, which ColorScheme now stores in
an instance variable.
Test: adb shell dumpsys activity
service com.android.systemui/.SystemUIService ThemeOverlayController;
verify format works as intended. Shared with design, got feedback and
confirmation this includes all needed info.
Change-Id: I058d390b109a27e2277a2a74c1519c7b15a49400
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update a couple rotations to match spec (ex. rotation occurs at 151
degrees instead of 141)
- If hue rotation specs have an entry at 0 degrees, they also need an
entry at 360 degrees. There's no way to determine that, for example,
321 is between 315 and 0, 360 must be listed.
- Find hue rotation in a way that ensures ex. an angle isn't tested for
being between 0 and 360 degrees, as that will always return true.
Instead, use first element, (always 0 degrees), check if angle is
between and the next element, and stop once the next element is 360
degrees (always the last element in the array)
- Remove code that became unused after the above change.
Test: atest ColorSchemeTest (unit test); atest SystemPaletteTest (CTS).
Spent ~4 hours trying a variety of wallpapers, and seed colors, and
used dumpsys to verify results match UX spec. Create spreadsheet for UX
to fill out their spec, then another spreadsheet that contains the
dumpsys results for blue/red/yellow/green seed colors across all theme
variants, and the preset colors for Ice Cream and Fruit Salad variants.
Confirmed the runtime results, as reported by dumpsys, match the spec
in all cases.
Bug: 213314628
Change-Id: Id35faa294bf82c0e81c2690c65c42218a87c236a
|
| |
|
|
|
|
| |
Bug: 213314628
Test: Manual inspection at runtime
Change-Id: I0f703254ec434f9dac17df7738d704586752143f
|
| |
|
|
|
|
|
|
|
|
| |
The first number in a Pair instance, the hue range to check against,
was being used as the rotation value. The second number in the Pair
instance should have been used.
Bug: 213314628
Test: Manual inspection at runtime
Change-Id: I9002522853f8a6cc6d38537f14fed04e256aa340
|
| |
|
|
|
|
|
|
|
|
|
| |
Use content color scheme for media player, which dynamically adapts
color palette chromas to the source color, and permits monochrome source
colors. Use for media. This allows ex. grayscale album covers to get a
grayscale treatment in UI, per design requirement.
Bug: 213314628
Test: Manual inspection at runtime
Change-Id: Ib8ea007e34758cd7903b3432ab88af695cb22f68
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pairs with, and needed for, a CL that enables Widgets to use the user-selected theme variant.
Bug: 213314628
Test: visual inspection at runtime: use different wallpapers and
widgets in different locations, change to different theme variants,
observe changes and verify they're in line with expectations (ex.
if a widget is blue in the default theme variant, in the expressive
theme variant it rotates hue just like a blue theme color does in
expressive hue)
Change-Id: I288a4faeba06042037b468c8345414ef5547325c
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- hue range cutoffs are rounded (ex. 30 instead of 27)
- some changes to rotations
- vibrant theme uses the higher of the theme color's chroma or 48,
whichever is higher.
- custom chroma for exactly one hue in the expressive neutral palette
is removed, all hues use the same chroma, removing need for
ChromaExpressiveNeutral
Bug: 213314628
Test: atest ColorSchemeTest passes. Manual testing, ex. compare
colorfulness of vibrant theme buttons in wallpaper picker before and
after change
Change-Id: I0bbec4dc9edbaa9097ad72c9b32b708db6bd064e
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A) Refactor hue/chroma specification to support specification of
hue rotation and chroma depending on source color hue. Update vibrant &
expressive specs to use granular specification of hue rotations for
secondary and tertiary palettes for both, and expressive's neutral uses
specification of chroma for the neutral palette.
B) Use chroma equal to seed color for all palettes, replacing some
usage of >=
C) Remove chroma 40 cap at tone 90
Test: atest ColorSchemeTest
Bug: N/A
Change-Id: Ib9fff483443ccae888faf636d4388b9658ff3dfe
|
| |
|
|
|
|
|
|
| |
UX feedback, using new chroma values
Fixes: 219787214
Test: atest SystemPaletteTest
Change-Id: I4754d4ade1ad8f59adadf158c8803a5812b106b0
|
| |
|
|
|
|
| |
Bug: 202145221
Test: manual
Change-Id: Ibaf5cd421380c4c38e2688ebe60216613d973b8f
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new styles:
- spritz
- expressive
- vibrant
Are now correctly hooked up to the customization setting, allowing for
picker integration.
Bug: 195969565
Test: atest ThemeOverlayControllerTest
Test: adb shell settings put secure theme_customization_overlay_packages '''\{\"android.theme.customization.system_palette\":\"B1611C\",\"android.theme.customization.theme_style\":\"SPRITZ\"}'''
Change-Id: I106f05b7f0aade470b8216b47e14ca4aa6db0970
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add 5(!) lightweight classes for storing a design spec for a style.
- Add parameter to ColorScheme constructor for Style
- Add constructor replicating previous constructor for backwards
compatibility with existing code, uses Tonal Spot as tyle
- Reconfigure ColorScheme to use style to generate palettes
Test: atest ColorSchemeTest passes. Change default style to
style #1, make sure it works as intended, and matches what we've seen in
mocks. Continue through all 4 styles.
Bug: 213314628
Bug: 195969565
Change-Id: Iae2b4fc4ffd630bb4275f827798ae4643b230ae1
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
After adding 60 degrees to the hue, the result needs to be normalized to
0 to 360. Code downstream of Shades.of does not perform the
normalization, so the resulting color will be the result of undefined
behavior.
Test: `atest ColorSchemeTest`, newly added testTertiaryHueWrapsProperly
passes.
Bug: 204463343
Change-Id: I93168c98ba64fb865888469220571dc6d437105d
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We rank/score colors for suitability for theming choices, and the top
4 are presented to the user.
The score has two components: the chroma, or colorfulness, of the color,
and the hue population of the color — what percentage of the image has
hues within 15 degrees of the color.
A wallpaper that is mostly black, green leaves, and a light dash of low
chroma red on a couple leaves, ends up ranking red as the highest choice
because black has a red hue.
Ignoring low chroma colors when calculating the hue population avoids
this issue — the dash of low chroma reds no longer benefits from their
hue being close to black, the majority of the image.
Bug: 201980078
Test: Push wallpaper from bug comment #4 to device, check color options.
Red is no longer offered as an option. To come: apply to Monet Studio,
verify no ill effects
Change-Id: Ib40a6646077e07c2cc85da339186d9a307709def
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a set of wallpapers, namely some Landscape wallpapers, that
don’t have any colors extracted from them. The wallpaper visually has
some color to it, but, the chroma of those colors is low enough that
they get filtered out by the low chroma filter.
Lower the chroma filter from 15 to 5, and eliminate the tone filter
(previously, L >= 10). Scoring compensates for this by prioritizing
chromatic colors, thus ensuring these low-chroma options are only used
if there’s no better options.
Bug: b/200675148
Test: Push landscape wallpapers #912, #914, and #924 from Monet
Studio to device. Verify color choices reflect wallpaper and aren't just
fallback colors.
Change-Id: I080e6cb51978638462a8b0ab41340aa11d495c93
|
| |
|
|
|
|
| |
Bug: 199389755
Test: atest ColorSchemeTest
Change-Id: I4c2d76c9c92e96ca8259a4fc991e9e52b9e97ba9
|
| |
|
|
|
|
| |
Bug: 199389758
Test: atest ColorSchemeTest
Change-Id: I295ef3a6ad4d64c26ef150c853ec9875cf2ad8ff
|
|
|
Test: manual
Test: atest ColorSchemeTest
Test: atest SystemPalette
Fixes: 199401230
Change-Id: I0695257765335f12ad47d5d8f40d0885c652bff6
|