summaryrefslogtreecommitdiff
path: root/packages/SystemUI/src/com/android/systemui/flags/FeatureFlagsRelease.java
Commit message (Collapse)AuthorAgeFilesLines
* Only restart SystemUI when Server Flags actually change.Dave Mankoff2023-03-131-30/+84
| | | | | | | | | | | | DeviceConfig is alerting us to all server pushes (pulls?). Even if the flags is checking on aren't actually changing. This CL ensures we only restart if the flag value has actually changed. Fixes: 272780732 Test: atest SystemUITests Change-Id: I3571d210885472dc69f50c76922a89733f1a5d83
* Don't restart SystemUI in TestHarness mode.Dave Mankoff2023-02-091-2/+3
| | | | | | | | | | | Log the name of the flag that is causing restarts. Also, we weren't copying old overrriden-id's into the new overridden-names. Fix that. Fixes: 267753212 Test: atest SystemUITests and some manual flag flipping. Change-Id: I7df265a54e657453c664c3d77987ee498c1c97cd
* Step 1 of Removing Ids from Flags.Dave Mankoff2023-01-261-37/+53
| | | | | | | | | | | | With this change, we start relying more directly on the string names that are now associated with flags. The ids persist so that we can look up existing overrides and push them into the new system. After a couple of weeks, the plan will be to remove the ids entirely. Bug: 265188950 Test: manually built before and after cl to ensure overrides persist. Change-Id: I0faac671b43a0d24262e78ccdb4e23e44f73eeea
* Revert "Revert "Ensure SystemUI gets restarted lazily.""Dave Mankoff2022-12-061-1/+1
| | | | | | | | | | This reverts commit d4c3da1be348b14b355df23c156f4a5d47262fff. Reason for revert: Need to restore this functionality. Problem fixed. Bug: 257302229 Test: manual via the flag app Change-Id: Ieefc76bda09431ed2f7a0fe28d91a59ef02184b8
* Revert "Ensure SystemUI gets restarted lazily."Taran Singh2022-11-171-1/+1
| | | | | | | | | This reverts commit e0d2a5117d20b04cacf673cb72f34ab681679927. Reason for revert: LockscreenShiftSecurity#testSecurityShiftsWhenTappingOnTheOtherSide test is broken Bug: 259595527 Change-Id: I16bca337d77a9fa88a2d90881d7b6a34fca33b08
* Ensure SystemUI gets restarted lazily.Dave Mankoff2022-11-161-1/+1
| | | | | | | | | | A prior change broke restarting Android by replacing it with restarting SystemUI. Meanwhile, restarting SystemUI remained unchanged - restarting immediately. Bug: 257302229 Test: manual via the flag app. Change-Id: I4674cfd7c136b15a41ee36caea5b853e801d52fe
* Define server flag names for all existing flags.Dave Mankoff2022-11-091-4/+4
| | | | | | | | | Removes reflection from our flag infrastructure. Bug: 249121873 Fixes: 258235428 Test: manual Change-Id: I29bf2065ba5885789e3fe94c0d6cdbae5e42a4d0
* Add server flag support to flags.Dave Mankoff2022-11-091-13/+1
| | | | | | Bug: 249121873 Test: atest SystemUITests Change-Id: I7fe0bd122cbcc3365abe7f4071a76a04783ff3d0
* Enable Int and String flags.Dave Mankoff2022-11-031-0/+12
| | | | | | | | | | | | | Puts mechanics in to support IntFlag and ResourceIntFlag. Also adds support for both IntFlag and StringFlag via the command line. Support in the app will come later. Bug: 257066497 Test: manual via the command line. Change-Id: I378f0f1e0db028cee33f729c47a63262124389d7
* Restart SystemUI on DeviceConfig changes.Dave Mankoff2022-10-261-3/+27
| | | | | | Bug: 253062545 Test: atest SystemUITests Change-Id: I905b17a6b4ba639749d6d82d08cecc55bda422a7
* Use less SysUI specific code in Flags.Dave Mankoff2022-10-031-7/+4
| | | | | | | | A step along they way to sharing the flagging code as a library. Bug: 249121873 Test: atest SystemUITests Change-Id: Id48d33a6ce0d058c4b2d3c282865297841753bb7
* Add ability for flags to be server-overridden.Dave Mankoff2022-08-061-3/+13
| | | | | | | | | | | | | | | | | This works in both debug and release builds. In debug builds, all flags can be overridden via the same mechanisms as before, but can also be overridden by flags defined on the server. On release builds, only `ReleasedFlag`s can be overridden. `UnreleasedFlag`s remain set in their default state. With this cl, server side flags do not get their new value until SystemUI is restarted (via a reboot or a crash). Bug: 239863271 Test: atest SystemUITests Change-Id: I08166cb90675dea06b2671669cecfc16ac58ab61 Merged-In: I08166cb90675dea06b2671669cecfc16ac58ab61
* Add DeviceConfig feature flag type to SystemUINick Chameyev2022-06-101-0/+17
| | | | | | | | | | | | | Adds support of DeviceConfig feature flags. DeviceConfig flags are used by Phenotype A/B testing framework. Bug: 218314434 Test: change phenotype flag => check that FeatureFlags returns correct value Test: atest com.android.systemui.flags.FeatureFlagsDebugTest Test: atest com.android.systemui.flags.FeatureFlagsReleaseTest Change-Id: I7dd9e47280ba56b7f9ea552c0d44d3e36fc6b041
* Remove FileDescriptor from systemui.Dumpable.Dave Mankoff2022-04-051-2/+1
| | | | | | | | | | This is the first step in moving over to the new public android.util.Dumpable api. Bug: 217567642 Test: m SystemUI Merged-In: Ibaebcfb2c6c5326d0c45b8c72d868c76655d89a0 Change-Id: Ibaebcfb2c6c5326d0c45b8c72d868c76655d89a0
* Don't cache simple BooleanFlags.Dave Mankoff2022-03-021-5/+20
| | | | | | | | | Caching them doesn't offer any performance wins. It does prevent the compiler/proguard from inlining any function calls to them. Bug: 204319780 Test: manual Change-Id: I0057fd4b399731d6ac96ed0ad59c1be12ab3ca73
* Add support for SystemProperty flags to SysUI.Dave Mankoff2022-02-221-1/+18
| | | | | | | | | | | This will allow the flag flippin' app to change boolean system properties that launcher, settings, and system server can read. Some of these flags are already being read between the various systems and this gives a unified ux for changing the flags. Bug: 219067621 Test: manual Change-Id: I7d1a1e758915f43cac114054a2c2e055706ef3f3
* Generalize some flag manager methods by flag type.Jeff DeCew2021-12-081-7/+43
| | | | | | Bug: 209081785 Test: atest FeatureFlagsDebugTest FlagManagerTest Change-Id: Ie92667e33e7c086258cdd03e7b9ebccdefef5938
* FeatureFlags Listeners:Jeff DeCew2021-12-081-6/+4
| | | | | | | | | | * Convert FlagReader interface to FlagListenable. * Move Flag reading to FeatureFlags interface. * Remove isEnabled(id, boolean) from all interfaces; make private in implementations where used. Bug: 209081785 Test: atest FlagManagerTest Change-Id: I8c90a67def242b5d2fa55d5effab8270ecafabb4
* Better support for Resource based flags.Dave Mankoff2021-12-021-6/+20
| | | | | | | | | | | | | | | | | | | | | | | | | Introduce ResourceFlag class and ParcelableFlag classes, from which other flag types are based. ResourceFlags always pull there default values out of context.getResources. They can not, however, be directly serialized and sent to the flag app. For that, we now have ParcelableFlag. Prior to this change, we were not properly alerting the Flag app about the current value of flags when it asked. This change now also fixes that. All flags are coerced into ParcelableFlag before being sent to the app. Note that ResourceFlags perform runtime logic, even in release builds, meaing that the opportunity for optimizing them at compile time is much smaller. Tools such as proguard will not have the opportunity to strip them out entirely. Bug: 203548827 Test: atest SystemUITests Change-Id: I3c37ccae16c00237f9cffffc9c22580454ecb8cc
* Remove FlagWriter class.Dave Mankoff2021-11-171-3/+1
| | | | | | Bug: 203548827 Test: manual Change-Id: I651cb9a42e8ebb6ea11599cde97a5d8eaeb5d1b2
* Convert FeatureFlags to interface.Dave Mankoff2021-11-171-0/+74
Rename FeatureFlagManager version to FeatureFlagsDebug and FeatureFlagsRelease, implementing the FeatureFlags interface. Bug: 203548827 Test: manual Change-Id: I4b78757a5e7ee3d5ee06f9124e2b8f670e611d4f
generated by cgit v1.2.3 (git 2.25.1) at 2026-01-13 10:11:18 +0000