summaryrefslogtreecommitdiff
path: root/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java
Commit message (Collapse)AuthorAgeFilesLines
* Merge tag 'android-13.0.0_r71' of ↵George Zacharia2023-08-091-0/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://android.googlesource.com/platform/frameworks/base into t13.0 Android 13.0.0 Release 71 (TQ3A.230805.001.B1) * tag 'android-13.0.0_r71' of https://android.googlesource.com/platform/frameworks/base: Fix weather complication disappearing after timer pause DO NOT MERGE Hide EmptyShadeView when on bouncer DO NOT MERGE Adding tests for updated EmptyShadeView logic USB: update logic for reporting playback and capture capability of USB devices. Remove ControlsProviderSelectorActivity finish on ControlsFavoritingActivity start Prevent force showing system bars for TaskView Improve first opaque activity candidate detection Invalidate buffers on transform change Skip letterboxing if the activity below is embedded Unfreeze the surface when the transition is done [RESTRICT AUTOMERGE] Always set last report configuration for starting window. Fix split cannot active if app trampoline launch new task Update the timing of clearing SplitRequest Gates RotationResolverService with a config flag Change-Id: Ief3bf540e89f59ee0a480d028be0c61371d8cbd2
| * DO NOT MERGE Hide EmptyShadeView when on bouncerShawn Lee2023-06-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | Added a check to make sure EmptyShadeView is hidden when bouncer is showing. Bug: 267060171 Test: manually verified EmptyShadeView visibility (cherry picked from commit bef2be6757eec92391189c106e89b63176cd16c0) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2e640447d16c4e893927e2f76bda8b1073bb18f8) Merged-In: I2bfdc7801cec1b3aaa44f841d8a821214c6cb801 Change-Id: I2bfdc7801cec1b3aaa44f841d8a821214c6cb801
* | Merge tag 'android-13.0.0_r67' of ↵George Zacharia2023-08-091-1/+0
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://android.googlesource.com/platform/frameworks/base into t13.0 Android 13.0.0 Release 67 (TQ3A.230805.001) * tag 'android-13.0.0_r67' of https://android.googlesource.com/platform/frameworks/base: Merge "Resolve StatusHints image exploit across user." into sc-v2-dev am: e371b3018f Remove unnecessary padding code Use Settings.System.getIntForUser instead of getInt to make sure user specific settings are used DO NOT MERGE Verify URI permissions in MediaMetadata Visit URIs in themed remoteviews icons. Check URIs in sized remote views. Fix PrivacyChip not visible issue Update Pip launches to not enter pinned task if in background. Validate ComponentName for MediaButtonBroadcastReceiver Implement visitUris for RemoteViews ViewGroupActionAdd. Check URIs in notification public version. Preserve flags for non-runtime permissions upon package update. On device lockdown, always show the keyguard Ensure policy has no absurdly long strings Verify URI permissions for notification shortcutIcon. Do not load drawable for wallet card if the card image icon iscreated with content URI. ActivityManagerService: Allow openContentUri from vendor/system/product. Change-Id: Ice3533cb5ebf4868cc9aa0500568b899293872ab
* | Merge tag 'android-13.0.0_r63' of ↵George Zacharia2023-08-021-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | https://android.googlesource.com/platform/frameworks/base into t13.0-r52 Android 13.0.0 release 63 Change-Id: I89d2c7a713cd97f805f07f604090a6d779117575
| * | DO NOT MERGE Hide EmptyShadeView when on bouncerShawn Lee2023-05-271-0/+1
| |/ | | | | | | | | | | | | | | | | | | | | Added a check to make sure EmptyShadeView is hidden when bouncer is showing. Bug: 267060171 Test: manually verified EmptyShadeView visibility (cherry picked from commit bef2be6757eec92391189c106e89b63176cd16c0) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2e640447d16c4e893927e2f76bda8b1073bb18f8) Merged-In: I2bfdc7801cec1b3aaa44f841d8a821214c6cb801 Change-Id: I2bfdc7801cec1b3aaa44f841d8a821214c6cb801
* | Merge tag 'android-13.0.0_r52' of ↵George Zacharia2023-08-021-1874/+703
|\| | | | | | | | | | | | | https://android.googlesource.com/platform/frameworks/base into t13.0 Android 13.0.0 Release 52 (TQ3A.230605.012) Change-Id: Ic80f318636f1f70bbd009504352ddde511d0dead
| * Merge changes from topic "tsuji-wakeup" into tm-qpr-devJeff DeCew2023-03-291-0/+31
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | * changes: Create AnimatorTestRule2 which avoids the test interaction bugs with the original as it currently exists Keep the clock centered until the delayed doze animation plays. Delay the dozeAmount change animation. Run ktfmt on NotificationWakeUpCoordinator.kt Restructure the NotificationWakeUpCoordinator's dozeAmount recalculation. Tell NotificationWakeupCoordinator if we're waking from power button w/ SFPS press-to-unlock.
| | * Keep the clock centered until the delayed doze animation plays.Josh Tsuji2023-03-271-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | This prevents the clock from moving until the notifications come down. Bug: 269085199 Test: atest NotificationPanelViewTest Change-Id: Iaf3f5f6ba3dd5b7a62b4e41d857069f7c8cb888e
| | * Tell NotificationWakeupCoordinator if we're waking from power button w/ SFPS ↵Josh Tsuji2023-03-261-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | press-to-unlock. Bug: 269085199 Test: wake up with/without power button, with/without touch to unlock anytime enabled Change-Id: If0c7c5ef4e489ec3ff595e7f852c50b41644fa90
| * | Merge "Fix taskbar linger above notification shade" into tm-qpr-devJohannes Gallmann2023-03-241-1/+4
| |\ \
| | * | Fix taskbar linger above notification shadeJohannes Gallmann2023-03-241-1/+4
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remarks: 1. I think the correct fix for this would be to have the Taskbar z-ordered below the notification shade. That however seems to be difficult because there are cases when the taskbar window must be above the notification shade. 2. This CL improves the behaviour by starting the taskbar disappear animation when the notification panel is half expanded instead of waiting for the full expansion. This improves the UX when expanding the shade slowly. When expanding the shade quickly, this CL does unfortunately not significantly improve the UX. 3. I believe that the `SYSUI_STATE_NOTIFICATION_PANEL_EXPANDED` and `SYSUI_STATE_QUICK_SETTINGS_EXPANDED` flags can be replaced by the newly introduced one. But since this would pose the risk of introducing new bugs, I did not do that in this CL. It is my intention to create a CL with that replacement in udc. Bug: 272621219 Test: Manual, i.e. observe Taskbar behaviour when pulling down notification shade and expanding quick settings Change-Id: I10eb4d211f614559167f110000dcec3c8df5e3c8
| * | Merge "Revert "Keep keyguard visible if we're launching an occluding ↵Josh Tsuji2023-03-231-5/+0
| |\ \ | | |/ | |/| | | | activity over a going-away keyguard."" into tm-qpr-dev
| | * Revert "Keep keyguard visible if we're launching an occluding activity over ↵Josh Tsuji2023-03-231-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a going-away keyguard." This reverts commit 88885b0e68fc1327ebf20ce70d36df82112b36c7. Reason for revert: b/274401776 Change-Id: I7b7f5c26240c8d4155cb6aad945f14a6724725c0
| * | Merge "Prevent AOD clock from appearing on LS after fold" into tm-qpr-devHawkwood Glazier2023-03-221-3/+12
| |\ \
| | * | Prevent AOD clock from appearing on LS after foldHawkwood Glazier2023-03-211-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | Bug: 253770884 Test: Manually verified reproduction failed to occur Change-Id: I3cddc33833881fd67a0efe677330439d89ff5b94
| * | | Merge "Fix NPE in Stepped Clock Animation" into tm-qpr-devHawkwood Glazier2023-03-201-7/+12
| |\ \ \
| | * | | Fix NPE in Stepped Clock AnimationHawkwood Glazier2023-03-201-7/+12
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | Bug: 274122173 Fixes: 274193808 Test: atest KeyguardClockSwitchControllerTest Change-Id: Ia309c822b0179f7335b48f77acffb3048b4b0eac
| * | | Merge "Prevent flings after motion gestures on fully expanded keyguard take ↵Shawn Lee2023-03-201-1/+7
| |\ \ \ | | | | | | | | | | | | | | | 2" into tm-qpr-dev
| | * | | Prevent flings after motion gestures on fully expanded keyguard take 2Shawn Lee2023-03-161-1/+7
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Narrower version of original reverted change. Any up-down gesture on keyguard would trigger a fling that visibly jumped the keyguard up due to the different height calculation for shade vs keyguard. If the gesture was quick enough, we were stuck with this incorrect expansion fraction until the next touch. This change simply blocks flings on keyguard off guestures that end at full expansion, since touch has already been intercepted by NotificationShadeWindowViewController when we're about to fling from that state. Test: manual Bug: 259023628 Change-Id: I0c8d585c964ec8046395b260b5a7a60849beab2b
| * | | Merge "Step clock animation: Fix NPE when startValues or endValues are null" ↵Christian Göllner2023-03-201-2/+6
| |\ \ \ | | | | | | | | | | | | | | | into tm-qpr-dev
| | * | | Step clock animation: Fix NPE when startValues or endValues are nullChristian Göllner2023-03-171-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By looking at parent class implementations of Transition, it seems that is a legit case, and that should be handled by returning a null Animator Test: SplitShadeTransitionAdapterTest.kt Fixes: 274002399 Change-Id: I07501eb4bbd001bdb6014a3644e41cd8b575ccee
| * | | | Merge "Keep keyguard visible if we're launching an occluding activity over a ↵Josh Tsuji2023-03-161-0/+5
| |\ \ \ \ | | |_|/ / | |/| | / | | | |/ | | |/| going-away keyguard." into tm-qpr-dev
| | * | Keep keyguard visible if we're launching an occluding activity over a ↵Josh Tsuji2023-03-151-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | going-away keyguard. This happens when bypass is enabled - the occluding activity launches over the keyguard visually, but the keyguard is going away since it's being dismissed by the launch. We weren't checking for this case, so we were allowing keyguard to be hidden, showing the shade UI. Additionally, we need to keep the wallpaper around to prevent the keyguard UI from showing over a black backdrop during this animation. Fixes: 266630755 Test: launch occluding activity over unlocked lockscreen w/ bypass enabled Change-Id: I5a7df7df5aa5339276470529e7164475c6e99e13
| * | | Merge "Fix QS and QS Footer sometimes having low alpha after expansion" into ↵Christian Göllner2023-03-161-2/+2
| |\ \ \ | | | | | | | | | | | | | | | tm-qpr-dev
| | * | | Fix QS and QS Footer sometimes having low alpha after expansionChristian Göllner2023-03-151-2/+2
| | | |/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This could happen in two cases: - Fast fling to expand shade - Setting global animator duration scale to 0 There were two issues in the code: - For the footer: During very fast flings, QSFragment was receiving calls to setExpansion, and when certain parameters where the same as before, there was an early return, and the footer alpha was not being set. The code to check if the parameters were the same as before, forgot to check for the value of "panelExpansionFraction". This was different than before, and used for the footer alpha, but ignored in the check. - For the entire panel: reproducible when setting animator duration scale to 0. The issue was that QuickSettingsController didn't have the most up to date value for the shade expansion fraction. When animator duration scale was 1, this issue was almost no visible because it keep getting new values until reaching 0.999 of expansion. When setting the animator duration scale to 0, there will only be one call with the updated expansion, instead of multiple, so the out of date value will be noticeable. Fixes: 271605496 Fixes: 219589379 Test: Manually, as described above. Change-Id: I4ab954b1d5ccca609af63179e72e053f7e1f4a64
| * | | Revert "Prevent flings after motion gestures on fully expanded keyguard"Shawn Lee2023-03-151-7/+4
| | |/ | |/| | | | | | | | | | | | | | | | | | | This reverts commit e53315ec9cece18880f1a7fbc39acdabb83c7618. Reason for revert: need to re-land after fixing broken small clock interaction Change-Id: I6fe5f23fa3bf1be663cb858a1b0d492eb5cf51cc
| * | Prevent flings after motion gestures on fully expanded keyguardShawn Lee2023-03-131-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Any up-down gesture on keyguard would trigger a fling that visibly jumped the keyguard up due to the different height calculation for shade vs keyguard. If the gesture was quick enough, we were stuck with this incorrect expansion fraction until the next touch. This change simply blocks flings on keyguard off guestures that end at full expansion. Test: manual Bug: 259023628 Change-Id: Id67c0e38cc28a13fd19d23bdd0b6bff31cf1fe30
| * | Merge "Reset shade over scroll state when split shade enabled changes" into ↵Christian Göllner2023-03-131-0/+6
| |\ \ | | |/ | |/| | | | tm-qpr-dev
| | * Reset shade over scroll state when split shade enabled changesChristian Göllner2023-03-101-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | It seems that in some corner cases, there might be left over overscroll state from when split shade is enabled. Bug: 268531152 Test: NotificationPanelViewControllerTest.java Change-Id: Id6058be76f5d50ba15bce5d8dbe768963c911a41
| * | Touch handling and other tiny cleanups in NPVCJustin Weir2023-03-081-38/+25
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | The interface used for the touch handling handoff between Status Bar and Shade is nearly the same as Gefingerpoken, so this change will remove the redundancy. It also removes the usage of the view as an an unnecessary middleman by passing events directly to the Shade touch handler. Also includes some trivial warning cleanup. This was originally the first in a chain of CLs attempting to fix multitouch in the shade, but the follow up CL was too risky for QPR. Bug: 132458655 Test: manual and atest Change-Id: Iabb3484e43573b6e4f7755d1abe0a76512828834
| * Split shade expansion: adjust alpha interpolation to match motion specsChristian Göllner2023-03-071-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Centralizes the interpolation values for easier tweaking in the future + Adds more granular control over interpolation of different components: - Behind scrim - Notification scrim - Notifications - Notification footer - QS Change-Id: I5e13855e9a5ab5fc0a0c98c3e7293571e515ab8d Test: Unit tests Test: Manually on device. See videos Fixes: 259269166 Fixes: 265643813 Flag: LARGE_SHADE_GRANULAR_ALPHA_INTERPOLATION
| * Revert^2 "ADD CUJ_LOCKSCREEN_CLOCK_MOVE_ANIMATION"Christian Göllner2023-03-021-1/+23
| | | | | | | | | | | | | | 6f82cb827c4f05aa0958835df8846bb06c83b673 Change-Id: I9c32bd030e79f67cc888fe3c19805dfce680a91a Merged-In: I8a574715e3a341b7a3a0edd368cdb0015b8b4b50
| * Revert "ADD CUJ_LOCKSCREEN_CLOCK_MOVE_ANIMATION"Christian Göllner2023-03-011-23/+1
| | | | | | | | | | | | | | | | | | | | | | Revert submission 21549375-CUJ_LOCKSCREEN_CLOCK_MOVE_ANIMATION Reason for revert: Seems to be causing crashes in some cases, due to the jump in id from 69 to 71 in InteractionJankMonitor. Reverted changes: /q/submissionid:21549375-CUJ_LOCKSCREEN_CLOCK_MOVE_ANIMATION Change-Id: Icfe6de96b40b4d815974e40e88e822030345198f Fixes: 271263026
| * ADD CUJ_LOCKSCREEN_CLOCK_MOVE_ANIMATIONChristian Göllner2023-02-281-1/+23
| | | | | | | | | | | | | | Bug: 231130476 Test: recorded perfetto trace while the clock moves on lockscreen Change-Id: I8a574715e3a341b7a3a0edd368cdb0015b8b4b50 Merged-In: I8a574715e3a341b7a3a0edd368cdb0015b8b4b50
| * [DO NOT MERGE] Remove UNOCCLUSION_TRANSITION flagMatt Pietal2023-02-221-62/+45
| | | | | | | | | | | | | | | | | | | | | | ... and all of the associated dead code. Fixes: 262859270 Test: atest KeyguardViewMediatorTest NotificationShadeWindowViewControllerTest ScrimControllerTest StatusBarKeyguardViewManagerTest Change-Id: I8d33e07ef566945353dec75a51a7f783b0ed8371
| * Merge changes Ia2d6f52d,I578b8257 into tm-qpr-devFabian Kozynski2023-02-221-5/+5
| |\ | | | | | | | | | | | | | | | * changes: Remove new headers flag Prepare to remove new headers flag
| | * Prepare to remove new headers flagFabian Kozynski2023-02-221-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL sets everything up for removal of the flag. In particular: * Shortcircuits any conditional the flag was in to true. * Removes all the header views and code from QuickStatusBarHeader and controller. This still exists because it contains QuickQSPanel and refactoring is outside of the scope of this CL. * Renames LargeScreenShadeHeaderController to ShadeHeaderController * Replaces the view with a MotionLayout unconditionally * Removes dimens that were explicitly for combined headers and applies them to the default dimen. * Combines LargeScreenShadeHeaderControllerTest and LargeShadeHeaderControllerCombinedTest into ShadeHeaderControllerTest * Adds the views to the NotificationPanelUnfoldAnimationController Bug: 254512321 Test: SystemUITests Test: QS PlatformScenarioTests Change-Id: I578b82571dc91a9e31c196f3affe60d84c64a1fe
| * | Merge "Making sure QS are not closed when split shade is open" into tm-qpr-devMichał Brzeziński2023-02-221-4/+12
| |\ \
| | * | Making sure QS are not closed when split shade is openMichal Brzezinski2023-02-171-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Checking that we can actually close QS, that is we're really closing shade 2. Logging when we're forcing closing QS in split shade 3. Removing unnecessary call to closeQS from ShadeControllerImpl - "collapsePanel" already tries closing QS anyway Fixes: 264558771 Bug: 219589379 Test: In full screen app try swiping split shade up and when it disappears - without lifting finger from screen - swipe quickly down Change-Id: Icc6899018e0815e4729bcefd02163a5a9cfec022
| * | | Merge "Fix unlocked split shade jumping back into place after over ↵TreeHugger Robot2023-02-221-6/+10
| |\ \ \ | | | | | | | | | | | | | | | expanding" into tm-qpr-dev
| | * | | Fix unlocked split shade jumping back into place after over expandingChristian Göllner2023-02-201-6/+10
| | | |/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem was that there were separate code paths for over-scroll/ over-expansion for split shade and non split shade. In this case the non split shade path was altering translation at the end of the drag, even when on split shade. To avoid adding even more "if split shade" code, removed the split shade over-scrolling code path/classes. There is only one overscroll code path now, with just 1 "if split" shade condition to decide which components to over expand. Test: Manually on device. See videos. Fixes: 270005948 Change-Id: Ia47aa30957260a9c2d1efd7e5f18536f76a2dcc9
| * | | Merge "Logging when QS fling happens and when split shade state changes" ↵Michał Brzeziński2023-02-221-0/+1
| |\ \ \ | | |/ / | |/| | | | | | into tm-qpr-dev
| | * | Logging when QS fling happens and when split shade state changesMichal Brzezinski2023-02-171-0/+1
| | |/ | | | | | | | | | | | | | | | | | | | | | Also adding temporary logs when COLLAPSE fling happens in split shade (which should never happen) Bug: 219589379 Test: just logs Change-Id: I103771f5e3dea6fb9a2c9451911a5735efcb8812
| * / Talkback read unlocked split shade as QSyyalan2023-02-171-1/+6
| |/ | | | | | | | | | | | | | | Handling the special case that in unlocked split shade, though QS is expanded, we want to call it "QS & notification shade" Fixes: 267830416 Test: manual Change-Id: I82e9076d2057171d436ceb5e60c370df69a80bf3
| * Merge "Revert "Ignore ACTION_DOWN events when mTracking is true"" into ↵Justin Weir2023-02-161-10/+0
| |\ | | | | | | | | | tm-qpr-dev
| | * Revert "Ignore ACTION_DOWN events when mTracking is true"Justin Weir2023-02-151-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 01aa146c2dc8a2b43955818443bbc440500ae7eb. Reason for revert: b/269175395 Change-Id: Ic15aec87e90f8a6e87ca8e6ab72ab13d4d780069
| * | Extract most QS code from NPVCShawn Lee2023-02-081-1793/+292
| | | | | | | | | | | | | | | | | | | | | | | | Moved QS-related code from NPVC to a new class that handles QS panel expansion Bug: 254870148 Test: manual, atest Change-Id: Ic1cbdc6c02e25cd3efaea4badbf2b8835895459b
| * | Adding extra logging for double swipe down shade bugShawn Lee2023-02-081-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Added extra log to investigate test team still being able to repro bug Bug: 266156260 Test: N/A Change-Id: Ia43d791da67da2c83687d91ea28112f5227848e8
| * | Merge "Fixed swipe down while shade expanding not expanding QS" into tm-qpr-devShawn Lee2023-02-031-1/+3
| |\ \
| | * | Fixed swipe down while shade expanding not expanding QSShawn Lee2023-02-021-1/+3
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | Modified check for deferring touches on QQS area to shade while collapsing to make sure the last fling wasn't for expansion Bug: 266156260 Test: manual and atest Change-Id: Ibec4d868dacd9125c09443c6d4032eb14f3b7db8
generated by cgit v1.2.3 (git 2.25.1) at 2026-01-12 17:21:02 +0000