summaryrefslogtreecommitdiff
path: root/packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java
Commit message (Collapse)AuthorAgeFilesLines
* Set corner radius to 0 when castingAaron Liu2023-05-091-2/+8
| | | | | | | | | | | When we are casting the device, set the corner radius to 0. Fixes: 276327242 Test: cast to device and notice that rounded corners are not there. (cherry picked from commit ae4dec818aa975d24522349468792e8546131bd0) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ebf8503944f705d497a0d3a3aadc454e3f7eb07b) Merged-In: I76427c0064c9935c76e3ec8662d6b7955bcbfd2b Change-Id: I76427c0064c9935c76e3ec8662d6b7955bcbfd2b
* Only disallow QS expansion while keyboard is visibleJustin Weir2023-04-071-1/+11
| | | | | | | | | | | | | Currently, a bug makes isRemoteInput sometimes returns true when there is no remote input. In order to reduce the impact of the bug, we will also require the keyboard to be visible to block QS expansion. This will allow users to dismiss the keyboard then expand QS while the input has the focus, but this is an acceptable tradeoff while the root cause is being addressed. Bug: 276357074 Test: manually checked go/shade-cujs and ran atest Change-Id: I291ea25c45297820032dec10d81fe88e4159bea6
* Fixed NSSL top padding being set below QQS minimum heightShawn Lee2023-03-291-2/+3
| | | | | | | | | | The issue would become apparent in locktask ui mode, where QQS tiles are hidden. The NSSL top padding and notif scrim clipping would be misaligned. Bug: 272414812 Test: manual Change-Id: I242aeeddc681a0e0b98b664084f3add98d97bac3
* Added logging for shade top padding and clippingShawn Lee2023-03-221-5/+61
| | | | | | Bug: 273591201 Test: N/A Change-Id: I1680c2e1bb976b09fd0822995587ffe23245e846
* Fix QS and QS Footer sometimes having low alpha after expansionChristian Göllner2023-03-151-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This could happen in two cases: - Fast fling to expand shade - Setting global animator duration scale to 0 There were two issues in the code: - For the footer: During very fast flings, QSFragment was receiving calls to setExpansion, and when certain parameters where the same as before, there was an early return, and the footer alpha was not being set. The code to check if the parameters were the same as before, forgot to check for the value of "panelExpansionFraction". This was different than before, and used for the footer alpha, but ignored in the check. - For the entire panel: reproducible when setting animator duration scale to 0. The issue was that QuickSettingsController didn't have the most up to date value for the shade expansion fraction. When animator duration scale was 1, this issue was almost no visible because it keep getting new values until reaching 0.999 of expansion. When setting the animator duration scale to 0, there will only be one call with the updated expansion, instead of multiple, so the out of date value will be noticeable. Fixes: 271605496 Fixes: 219589379 Test: Manually, as described above. Change-Id: I4ab954b1d5ccca609af63179e72e053f7e1f4a64
* Fix lockscreen shortcuts not showing on split shadeChristian Göllner2023-03-101-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue was that qsVisible was wrongly being set to `true` when on split shade, even when it was not visible. Lockscreen shortcuts only show when QS are not visible. To check whether QS (or QQS) was visible, we were checking: 1 - qsExpansionFraction > 0 1.1 Split shade: true when full QS showing 1.2 Single shade: true when full QS showing 2 - qsPanelBottomY > 0 2.1 Split Shade: ALWAYS true. Even if QS not showing 2.2 Single shade: true when on QQS or QS Since on split shade we can always rely on qsExpansionFraction, because there is no QQS, we changed the condition to ignore qsPanelBottomY when on split shade. Fixes: 272448562 Test: Manually on-device: 1 - Enabled teamfood flag 2 - Homescreen -> Wallpaper & Style 3 - Lockscreen -> Pick 2 non-none shortcuts 4 - Lock the screen 5 - Verify shortcuts are visible both in single and split shade Test: QuickSettingsControllerTest.java Change-Id: I9adc0c4625aadcc729b484c453c6ef7d17013fc9
* Merge "Log when qs height is set to 0 but probably shouldn't" into tm-qpr-devMichał Brzeziński2023-02-231-0/+14
|\
| * Log when qs height is set to 0 but probably shouldn'tMichal Brzezinski2023-02-171-0/+14
| | | | | | | | | | | | | | | | | | These logs will be deleted in ~2 months, they're temporary to help debug when b/219589379 happens again Bug: 219589379 Bug: 269742565 Test: just adding logs Change-Id: I8c6b384fe35ed4cde1e9d381edab96f09c36f203
* | Merge "Adding more test coverage for QuickSettingsController" into tm-qpr-devShawn Lee2023-02-221-3/+16
|\ \
| * | Adding more test coverage for QuickSettingsControllerShawn Lee2023-02-161-3/+16
| |/ | | | | | | | | | | Bug: 254870148 Test: atest Change-Id: I88bcbed13f08bb1175e15ef9506abb999d276e7c
* | Merge changes Ia2d6f52d,I578b8257 into tm-qpr-devFabian Kozynski2023-02-221-18/+9
|\ \ | | | | | | | | | | | | | | | * changes: Remove new headers flag Prepare to remove new headers flag
| * | Prepare to remove new headers flagFabian Kozynski2023-02-221-18/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL sets everything up for removal of the flag. In particular: * Shortcircuits any conditional the flag was in to true. * Removes all the header views and code from QuickStatusBarHeader and controller. This still exists because it contains QuickQSPanel and refactoring is outside of the scope of this CL. * Renames LargeScreenShadeHeaderController to ShadeHeaderController * Replaces the view with a MotionLayout unconditionally * Removes dimens that were explicitly for combined headers and applies them to the default dimen. * Combines LargeScreenShadeHeaderControllerTest and LargeShadeHeaderControllerCombinedTest into ShadeHeaderControllerTest * Adds the views to the NotificationPanelUnfoldAnimationController Bug: 254512321 Test: SystemUITests Test: QS PlatformScenarioTests Change-Id: I578b82571dc91a9e31c196f3affe60d84c64a1fe
* | | Merge "Making sure QS are not closed when split shade is open" into tm-qpr-devMichał Brzeziński2023-02-221-1/+8
|\ \ \
| * | | Making sure QS are not closed when split shade is openMichal Brzezinski2023-02-171-1/+8
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Checking that we can actually close QS, that is we're really closing shade 2. Logging when we're forcing closing QS in split shade 3. Removing unnecessary call to closeQS from ShadeControllerImpl - "collapsePanel" already tries closing QS anyway Fixes: 264558771 Bug: 219589379 Test: In full screen app try swiping split shade up and when it disappears - without lifting finger from screen - swipe quickly down Change-Id: Icc6899018e0815e4729bcefd02163a5a9cfec022
* | | Merge "Fix unlocked split shade jumping back into place after over ↵TreeHugger Robot2023-02-221-0/+4
|\ \ \ | | | | | | | | | | | | expanding" into tm-qpr-dev
| * | | Fix unlocked split shade jumping back into place after over expandingChristian Göllner2023-02-201-0/+4
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem was that there were separate code paths for over-scroll/ over-expansion for split shade and non split shade. In this case the non split shade path was altering translation at the end of the drag, even when on split shade. To avoid adding even more "if split shade" code, removed the split shade over-scrolling code path/classes. There is only one overscroll code path now, with just 1 "if split" shade condition to decide which components to over expand. Test: Manually on device. See videos. Fixes: 270005948 Change-Id: Ia47aa30957260a9c2d1efd7e5f18536f76a2dcc9
* | | Merge "Logging when QS fling happens and when split shade state changes" ↵Michał Brzeziński2023-02-221-0/+4
|\ \ \ | |/ / |/| | | | | into tm-qpr-dev
| * | Logging when QS fling happens and when split shade state changesMichal Brzezinski2023-02-171-0/+4
| |/ | | | | | | | | | | | | | | Also adding temporary logs when COLLAPSE fling happens in split shade (which should never happen) Bug: 219589379 Test: just logs Change-Id: I103771f5e3dea6fb9a2c9451911a5735efcb8812
* | Merge "Making sure collapseOrExpandedQs doesn't do anything in split shade" ↵Michał Brzeziński2023-02-201-0/+3
|\ \ | | | | | | | | | into tm-qpr-dev
| * | Making sure collapseOrExpandedQs doesn't do anything in split shadeMichal Brzezinski2023-02-161-0/+3
| |/ | | | | | | | | | | | | | | | | This is actually never called in split shade anymore - it was only used by accessibility action in QS which was removed for split shade in ag/21447326. This extra check is to prevent the regression happening in the future. Bug: 269462512 Test: presubmit Change-Id: Ib1472531c12aa667530f0c4cc407b22a798d7203
* / Add logging for mQsExpandImmediate changesMichal Brzezinski2023-02-161-0/+1
|/ | | | | | | | | I suspect reason for QS sometimes disappearing in split shade might have something to do with this value not being set correctly. Also it's not changing that often - twice per expand/collapse - so should be good to log. Bug: 219589379 Test: just adding logs Change-Id: Ic6ef9416c7198109905cfdf16ce4e998cd398f80
* Extract most QS code from NPVCShawn Lee2023-02-081-0/+2050
Moved QS-related code from NPVC to a new class that handles QS panel expansion Bug: 254870148 Test: manual, atest Change-Id: Ic1cbdc6c02e25cd3efaea4badbf2b8835895459b
generated by cgit v1.2.3 (git 2.25.1) at 2026-01-12 23:16:10 +0000