summaryrefslogtreecommitdiff
path: root/packages/SystemUI/src/com/android/systemui/util/ViewController.java
Commit message (Collapse)AuthorAgeFilesLines
* [Misc] Only create KeyguardStatusBarViewController once insideCaitlin Cassidy2021-08-051-10/+0
| | | | | | | | | | | | NotificationPanelViewController. The KeyguardStatusBarView never changes, so we don't need to re-create its controller in NPVController#updateViewControllers. Fixes: 194181195 Test: atest and manual Change-Id: If955a8d6167a08bec6e7a7e9e66a2c6a55f68966
* [Dagger] Move StatusBarIconController and FeatureFlags fromCaitlin Cassidy2021-07-211-0/+10
| | | | | | | | KeyguardStatusBarView to its controller. Test: atest and manual Bug: 138786270 Change-Id: I5fe29ab36650268fe627f5e0c64aebc261ce090a
* Use QSPanelController in QSAnimator.Dave Mankoff2020-11-041-5/+15
| | | | | | | | | | | | | | | | | The animator doesn't want the view, but rather some of the views contained within. At times, it simply wants some of the functionality that the view provides that will be better encapsulated by its controller. Replaced Dependency.get(TunerService.class) with an injected instance. Injected an executor for the class to use rather than relying on QSPanels implicit handler. Bug: 168904199 Test: manual Change-Id: Id228a9dd921fbb11ed2d1d56c93d37d8ceda1cd3
* Change ViewController#initInternal to #onInitDave Mankoff2020-10-231-4/+4
| | | | | | Bug: 171472009 Test: manual Change-Id: Iddc6c0240486b0d3005216bba0c40bfb481b94b3
* Add initInternal to ViewController.Dave Mankoff2020-10-221-3/+18
| | | | | | | | | | | | | | | | | | | ViewController's init method was not ideal to override. On the one hand, if you put a call super.init() first your onViewAttach method is called before you're subclass's init. Further, if you put your own code befer super.init(), you are still left with the problem that your init is not automatically idempotent, and multiple calls to #init() could result in multiple executions of your code unless you handle it yourself. With this change, #initInternal() is introduced, giving ViewControllers a place to put their run-once code such that it runs before any view-attachment callbacks are fired. Fixes: 171472009 Test: manual Change-Id: I2e284024c82e3f7c7b6f29f22a1ffa3c8aae9fcb
* 3/N Remove DevProvCtrl & UserTracker from QSFooterDave Mankoff2020-10-201-0/+10
| | | | | | | | | Remove DeviceProvisionedConroller and UserTracker from QSFooterImpl. This also adds QSFooterImplControllerTest, and fixes one of the tests that was marked as failing. Bug: 168904199 Test: manual Change-Id: I0e04bef8df76c6b73c8844f4679cfef08b3b2c13
* Revert^2 "9/N Clean Up Keyguard Class Structure"Dave Mankoff2020-09-241-3/+5
| | | | | | b00c929394cb6bce158265af9606a8eb5a79e47a Change-Id: I42d17262a789d2eb106a924b442a9d3debcc35e4
* Revert^2 "7/N controllers for remaining Keyguard Password ..."Dave Mankoff2020-09-241-1/+14
| | | | | | | | | | | | | | | | | | | | | | | Revert submission 12656261-revert-12585643-b166448040-keyguard-message-area-NUUJOVRYJS This also fixes the original issue introduced in this CL. KeyguardAbsKeyInputViewController#reset would call mView#resetState instead of its own internal resetState method. However, all the logic from the various resetState methods had been moved from the views to their controllers. Simply calling resetState direclty resolves the issue (line 105 of KeyguardAbsKeyInputViewController). Reason for revert: Fixing http://b/169231892 and http://b/169145796 Reverted Changes: I7683b2234:Revert "4/N Setup Controller fo KeyguardSecurityCo... I5cbe04c0c:Revert "5/N Add KeyguardSecurityViewFlipperControl... I11dff38ad:Revert "6/N Add Controller for KeyguardPatternView... I55c250121:Revert "7/N controllers for remaining Keyguard Pas... Ie84234cb8:Revert "8/N Remove View Injection from KeyguardMes... Ic62f199a5:Revert "9/N Clean Up Keyguard Class Structure" Change-Id: Ie3669e0c9a23ffd4443ced0fb08ec754f1df55db Fixes: 169145796
* Revert "7/N controllers for remaining Keyguard Password Views."Dave Mankoff2020-09-221-14/+1
| | | | | | | | | | | | | | | | | Revert submission 12585643-b166448040-keyguard-message-area Reason for revert: http://b/169081305 & http://b/169020145 Reverted Changes: I6fa05012c:4/N Setup Controller fo KeyguardSecurityContainer.... Iecf265744:5/N Add KeyguardSecurityViewFlipperController. I90ab99b2f:6/N Add Controller for KeyguardPatternView I4b74eddd1:7/N controllers for remaining Keyguard Password Vi... I805286374:8/N Remove View Injection from KeyguardMessageArea... I362755980:9/N Clean Up Keyguard Class Structure Change-Id: I55c250121c2e234a41b30f2d647c44f6cb631028 Fixes: 169081305 Fixes: 169020145
* Revert "9/N Clean Up Keyguard Class Structure"Dave Mankoff2020-09-221-5/+3
| | | | | | | | | | | | | | | | | Revert submission 12585643-b166448040-keyguard-message-area Reason for revert: http://b/169081305 & http://b/169020145 Reverted Changes: I6fa05012c:4/N Setup Controller fo KeyguardSecurityContainer.... Iecf265744:5/N Add KeyguardSecurityViewFlipperController. I90ab99b2f:6/N Add Controller for KeyguardPatternView I4b74eddd1:7/N controllers for remaining Keyguard Password Vi... I805286374:8/N Remove View Injection from KeyguardMessageArea... I362755980:9/N Clean Up Keyguard Class Structure Change-Id: Ic62f199a51a15d8384450b8f181f3c5a0b988d7f Fixes: 169081305 Fixes: 169020145
* 9/N Clean Up Keyguard Class StructureDave Mankoff2020-09-161-3/+5
| | | | | | | | | | | | | | | KeyguardInputView no longer implements KeyguardSecurityView. This cl seeks to clean up some of the lingering vestiges from this large chain of refactors. I have manually tested none, swipe, pattern, pin, and password views for successfully unlocking, as well as multiple failed attempts resulting in temporary lock outs. Fixes: 166448040 Test: atest SystemUITests && manual Change-Id: I36275598001184e774677cf2dbb16dec8dc7ab5b
* 7/N controllers for remaining Keyguard Password Views.Dave Mankoff2020-09-161-1/+14
| | | | | | | | | No real functionality changes (hopefully). Just moving objects into controllers. Test: manual Bug: 166448040 Change-Id: I4b74eddd18d29dd8966caa32c5960ff8be2e6f43
* 2/N Use KeyguardHostViewController in KeyguardBouncer.Dave Mankoff2020-09-081-3/+5
| | | | | | | | | | | | This mostly proxies existing calls through to the view. A few exceptions were made where it was obvious what to change. Also, make ViewController take a View type to streamling initialization a bit more. Bug: 166448040 Test: atest SystemUITests && manual. Change-Id: If849ff57c4b8462e07cc9a4b0546fe7d2a6a0c0a
* 1/N Add Controllers for most KeyguardBouncer related views.Dave Mankoff2020-09-081-0/+70
This adds Controllers to most of the KeyguardBouncer related views, though it does not move much (or any) functionality into them. This is the first step of a few to get View Injection out of the KeyguardMessageArea. The CL was growing large, and I wanted to find a good check-in point before continuing. I also added a "ViewController" utility class in this CL that simplifies some of the repetetive work I've been finding myself writing when implementing other Controllers. It is intentionally left simple, existing only to hook into view lifecycle events. More work to follow. Bug: 166448040 Test: manual && atest SystemUITests Change-Id: Ie59f62e97d979fb753e4a103d37ceca02e327238
generated by cgit v1.2.3 (git 2.25.1) at 2026-01-13 07:38:22 +0000