| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Bug: n/a
Test: no errors with -Werror,-Wextra-semi
Change-Id: If523cadea4c6f02a9155fb7482ba5463fff7854a
|
| |
|
|
|
|
|
| |
Bug: N/A
Test: build w/o -Wno-c++98-compat-extra-semi
Merged-In: I632d6df9a03485e547a6e7f14df0f1c068066c1e
Change-Id: I632d6df9a03485e547a6e7f14df0f1c068066c1e
|
| |
|
|
|
|
|
|
|
| |
This was being exported by the build system, but it shouldn't be used
anywhere.
Bug: N/A
Test: N/A
Change-Id: Id10772ec3e0ebf39ddf83f0f7981552c3f2e528d
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The lint rule google-default-arguments ensures that virtual or override
methods do not have default arguments, because different default values
across the hierarchy chain (e.g. Base::foo(int a=0) v.s.
Derived::foo(int a=10)) can cause confusions.
However, since the uses of the default arguments in libbinder don't lead
to such problem, suppress the warnings.
Test: WITH_TIDY=true WITH_TIDY_CHECKS=google-default-arguments m
libbinder does not show any warning about google-default-arguments
Change-Id: I90f6d05a9dc3232d0c63563df18a582432b83574
|
| |\
| |
| |
| |
| | |
Bug: 79597307
Change-Id: I6d6bee71b9424eb478780bbfc06b830eb8ded342
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
We need to open files for reading sometimes, so now
we can.
Test: manual
Change-Id: If089c1e7a4aac1d85784e070d2fccb04b9d84391
|
| |/
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes -Wzero-as-null-pointer-constant warning.
clang-tidy -checks=modernize-use-nullptr -p compile_commands.json -fix
...
Test: m
Bug: 68236239
Change-Id: I3181bc5683796423a98b0f9b94daf30880c07bdc
Merged-In: I3181bc5683796423a98b0f9b94daf30880c07bdc
(cherry picked from commit 91635563b8a1bf7a31e4ceb439728dacb79abd76)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace calls to dup() with fcntl(F_DUPFD_CLOEXEC). The only difference
between the two is that O_CLOEXEC is set on the newly duped file
descriptor. This helps address file descriptor leaks crossing an exec()
boundary in multi-threaded processes, and potentially fixes the following
non-reproducible SELinux denials which may be occurring because of FD
leakage from netd to clatd/dnsmasq.
avc: denied { use } for comm="clatd" path="socket:[860297]" dev="sockfs"
ino=860297 scontext=u:r:clatd:s0 tcontext=u:r:untrusted_app:s0:c512,c768
tclass=fd permissive=0
avc: denied { read write } for comm="clatd" path="socket:[1414454]"
dev="sockfs" ino=1414454 scontext=u:r:clatd:s0
tcontext=u:r:system_server:s0 tclass=tcp_socket permissive=0
avc: denied { use } for comm="clatd" path="socket:[681600]" dev="sockfs"
ino=681600 scontext=u:r:clatd:s0 tcontext=u:r:priv_app:s0:c512,c768
tclass=fd permissive=0
Test: Device boots and no obvious problems
Change-Id: I9dcd9911a093f329c6f12e39d2c49ef3df651ae5
|
|
|
This introduces a new feature of the IBinder command protocol
to allow the shell command implementation to call back into
its caller to ask it to open files in the calling context. This
is needed so that commands that have arguments specifying files
can open those files as the calling shell, not the system (or
whatever) process.
Test: Manual
Change-Id: Idd5b49ea21057864cc9cef816b3e4afbf01948fc
|