summaryrefslogtreecommitdiff
path: root/cpu_ref/rsCpuScript.cpp
diff options
context:
space:
mode:
authorStephen Hines <srhines@google.com>2013-04-09 19:05:27 -0700
committerStephen Hines <srhines@google.com>2013-04-09 19:05:27 -0700
commitef7481e2f0a4ad7b32bb626245e4207cabe171dc (patch)
tree9563a50314f700a214c768470c12ae80c8721ec4 /cpu_ref/rsCpuScript.cpp
parent61c86951f6a1192fafc536aee613beb6f899064b (diff)
Remove invalid logging on missing root.expand() functions.
Bug: 8566872 This log message is confusing and unncessary. Due to legacy compatibility, slot 0 is always reserved for root.expand(). We know that root.expand() may not exist for many user scripts, since we have supported proper names for kernels for several releases now. Change-Id: Id869496aa83f98ce64d6bd784314d788e25182e0
Diffstat (limited to 'cpu_ref/rsCpuScript.cpp')
-rw-r--r--cpu_ref/rsCpuScript.cpp10
1 files changed, 4 insertions, 6 deletions
diff --git a/cpu_ref/rsCpuScript.cpp b/cpu_ref/rsCpuScript.cpp
index ff1fd142..77ea75c4 100644
--- a/cpu_ref/rsCpuScript.cpp
+++ b/cpu_ref/rsCpuScript.cpp
@@ -359,14 +359,12 @@ bool RsdCpuScriptImpl::init(char const *resName, char const *cacheDir,
mForEachSignatures[i] = tmpSig;
mForEachFunctions[i] =
(ForEachFunc_t) dlsym(mScriptSO, tmpName);
- if (mForEachFunctions[i] == NULL) {
- ALOGE("Failed to find forEach function address for %s: %s",
- tmpName, dlerror());
+ if (i != 0 && mForEachFunctions[i] == NULL) {
// Ignore missing root.expand functions.
// root() is always specified at location 0.
- if (i != 0) {
- goto error;
- }
+ ALOGE("Failed to find forEach function address for %s: %s",
+ tmpName, dlerror());
+ goto error;
}
else {
//ALOGE("Found forEach %s at %p", tmpName, mForEachFunctions[i]);