diff options
| author | Todd Kjos <tkjos@google.com> | 2018-11-26 17:24:15 -0800 |
|---|---|---|
| committer | SecurityBot <android-nexus-securitybot@system.gserviceaccount.com> | 2018-11-29 12:38:23 -0800 |
| commit | 5dbdd3698e85ba9a461a8c4d47994f05b369d332 (patch) | |
| tree | f51f9bf63b69e63caa908e33ee0e4bf2f5d7e887 /net/lapb/lapb_in.c | |
| parent | d1d838864d09023daa082216d282f2a93675f25e (diff) | |
binder: fix race between munmap() and direct reclaim
An munmap() on a binder device causes binder_vma_close() to be called
which clears the alloc->vma pointer.
If direct reclaim causes binder_alloc_free_page() to be called, there
is a race where alloc->vma is read into a local vma pointer and then
used later after the mm->mmap_sem is acquired. This can result in
calling zap_page_range() with an invalid vma which manifests as a
use-after-free in zap_page_range().
The fix is to check alloc->vma after acquiring the mmap_sem (which we
were acquiring anyway) and bail out of binder_alloc_free_page() if it
has changed to NULL.
Bug: 120025196
Change-Id: I9ea0558a57635a747d7a48ed35991d39b860abf6
Signed-off-by: Todd Kjos <tkjos@google.com>
Diffstat (limited to 'net/lapb/lapb_in.c')
0 files changed, 0 insertions, 0 deletions
