aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaya Erez <merez@codeaurora.org>2014-03-17 10:22:42 +0200
committerMaya Erez <merez@codeaurora.org>2014-03-17 10:22:42 +0200
commitf22a15dbadd39144ea1949a9febcabb41ca6b86c (patch)
treeba925d156403a45790b6f5395f7ab9d312d2d585
parent602a0bb9ec6df32de8c611fcbfb490f8cf8542b0 (diff)
usb: gadget: Fix KW error for NULL pointer check
port pointer is being used without checking if it's NULL. Add a check for preventing NULL pointer access. CRs-Fixed: 629914 Change-Id: I171c1bd113071d4689a5d3de3e8dac52cdd44a0e Signed-off-by: Maya Erez <merez@codeaurora.org>
-rw-r--r--drivers/usb/gadget/u_bam.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/usb/gadget/u_bam.c b/drivers/usb/gadget/u_bam.c
index 6097adb11ef..cc48cc07de1 100644
--- a/drivers/usb/gadget/u_bam.c
+++ b/drivers/usb/gadget/u_bam.c
@@ -1068,13 +1068,17 @@ static void gbam2bam_connect_work(struct work_struct *w)
struct usb_gadget *gadget = NULL;
struct teth_bridge_connect_params connect_params;
struct teth_bridge_init_params teth_bridge_params;
- struct bam_ch_info *d = &port->data_ch;
+ struct bam_ch_info *d;
u32 sps_params;
int ret;
unsigned long flags;
- if (port)
- dev = port_to_rmnet(port->gr);
+ if (!port) {
+ pr_err("%s: NULL port", __func__);
+ return;
+ }
+ d = &port->data_ch;
+ dev = port_to_rmnet(port->gr);
if (dev && dev->cdev)
gadget = dev->cdev->gadget;