diff options
| author | David S. Miller <davem@davemloft.net> | 2015-05-01 22:02:47 -0400 |
|---|---|---|
| committer | Steve Kondik <steve@cyngn.com> | 2015-05-03 01:55:39 -0700 |
| commit | dab586274fceeb450617c8fbf5299244bd716985 (patch) | |
| tree | e20a13fbfd1d52905a1cf427e34f427c9f8cdc56 | |
| parent | 506553df1679265131d5c3753047b96f2e53d1df (diff) | |
ipv4: Missing sk_nulls_node_init() in ping_unhash().
If we don't do that, then the poison value is left in the ->pprev
backlink.
This can cause crashes if we do a disconnect, followed by a connect().
Tested-by: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Wen Xu <hotdog3645@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Change-Id: I4c98bb7c93f170c14def22b4becc7e99e40a6462
| -rw-r--r-- | net/ipv4/ping.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index c64dcf903dc..145dffd8f1f 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -153,6 +153,7 @@ void ping_unhash(struct sock *sk) if (sk_hashed(sk)) { write_lock_bh(&ping_table.lock); hlist_nulls_del(&sk->sk_nulls_node); + sk_nulls_node_init(&sk->sk_nulls_node); sock_put(sk); isk->inet_num = 0; isk->inet_sport = 0; |