summaryrefslogtreecommitdiff
path: root/src/com/android/browser/Controller.java
diff options
context:
space:
mode:
authorJonathan Dixon <joth@google.com>2012-12-17 13:39:17 -0800
committerJonathan Dixon <joth@google.com>2012-12-17 13:39:17 -0800
commite1d6dfca80e4627a0c7fe46e38f904179c3edab3 (patch)
tree10f62ca2d7f4567e8cb717ec626215eb9a4681f8 /src/com/android/browser/Controller.java
parentdd41509b73803f4f575b739b6276177fe9de7e80 (diff)
De-classicify Browser
Removes the hard run-time dependency on WebViewClassic. (Still needs visisbility of it to build though) This is needed to enable chromium webview testing. Change-Id: I290b6b23b2eac525537ebc3ef8007d681a67a169
Diffstat (limited to 'src/com/android/browser/Controller.java')
-rw-r--r--src/com/android/browser/Controller.java21
1 files changed, 14 insertions, 7 deletions
diff --git a/src/com/android/browser/Controller.java b/src/com/android/browser/Controller.java
index caea83e7..7b7fcd48 100644
--- a/src/com/android/browser/Controller.java
+++ b/src/com/android/browser/Controller.java
@@ -260,7 +260,7 @@ public class Controller
@Override
public void start(final Intent intent) {
- WebViewClassic.setShouldMonitorWebCoreThread();
+ if (BrowserWebView.isClassic()) WebViewClassic.setShouldMonitorWebCoreThread();
// mCrashRecoverHandler has any previously saved state.
mCrashRecoveryHandler.startRecovery(intent);
}
@@ -356,7 +356,7 @@ public class Controller
}
// Read JavaScript flags if it exists.
String jsFlags = getSettings().getJsEngineFlags();
- if (jsFlags.trim().length() != 0) {
+ if (jsFlags.trim().length() != 0 && BrowserWebView.isClassic()) {
WebViewClassic.fromWebView(getCurrentWebView()).setJsFlags(jsFlags);
}
if (intent != null
@@ -1196,7 +1196,12 @@ public class Controller
long id = intent.getLongExtra(
ComboViewActivity.EXTRA_OPEN_SNAPSHOT, -1);
if (id >= 0) {
- createNewSnapshotTab(id, true);
+ if (BrowserWebView.isClassic()) {
+ createNewSnapshotTab(id, true);
+ } else {
+ Toast.makeText(mActivity, "Snapshot Tab requires WebViewClassic",
+ Toast.LENGTH_LONG).show();
+ }
}
}
break;
@@ -2257,7 +2262,9 @@ public class Controller
}
public SelectText(WebView webView) {
- mWebView = WebViewClassic.fromWebView(webView);
+ if (BrowserWebView.isClassic()) {
+ mWebView = WebViewClassic.fromWebView(webView);
+ }
}
}
@@ -2545,7 +2552,7 @@ public class Controller
// In case the user enters nothing.
if (url != null && url.length() != 0 && tab != null && view != null) {
url = UrlUtils.smartUrlFilter(url);
- if (!WebViewClassic.fromWebView(view).getWebViewClient().
+ if (!((BrowserWebView) view).getWebViewClient().
shouldOverrideUrlLoading(view, url)) {
loadUrl(tab, url);
}
@@ -2738,14 +2745,14 @@ public class Controller
}
break;
case KeyEvent.KEYCODE_A:
- if (ctrl) {
+ if (ctrl && BrowserWebView.isClassic()) {
WebViewClassic.fromWebView(webView).selectAll();
return true;
}
break;
// case KeyEvent.KEYCODE_B: // menu
case KeyEvent.KEYCODE_C:
- if (ctrl) {
+ if (ctrl && BrowserWebView.isClassic()) {
WebViewClassic.fromWebView(webView).copySelection();
return true;
}