diff options
| author | jruesga <jorge@ruesga.com> | 2012-09-14 23:11:03 +0200 |
|---|---|---|
| committer | jruesga <jorge@ruesga.com> | 2012-09-14 23:11:03 +0200 |
| commit | 4b43764a8c329d6f59836700b3ae6266529a844a (patch) | |
| tree | 0196a7a2b2b3a762cfad741a5d94193d40584cac /src | |
| parent | 0ee3238a946729dd8d670a0ea37f0810b1070d81 (diff) | |
Use valueOf as ADT recommends
Use Boolean.valueOf, Long.valueOf, Integer.valueOf, ... instead of new
Boolean(), new Long(), ..., as ADT recommends
Diffstat (limited to 'src')
13 files changed, 24 insertions, 19 deletions
diff --git a/src/com/cyanogenmod/explorer/activities/SearchActivity.java b/src/com/cyanogenmod/explorer/activities/SearchActivity.java index ca23487..33083f1 100644 --- a/src/com/cyanogenmod/explorer/activities/SearchActivity.java +++ b/src/com/cyanogenmod/explorer/activities/SearchActivity.java @@ -565,7 +565,7 @@ public class SearchActivity extends Activity implements AsyncResultListener, OnI String foundItems = getResources(). getQuantityString( - R.plurals.search_found_items, items, new Integer(items)); + R.plurals.search_found_items, items, Integer.valueOf(items)); SearchActivity.this.mSearchFoundItems.setText( getString( R.string.search_found_items_in_directory, diff --git a/src/com/cyanogenmod/explorer/adapters/BookmarksAdapter.java b/src/com/cyanogenmod/explorer/adapters/BookmarksAdapter.java index d3af7f9..dfa6f9e 100644 --- a/src/com/cyanogenmod/explorer/adapters/BookmarksAdapter.java +++ b/src/com/cyanogenmod/explorer/adapters/BookmarksAdapter.java @@ -176,7 +176,7 @@ public class BookmarksAdapter extends ArrayAdapter<Bookmark> { viewHolder.mTvName = (TextView)v.findViewById(RESOURCE_ITEM_NAME); viewHolder.mTvDirectory = (TextView)v.findViewById(RESOURCE_ITEM_DIRECTORY); viewHolder.mBtAction = (ImageButton)v.findViewById(RESOURCE_ITEM_ACTION); - viewHolder.mBtAction.setTag(new Integer(position)); + viewHolder.mBtAction.setTag(Integer.valueOf(position)); v.setTag(viewHolder); } diff --git a/src/com/cyanogenmod/explorer/adapters/FileSystemObjectAdapter.java b/src/com/cyanogenmod/explorer/adapters/FileSystemObjectAdapter.java index b99f8ee..8447f17 100644 --- a/src/com/cyanogenmod/explorer/adapters/FileSystemObjectAdapter.java +++ b/src/com/cyanogenmod/explorer/adapters/FileSystemObjectAdapter.java @@ -282,13 +282,13 @@ public class FileSystemObjectAdapter dataHolder.mName.compareTo( FileHelper.PARENT_DIRECTORY) == 0 ? View.INVISIBLE : View.VISIBLE); viewHolder.mBtCheck.setImageDrawable(dataHolder.mDwCheck); - viewHolder.mBtCheck.setTag(new Integer(position)); + viewHolder.mBtCheck.setTag(Integer.valueOf(position)); v.setBackgroundResource( dataHolder.mSelected ? R.drawable.holo_list_selector_selected : R.drawable.holo_list_selector_deseleted); viewHolder.mBtMenu.setVisibility(dataHolder.mHasMenu ? View.VISIBLE : View.GONE); - viewHolder.mBtMenu.setTag(new Integer(position)); + viewHolder.mBtMenu.setTag(Integer.valueOf(position)); //Return the view return v; diff --git a/src/com/cyanogenmod/explorer/adapters/HistoryAdapter.java b/src/com/cyanogenmod/explorer/adapters/HistoryAdapter.java index 569c07b..950a187 100644 --- a/src/com/cyanogenmod/explorer/adapters/HistoryAdapter.java +++ b/src/com/cyanogenmod/explorer/adapters/HistoryAdapter.java @@ -141,7 +141,7 @@ public class HistoryAdapter extends ArrayAdapter<History> { } this.mData[i].mName = history.getItem().getTitle(); this.mData[i].mDirectory = history.getItem().getDescription(); - this.mData[i].mPosition = String.format("#%d", new Integer(i + 1)); //$NON-NLS-1$ + this.mData[i].mPosition = String.format("#%d", Integer.valueOf(i + 1)); //$NON-NLS-1$ } } diff --git a/src/com/cyanogenmod/explorer/commands/shell/ProcessIdCommand.java b/src/com/cyanogenmod/explorer/commands/shell/ProcessIdCommand.java index 88d2edf..228bd96 100644 --- a/src/com/cyanogenmod/explorer/commands/shell/ProcessIdCommand.java +++ b/src/com/cyanogenmod/explorer/commands/shell/ProcessIdCommand.java @@ -65,7 +65,7 @@ public class ProcessIdCommand extends SyncResultProgram implements ProcessIdExec } //Get the PID - this.mPID = new Integer(szLine.trim()); + this.mPID = Integer.valueOf(szLine.trim()); } catch (IOException ioEx) { throw new ParseException(ioEx.getMessage(), 0); diff --git a/src/com/cyanogenmod/explorer/console/OperationTimeoutException.java b/src/com/cyanogenmod/explorer/console/OperationTimeoutException.java index 3d39d0e..dcce809 100644 --- a/src/com/cyanogenmod/explorer/console/OperationTimeoutException.java +++ b/src/com/cyanogenmod/explorer/console/OperationTimeoutException.java @@ -30,7 +30,7 @@ public class OperationTimeoutException extends Exception { * @param command Executed command */ public OperationTimeoutException(long timeout, String command) { - super(String.format("(%d) %s", new Long(timeout), command)); //$NON-NLS-1$ + super(String.format("(%d) %s", Long.valueOf(timeout), command)); //$NON-NLS-1$ } } diff --git a/src/com/cyanogenmod/explorer/model/History.java b/src/com/cyanogenmod/explorer/model/History.java index 6ff18a0..99a3870 100644 --- a/src/com/cyanogenmod/explorer/model/History.java +++ b/src/com/cyanogenmod/explorer/model/History.java @@ -105,7 +105,7 @@ public class History implements Serializable, Comparable<History> { */ @Override public int compareTo(History another) { - return new Integer(this.mPosition).compareTo(new Integer(another.mPosition)); + return Integer.valueOf(this.mPosition).compareTo(new Integer(another.mPosition)); } /** diff --git a/src/com/cyanogenmod/explorer/model/SearchResult.java b/src/com/cyanogenmod/explorer/model/SearchResult.java index 2c9a840..9e923c9 100644 --- a/src/com/cyanogenmod/explorer/model/SearchResult.java +++ b/src/com/cyanogenmod/explorer/model/SearchResult.java @@ -113,7 +113,8 @@ public class SearchResult implements Serializable, Comparable<SearchResult> { @Override public int compareTo(SearchResult another) { if (this.mRelevance != another.mRelevance) { - return new Double(this.mRelevance).compareTo(new Double(another.mRelevance)) * -1; + return Double.valueOf(this.mRelevance).compareTo( + Double.valueOf(another.mRelevance)) * -1; } return this.mFso.compareTo(another.mFso); } diff --git a/src/com/cyanogenmod/explorer/ui/IconHolder.java b/src/com/cyanogenmod/explorer/ui/IconHolder.java index aae7f87..eafe842 100644 --- a/src/com/cyanogenmod/explorer/ui/IconHolder.java +++ b/src/com/cyanogenmod/explorer/ui/IconHolder.java @@ -48,7 +48,7 @@ public class IconHolder { */ public Drawable getDrawable(Context context, final int resid) { //Check if the icon exists in the cache - Integer id = new Integer(resid); + Integer id = Integer.valueOf(resid); if (this.mIcons.containsKey(id)) { return this.mIcons.get(id); } diff --git a/src/com/cyanogenmod/explorer/ui/dialogs/MessageProgressDialog.java b/src/com/cyanogenmod/explorer/ui/dialogs/MessageProgressDialog.java index ebd7fdd..40794bd 100644 --- a/src/com/cyanogenmod/explorer/ui/dialogs/MessageProgressDialog.java +++ b/src/com/cyanogenmod/explorer/ui/dialogs/MessageProgressDialog.java @@ -139,7 +139,10 @@ public class MessageProgressDialog implements DialogInterface.OnClickListener { public void setProgress(int progress) { Resources res = this.mDialog.getContext().getResources(); this.mProgress.setText( - res.getQuantityString(this.mProgressResourceId, progress, new Integer(progress))); + res.getQuantityString( + this.mProgressResourceId, + progress, + Integer.valueOf(progress))); } /** diff --git a/src/com/cyanogenmod/explorer/ui/widgets/RelevanceWidget.java b/src/com/cyanogenmod/explorer/ui/widgets/RelevanceWidget.java index 86f9bb9..dcb108a 100644 --- a/src/com/cyanogenmod/explorer/ui/widgets/RelevanceWidget.java +++ b/src/com/cyanogenmod/explorer/ui/widgets/RelevanceWidget.java @@ -88,15 +88,15 @@ public class RelevanceWidget extends View { this.mBorderPaint.setStrokeWidth((1 * density) + 0.5f); this.mRelevancePaint.setColor(Color.TRANSPARENT); - //Create the + //Create the color map this.mColors = new TreeMap<Integer, Integer>(); - this.mColors.put(new Integer(25), + this.mColors.put(Integer.valueOf(25), new Integer(getResources().getColor(R.color.relevance_percentil_25))); - this.mColors.put(new Integer(50), + this.mColors.put(Integer.valueOf(50), new Integer(getResources().getColor(R.color.relevance_percentil_50))); - this.mColors.put(new Integer(75), + this.mColors.put(Integer.valueOf(75), new Integer(getResources().getColor(R.color.relevance_percentil_75))); - this.mColors.put(new Integer(100), + this.mColors.put(Integer.valueOf(100), new Integer(getResources().getColor(R.color.relevance_percentil_100))); //Relevance is 0 until is sets diff --git a/src/com/cyanogenmod/explorer/util/FileHelper.java b/src/com/cyanogenmod/explorer/util/FileHelper.java index 36be649..2860d5b 100644 --- a/src/com/cyanogenmod/explorer/util/FileHelper.java +++ b/src/com/cyanogenmod/explorer/util/FileHelper.java @@ -142,11 +142,12 @@ public final class FileHelper { for (int i = 0; i < magnitude.length; i++) { long s = aux / 1024; if (aux < 1024) { - return String.format(format, new Long(aux), res.getString(magnitude[i])); + return String.format(format, Long.valueOf(aux), res.getString(magnitude[i])); } aux = s; } - return String.format(format, new Long(aux), res.getString(magnitude[magnitude.length - 1])); + return String.format( + format, Long.valueOf(aux), res.getString(magnitude[magnitude.length - 1])); } /** diff --git a/src/com/cyanogenmod/explorer/util/MimeTypeHelper.java b/src/com/cyanogenmod/explorer/util/MimeTypeHelper.java index 88ada20..161280c 100644 --- a/src/com/cyanogenmod/explorer/util/MimeTypeHelper.java +++ b/src/com/cyanogenmod/explorer/util/MimeTypeHelper.java @@ -78,7 +78,7 @@ public final class MimeTypeHelper { int resId = ResourcesHelper.getIdentifier( context.getResources(), "drawable", mime[1].trim()); //$NON-NLS-1$ if (resId != 0) { - sCachedIndentifiers.put(ext, new Integer(resId)); + sCachedIndentifiers.put(ext, Integer.valueOf(resId)); return resId; } } |
