diff options
| author | Pranav Vashi <neobuddy89@gmail.com> | 2022-07-31 13:08:48 +0530 |
|---|---|---|
| committer | Semavi Ulusoy <doc.divxm@gmail.com> | 2022-09-13 10:47:42 +0300 |
| commit | 25d442ee9b811265930eabcc7a006e0328823b59 (patch) | |
| tree | 2c40569c34f817ee8e81af9d6dee5f032bf8a919 | |
| parent | 30f59165c67b77170e0519e26183d01bfbc70f60 (diff) | |
Dialer: Fix LetterTileDrawable for all languages
* Currently alphabet tile is rendered only for english language.
However, Google Dialer / Googler Contacts do support rendering
for all languages. Let's do same here!
* Also, following Google, we do not want to handle numbers.
* Fixes: https://github.com/crdroidandroid/android_packages_apps_Dialer/issues/9
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I499e3a371cadc8f9ffdfeee2c90c761063879d8f
| -rw-r--r-- | java/com/android/dialer/lettertile/LetterTileDrawable.java | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/java/com/android/dialer/lettertile/LetterTileDrawable.java b/java/com/android/dialer/lettertile/LetterTileDrawable.java index 3eb840295..231853abe 100644 --- a/java/com/android/dialer/lettertile/LetterTileDrawable.java +++ b/java/com/android/dialer/lettertile/LetterTileDrawable.java @@ -173,10 +173,6 @@ public class LetterTileDrawable extends Drawable { } } - private static boolean isEnglishLetter(final char c) { - return ('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z'); - } - @Override public void draw(@NonNull final Canvas canvas) { final Rect bounds = getBounds(); @@ -335,7 +331,8 @@ public class LetterTileDrawable extends Drawable { private LetterTileDrawable setLetterAndColorFromContactDetails( final String displayName, final String identifier) { - if (!TextUtils.isEmpty(displayName) && isEnglishLetter(displayName.charAt(0))) { + if (displayName != null && !TextUtils.isEmpty(displayName) + && Character.isLetter(displayName.charAt(0))) { letter = Character.toUpperCase(displayName.charAt(0)); } else { letter = null; |