summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/precall/impl/PreCallModule.java
Commit message (Collapse)AuthorAgeFilesLines
* Use new instances of PreCallAction on activity resumetwyen2018-05-151-1/+0
| | | | | | | | | | | | Previously the same action instance is used every time the PreCallActivity is resumed. This causes some state to be retain, for example the isDiscarding state on CallingAccountSelector prevents canceling the next dialog to abort the call. Actions should not retain state between activity life cycles. TEST=TAP Bug: 79692264 Test: TAP PiperOrigin-RevId: 196696224 Change-Id: Ifa604f431563dd1fb123a42e2a64b34c001e897d
* Add @InstallIn and @IncludeInDialerRoot to dagger modules in dialer codebase.weijiaxu2018-05-111-0/+3
| | | | | | Test: presubmit. PiperOrigin-RevId: 196158524 Change-Id: Iec1e457039e97be0236cd700d397b4095ee3c2c3
* Place Duo calls with PreCalltwyen2018-05-091-1/+2
| | | | | | | | | | This CL consolidates common duo calling operations into precall, including checking reachability, falling back to carrier video call, placing the call to duo with startActivityForResult. TEST=TAP Bug: 78783816 Test: TAP PiperOrigin-RevId: 195742478 Change-Id: I9fea1e4999f604e1f3a153b28079cd0db77b7393
* Refactor PreferredAccountWorker to provide the dialog to be shown.twyen2018-04-301-2/+3
| | | | | | | | | | When dual SIM selection support is added to In Call UI it was a rush order and codes are duplicated. This CL moves the duplicated logic into PreferredAccountWorker so the same dialog can be shown for both. TEST=manual Bug: 69675796,72618783 Test: manual PiperOrigin-RevId: 194845320 Change-Id: Id283ca7616580b0efd4e8f02e63691c70ee7f93c
* Use PreCall.start instead of context.startActivity when starting calls from ↵zachh2018-04-191-1/+17
| | | | | | | | | | | | | | | | call log. For some reason not understood, startActivity with the call intent causes the current activity (MainActivity) to be paused, resumed, and paused again. This results in an opportunity to double-tap the row which causes the InCallUi to open in bubble mode (this is also not well understood). In any event, PreCall.start eventually uses TelecomManager to place the call rather than startActivity, which is presumably the thing that fixes the problem. Also refactored TestPreCallModule to remove the many test implementations of PreCall and remove the static field in the module which could cause test interference. TEST=manual Bug: 78187587 Test: manual PiperOrigin-RevId: 193596093 Change-Id: I933020d33db1c158628f14b30c2681c59c86201b
* Implement PreCallCoordinatortwyen2017-11-111-0/+31
When the user makes a call, the PreCallCoordinator will get a list of actions to perform from PreCallActionProviderComponent and apply them to the pending CallIntentBuilder, before sending the built intent to telecom Bug: 64216442 Test: PreCallExecutorImplTest PiperOrigin-RevId: 174911537 Change-Id: Ide5ec431d4e6e7879fcdfdbbbd7ea5eed9963b2c