| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
* option optimize_for = LITE_RUNTIME is ignored in proto 3+
* Instead we should use the java_lite compiler via the
LOCAL_PROTOC_OPTIMIZE_TYPE flag which defaults to lite in
java projects
Test: m Dialer, no warnings
Change-Id: I552f5895bbe8192a4ae870bb48e5ef6a9e7e8c78
|
| |
|
|
|
|
| |
Test: Existing tests
PiperOrigin-RevId: 202589482
Change-Id: I6982e4069d30032bf46caf3c9984dfc0e7196f6f
|
| |
|
|
|
|
|
|
|
| |
It no longer provides any value, so just use dagger directly.
Bug: 80441695
Test: tap
PiperOrigin-RevId: 198806461
Change-Id: Id607abb65b77633bce511ad0c943ac19453a85d5
|
| |
|
|
|
|
|
|
|
| |
Repeated requests from the server responds in an ALREADY_EXISTS error and does not transcribe the voicemails. In that case we should ask the server if the request is present already on the server, and if so retrieve it.
Bug: 77236260
Test: N/A
PiperOrigin-RevId: 191016332
Change-Id: I605c546a3bec3599c7b162853463ca7e46f63886
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
availability check
Checking donation is not a simple config check, but everything that donation availability is dependent on via the isVoicemailDonationAvailable() helper method. We update the code accordingly.
When the user declines the promo for donation, we should also update the toggle accordingly.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 191011808
Change-Id: I6e4ff9914355deed72175179fc7b9009f2395ef5
|
| |
|
|
|
|
|
|
|
| |
When transcription toggle is turned off, we delete all local transcriptions. However when it is turned back on, we should re-transcribe all those( previously transcribed, then deleted) voicemails again.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 190640972
Change-Id: Iaaf324e74c7630852daeb314f34c2c3095fe3196
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Manually set to M
- MissedCallNotifierTest (not sure what the issue is here...)
- CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown)
- MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory))
Ignore Tests
- a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason)
- VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear)
Bug: 73902692
Test: tap
PiperOrigin-RevId: 190030202
Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following:
- ensuring that when the VVM toggle is turned off, transcription and donations are gone.
- when transcription is off, donation preference is gone.
- donation is only available when transcription is available and enabled
- as part of the refactor, fixes existing logging bugs
- breaks preferences and its associated methods into helper methods when possible
- groups relevant preferences together when possible
Bug: 74033229
Test: Unit tests
PiperOrigin-RevId: 189418217
Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we are now using the AlarmManager to decide when to poll
for voicemail transcriptions, we need to ensure that we don't
start transcribing a voicemail until polling for the previous
one ends.
This cl postpones a voicemail transcription task if there is an alarm
set to poll for a transcription result. After a transcription result
is received (or we give up) the db is scanned for any pending transcriptions
and the next one is started.
Bug: 70242961
Test: manual and updated unit tests
PiperOrigin-RevId: 181899975
Change-Id: I7b8fb696164980cf710aa58a79418c6954e2b4d2
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
voicemail_transcription_available
Follow the convention that features allowed by server configuration flags use the
word 'available' and when a feature is allowed by the user via settings then use the
word 'enabled'
Bug: 37340510
Test: manual and updated unit tests
PiperOrigin-RevId: 178831467
Change-Id: I5691fd7db45a70908d32cdac2b049fe76e6a0680
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
For privacy reasons we now delete all voicemails and transcriptions when
the user disables visual voicemail, (after confirming that they want to do this
via a dialog).
Note: we only delete voicemails whose source package is the google dialer.
Note: the voicemails will be re-downloaded and re-transcribed if the user re-enables visual voicemail
Bug: 69323147
Test: manual and unit test
PiperOrigin-RevId: 177315139
Change-Id: Ie04496dc5960b485794733fbf74f7f704e806023
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
result
This cl switches the way asynchronous transcription tasks poll for their
results. it has been observed that sometimes the server side transcription
takes longer than expected (sometimes many minutes), so instead of blocking
a thread for all that time this cl schedules an alarm for the next time to
poll. it also uses an exponential backoff scheme to determine the poll times
and increases the maximum total polling time from 20 seconds to 20 minutes.
Bug: 66966157
Test: manual and unit tests
PiperOrigin-RevId: 177257577
Change-Id: Ib2998f03cc418d5241ccffec71ba3945c9fe4cbc
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Allow users who have agreed to donate their voicemails to also provide
transcription quality feedback.
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIajVtdFN3Y0Qydmx2NXJYN2N3OVA3N0h5UEdR
Bug: 68712148
Test: manual and new unit tests
PiperOrigin-RevId: 176774942
Change-Id: I08b9afbbefaedfb0de5199038a1d2769bd983855
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This cl just adds a check before starting a transcription job
to verify that the user has accepted the appropriate TOS. Its
a rather big cl just because it had to expose some TOS acceptance
details that were previously encapsulated in the VoicemailTosMessageCreator.
Bug: 69267260
Test: manual and unit tests
PiperOrigin-RevId: 176132370
Change-Id: Ic28fb197a07f9df7a9b5f1729c84566cba0890fc
|
| |
|
|
|
|
|
|
|
|
| |
Added a carrier config and check to see if the carrier allows over
the top voicemail transcription, and if not do not attempt transcription.
Bug: 68951869
Test: manual and unit test
PiperOrigin-RevId: 176065849
Change-Id: I69df1f2867420d7fdcc7f0a31e0e6c26da67abb1
|
| |
|
|
|
|
|
| |
Bug: 68900535
Test: SendTranscriptionFeedbackActionTest
PiperOrigin-RevId: 174732357
Change-Id: I9a99606a13cfc32f53a6ce8a15ad258bb48d7130
|
| |
|
|
|
|
|
| |
Bug: 68712148
Test: none
PiperOrigin-RevId: 174535170
Change-Id: I436335d142f369f8e7c3249463117ffd5c00d6b4
|
| |
|
|
|
|
|
|
|
|
|
| |
This is needed for rating transcription quality since we don't
persist the transcript id. The id we generate is just the md5
hash of the voicemail audio data.
Bug: 68712148
Test: manual and updated unit tests
PiperOrigin-RevId: 174527907
Change-Id: I7a29bf5a96447129fc1437074f20ecebcdb1f43b
|
| |
|
|
|
|
|
|
|
|
|
|
| |
in cl/173731907 we added a setting for donating voicemails, but didn't
distinguish between when this feature is enabled/disabled by the user
or by configuration. this cl fixes that by adding a method to check
if the feature is available (ie enabled by config).
Bug: 62423454
Test: manual and unit test
PiperOrigin-RevId: 174245260
Change-Id: I45a59de7f4a171d759e2fcf86db27a100a84de67
|
| |
|
|
|
|
|
| |
Bug: 62423454
Test: manual and updated unit test
PiperOrigin-RevId: 173731907
Change-Id: Ic73600197b1c4fa6ac0937a8c38b048cd8faded8
|
| |
|
|
|
|
|
|
| |
It fixes AOSP for package name conflict.
Test: manual
PiperOrigin-RevId: 173298696
Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
|
| |
|
|
|
|
|
|
|
| |
This will allow us to tune the polling rate.
Bug: 66966157
Test: none
PiperOrigin-RevId: 170210987
Change-Id: I6ef204acc6e0d43a3ada524511866d4a629fe1e2
|
| |
|
|
|
|
|
|
| |
//google/internal/communications/voicemailtranscription/v1/voicemail_transcription.proto
Test: n/a
PiperOrigin-RevId: 169425975
Change-Id: I0d53a576e1245cc1c4d7c8e36df3a510d8c7bdbe
|
| |
|
|
|
|
|
| |
Bug: 65648343
Test: updated unit tests (already submitted in previous cl)
PiperOrigin-RevId: 169280819
Change-Id: I5950087765ffd038c31b872c6468951472980407
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Apparently, scheduling a new job when one is already running (even using the enqueue api) causes the running job to be stopped. We weren't handling that case correctly. This cl makes sure no more work is attempted after a job is stopped by cancelling any
active transcription task. We request that stopped task be rescheduled by the job scheduler, so it will get run eventually.
I was able to verify this fix by sending a new voicemail while backfill old transcription tasks were running.
Bug: 64908823,63524274,65129734,63803709
Test: manual and unit tests
PiperOrigin-RevId: 167617191
Change-Id: Icc92997c2687e61bef9b3b7f9ff572da2cb4ed2e
|
| |
|
|
|
|
|
|
|
|
|
| |
These new states will be used to show descriptive failure messages to the user.
Also moved the VoicemailCompat class to avoid duplicate code.
Bug: 37340510
Test: none
PiperOrigin-RevId: 167314611
Change-Id: I618d7f196ea2b0161cbd33479553cae3521328d7
|
|
|
Previously, Android's Dialer app was developed in an internal Google
source control system and only exported to public during AOSP drops.
The Dialer team is now switching to a public development model similar
to the telephony team.
This CL represents all internal Google changes that were committed to
Dialer between the public O release and today's tip of tree on internal
master. This CL squashes those changes into a single commit.
In subsequent changes, changes will be exported on a per-commit basis.
Test: make, flash install, run
Merged-In: I45270eaa8ce732d71a1bd84b08c7fa0e99af3160
Change-Id: I529aaeb88535b9533c0ae4ef4e6c1222d4e0f1c8
PiperOrigin-RevId: 167068436
|