diff options
| author | Christos Papageorgiou <root.expert.xda@gmail.com> | 2019-07-18 15:10:52 +0300 |
|---|---|---|
| committer | Julian Veit <claymore1298@gmail.com> | 2019-07-19 14:53:44 +0200 |
| commit | cf9b704121fc2172cf67d67ac10775900561f20a (patch) | |
| tree | 00e5a3e00bc72268169f610875266703864ae865 | |
| parent | dc83801bd3d13067b64fb32b3d7a6ec573224304 (diff) | |
JamesDSP: Cleanup xml files.
* Apply Android Studio recommendations
| -rw-r--r-- | app/src/main/res/layout/activity_main.xml | 3 | ||||
| -rw-r--r-- | app/src/main/res/layout/drawer_item.xml | 2 | ||||
| -rw-r--r-- | app/src/main/res/layout/seek_bar_preference.xml | 17 | ||||
| -rw-r--r-- | app/src/main/res/xml/bluetooth_preferences.xml | 18 | ||||
| -rw-r--r-- | app/src/main/res/xml/headset_preferences.xml | 18 | ||||
| -rw-r--r-- | app/src/main/res/xml/speaker_preferences.xml | 18 |
6 files changed, 38 insertions, 38 deletions
diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml index bb85d66..fa367b6 100644 --- a/app/src/main/res/layout/activity_main.xml +++ b/app/src/main/res/layout/activity_main.xml @@ -27,8 +27,7 @@ android:layout_width="match_parent" android:layout_height="match_parent" /> - <ListView xmlns:android="http://schemas.android.com/apk/res/android" - xmlns:tools="http://schemas.android.com/tools" + <ListView android:id="@+id/dsp_navigation_drawer" android:background="@color/navigation_drawerdark" android:layout_width="260dp" diff --git a/app/src/main/res/layout/drawer_item.xml b/app/src/main/res/layout/drawer_item.xml index ad82787..dd1caab 100644 --- a/app/src/main/res/layout/drawer_item.xml +++ b/app/src/main/res/layout/drawer_item.xml @@ -29,7 +29,7 @@ android:paddingTop="10dp" android:paddingRight="10dp" android:paddingBottom="10dp" - android:layout_alignParentLeft="true" + android:layout_alignParentStart="true" android:layout_centerVertical="true" /> <TextView diff --git a/app/src/main/res/layout/seek_bar_preference.xml b/app/src/main/res/layout/seek_bar_preference.xml index 724a421..8c36834 100644 --- a/app/src/main/res/layout/seek_bar_preference.xml +++ b/app/src/main/res/layout/seek_bar_preference.xml @@ -20,14 +20,14 @@ android:id="@android:id/widget_frame" android:layout_width="fill_parent" android:layout_height="wrap_content" - android:paddingLeft="8dp" + android:paddingStart="8dp" android:paddingTop="5dp" - android:paddingRight="10dp" + android:paddingEnd="10dp" android:paddingBottom="5dp"> <TextView android:id="@android:id/title" - android:layout_alignParentLeft="true" + android:layout_alignParentStart="true" android:layout_alignParentTop="true" android:layout_width="fill_parent" android:layout_height="wrap_content" @@ -35,7 +35,7 @@ <TextView android:id="@android:id/summary" - android:layout_alignParentLeft="true" + android:layout_alignParentStart="true" android:layout_width="fill_parent" android:layout_height="wrap_content" android:layout_below="@android:id/title" @@ -50,7 +50,7 @@ <TextView android:id="@+id/seekBarPrefUnitsRight" android:layout_centerInParent="true" - android:layout_alignParentRight="true" + android:layout_alignParentEnd="true" android:layout_width="wrap_content" android:layout_height="wrap_content" android:textAppearance="?android:attr/textAppearanceSmall" /> @@ -60,14 +60,14 @@ android:layout_centerInParent="true" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_toLeftOf="@id/seekBarPrefUnitsRight" + android:layout_toStartOf="@id/seekBarPrefUnitsRight" android:gravity="right" android:textAppearance="?android:attr/textAppearanceSmall" /> <TextView android:id="@+id/seekBarPrefUnitsLeft" android:layout_centerInParent="true" - android:layout_toLeftOf="@id/seekBarPrefValue" + android:layout_toStartOf="@id/seekBarPrefValue" android:layout_width="wrap_content" android:layout_height="wrap_content" android:textAppearance="?android:attr/textAppearanceSmall" /> @@ -77,6 +77,7 @@ android:layout_centerInParent="true" android:layout_width="fill_parent" android:layout_height="wrap_content" - android:layout_toLeftOf="@id/seekBarPrefUnitsLeft" /> + android:layout_toStartOf="@id/seekBarPrefUnitsLeft" + android:orientation="horizontal" /> </RelativeLayout> </RelativeLayout>
\ No newline at end of file diff --git a/app/src/main/res/xml/bluetooth_preferences.xml b/app/src/main/res/xml/bluetooth_preferences.xml index ca68b56..7fcea6c 100644 --- a/app/src/main/res/xml/bluetooth_preferences.xml +++ b/app/src/main/res/xml/bluetooth_preferences.xml @@ -6,7 +6,7 @@ android:summaryOn="@string/pref_dsp_summary_on" android:summaryOff="@string/pref_dsp_summary_off" android:disableDependentsState="false" - android:title="@string/pref_dsp_enable"></CheckBoxPreference> + android:title="@string/pref_dsp_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_compression_title"> @@ -15,7 +15,7 @@ android:summaryOn="@string/pref_compression_summary_on" android:summaryOff="@string/pref_compression_summary_off" android:disableDependentsState="false" - android:title="@string/pref_compression_enable"></CheckBoxPreference> + android:title="@string/pref_compression_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_bassboost_title"> @@ -24,7 +24,7 @@ android:key="dsp.bass.enable" android:summaryOn="@string/pref_bassboost_summary_on" android:summaryOff="@string/pref_bassboost_summary_off" - android:title="@string/pref_bassboost_enable"></CheckBoxPreference> + android:title="@string/pref_bassboost_enable" /> <james.dsp.preference.SummariedListPreference android:entries="@array/bassboost_modes" @@ -57,7 +57,7 @@ android:key="dsp.tone.enable" android:summaryOn="@string/pref_equalizer_summary_on" android:summaryOff="@string/pref_equalizer_summary_off" - android:title="@string/pref_equalizer_enable"></CheckBoxPreference> + android:title="@string/pref_equalizer_enable" /> <james.dsp.preference.SummariedListPreference android:entries="@array/equalizer_preset_modes" android:dialogTitle="@string/pref_equalizer_preset_title" @@ -75,7 +75,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_convolver_summary_on" android:summaryOff="@string/pref_convolver_summary_off" - android:title="@string/pref_convolver_enable"></CheckBoxPreference> + android:title="@string/pref_convolver_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_ddc_title" android:key="dsp.ddc"> @@ -84,7 +84,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_ddc_summary_on" android:summaryOff="@string/pref_ddc_summary_off" - android:title="@string/pref_ddc_enable"></CheckBoxPreference> + android:title="@string/pref_ddc_enable" /> <james.dsp.preference.SummariedListPreferenceDDC android:title="@string/dialog_sosmatrix" android:key="dsp.ddc.files" @@ -99,7 +99,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_analogmodelling_summary_on" android:summaryOff="@string/pref_analogmodelling_summary_off" - android:title="@string/pref_analogmodelling_enable"></CheckBoxPreference> + android:title="@string/pref_analogmodelling_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_headset_stereowide_title"> @@ -108,7 +108,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_headset_stereowide_summary_on" android:summaryOff="@string/pref_headset_stereowide_summary_off" - android:title="@string/pref_headset_stereowide_enable"></CheckBoxPreference> + android:title="@string/pref_headset_stereowide_enable" /> <james.dsp.preference.SummariedListPreference android:defaultValue="0" android:dialogTitle="@string/dialog_stereo" @@ -124,7 +124,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_headset_bs2b_summary_on" android:summaryOff="@string/pref_headset_bs2b_summary_off" - android:title="@string/pref_headset_bs2b_enable"></CheckBoxPreference> + android:title="@string/pref_headset_bs2b_enable" /> <james.dsp.preference.SummariedListPreference android:defaultValue="0" android:dialogTitle="@string/dialog_bs2b" diff --git a/app/src/main/res/xml/headset_preferences.xml b/app/src/main/res/xml/headset_preferences.xml index ca68b56..7fcea6c 100644 --- a/app/src/main/res/xml/headset_preferences.xml +++ b/app/src/main/res/xml/headset_preferences.xml @@ -6,7 +6,7 @@ android:summaryOn="@string/pref_dsp_summary_on" android:summaryOff="@string/pref_dsp_summary_off" android:disableDependentsState="false" - android:title="@string/pref_dsp_enable"></CheckBoxPreference> + android:title="@string/pref_dsp_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_compression_title"> @@ -15,7 +15,7 @@ android:summaryOn="@string/pref_compression_summary_on" android:summaryOff="@string/pref_compression_summary_off" android:disableDependentsState="false" - android:title="@string/pref_compression_enable"></CheckBoxPreference> + android:title="@string/pref_compression_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_bassboost_title"> @@ -24,7 +24,7 @@ android:key="dsp.bass.enable" android:summaryOn="@string/pref_bassboost_summary_on" android:summaryOff="@string/pref_bassboost_summary_off" - android:title="@string/pref_bassboost_enable"></CheckBoxPreference> + android:title="@string/pref_bassboost_enable" /> <james.dsp.preference.SummariedListPreference android:entries="@array/bassboost_modes" @@ -57,7 +57,7 @@ android:key="dsp.tone.enable" android:summaryOn="@string/pref_equalizer_summary_on" android:summaryOff="@string/pref_equalizer_summary_off" - android:title="@string/pref_equalizer_enable"></CheckBoxPreference> + android:title="@string/pref_equalizer_enable" /> <james.dsp.preference.SummariedListPreference android:entries="@array/equalizer_preset_modes" android:dialogTitle="@string/pref_equalizer_preset_title" @@ -75,7 +75,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_convolver_summary_on" android:summaryOff="@string/pref_convolver_summary_off" - android:title="@string/pref_convolver_enable"></CheckBoxPreference> + android:title="@string/pref_convolver_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_ddc_title" android:key="dsp.ddc"> @@ -84,7 +84,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_ddc_summary_on" android:summaryOff="@string/pref_ddc_summary_off" - android:title="@string/pref_ddc_enable"></CheckBoxPreference> + android:title="@string/pref_ddc_enable" /> <james.dsp.preference.SummariedListPreferenceDDC android:title="@string/dialog_sosmatrix" android:key="dsp.ddc.files" @@ -99,7 +99,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_analogmodelling_summary_on" android:summaryOff="@string/pref_analogmodelling_summary_off" - android:title="@string/pref_analogmodelling_enable"></CheckBoxPreference> + android:title="@string/pref_analogmodelling_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_headset_stereowide_title"> @@ -108,7 +108,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_headset_stereowide_summary_on" android:summaryOff="@string/pref_headset_stereowide_summary_off" - android:title="@string/pref_headset_stereowide_enable"></CheckBoxPreference> + android:title="@string/pref_headset_stereowide_enable" /> <james.dsp.preference.SummariedListPreference android:defaultValue="0" android:dialogTitle="@string/dialog_stereo" @@ -124,7 +124,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_headset_bs2b_summary_on" android:summaryOff="@string/pref_headset_bs2b_summary_off" - android:title="@string/pref_headset_bs2b_enable"></CheckBoxPreference> + android:title="@string/pref_headset_bs2b_enable" /> <james.dsp.preference.SummariedListPreference android:defaultValue="0" android:dialogTitle="@string/dialog_bs2b" diff --git a/app/src/main/res/xml/speaker_preferences.xml b/app/src/main/res/xml/speaker_preferences.xml index ca68b56..7fcea6c 100644 --- a/app/src/main/res/xml/speaker_preferences.xml +++ b/app/src/main/res/xml/speaker_preferences.xml @@ -6,7 +6,7 @@ android:summaryOn="@string/pref_dsp_summary_on" android:summaryOff="@string/pref_dsp_summary_off" android:disableDependentsState="false" - android:title="@string/pref_dsp_enable"></CheckBoxPreference> + android:title="@string/pref_dsp_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_compression_title"> @@ -15,7 +15,7 @@ android:summaryOn="@string/pref_compression_summary_on" android:summaryOff="@string/pref_compression_summary_off" android:disableDependentsState="false" - android:title="@string/pref_compression_enable"></CheckBoxPreference> + android:title="@string/pref_compression_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_bassboost_title"> @@ -24,7 +24,7 @@ android:key="dsp.bass.enable" android:summaryOn="@string/pref_bassboost_summary_on" android:summaryOff="@string/pref_bassboost_summary_off" - android:title="@string/pref_bassboost_enable"></CheckBoxPreference> + android:title="@string/pref_bassboost_enable" /> <james.dsp.preference.SummariedListPreference android:entries="@array/bassboost_modes" @@ -57,7 +57,7 @@ android:key="dsp.tone.enable" android:summaryOn="@string/pref_equalizer_summary_on" android:summaryOff="@string/pref_equalizer_summary_off" - android:title="@string/pref_equalizer_enable"></CheckBoxPreference> + android:title="@string/pref_equalizer_enable" /> <james.dsp.preference.SummariedListPreference android:entries="@array/equalizer_preset_modes" android:dialogTitle="@string/pref_equalizer_preset_title" @@ -75,7 +75,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_convolver_summary_on" android:summaryOff="@string/pref_convolver_summary_off" - android:title="@string/pref_convolver_enable"></CheckBoxPreference> + android:title="@string/pref_convolver_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_ddc_title" android:key="dsp.ddc"> @@ -84,7 +84,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_ddc_summary_on" android:summaryOff="@string/pref_ddc_summary_off" - android:title="@string/pref_ddc_enable"></CheckBoxPreference> + android:title="@string/pref_ddc_enable" /> <james.dsp.preference.SummariedListPreferenceDDC android:title="@string/dialog_sosmatrix" android:key="dsp.ddc.files" @@ -99,7 +99,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_analogmodelling_summary_on" android:summaryOff="@string/pref_analogmodelling_summary_off" - android:title="@string/pref_analogmodelling_enable"></CheckBoxPreference> + android:title="@string/pref_analogmodelling_enable" /> </PreferenceCategory> <PreferenceCategory android:title="@string/pref_headset_stereowide_title"> @@ -108,7 +108,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_headset_stereowide_summary_on" android:summaryOff="@string/pref_headset_stereowide_summary_off" - android:title="@string/pref_headset_stereowide_enable"></CheckBoxPreference> + android:title="@string/pref_headset_stereowide_enable" /> <james.dsp.preference.SummariedListPreference android:defaultValue="0" android:dialogTitle="@string/dialog_stereo" @@ -124,7 +124,7 @@ android:disableDependentsState="false" android:summaryOn="@string/pref_headset_bs2b_summary_on" android:summaryOff="@string/pref_headset_bs2b_summary_off" - android:title="@string/pref_headset_bs2b_enable"></CheckBoxPreference> + android:title="@string/pref_headset_bs2b_enable" /> <james.dsp.preference.SummariedListPreference android:defaultValue="0" android:dialogTitle="@string/dialog_bs2b" |
