diff options
| author | Chalard Jean <jchalard@google.com> | 2021-10-04 16:36:32 +0900 |
|---|---|---|
| committer | Chalard Jean <jchalard@google.com> | 2021-10-04 18:02:17 +0900 |
| commit | 1afb2e33e2bb54449cd6e96247cf3df5770ee882 (patch) | |
| tree | 853e4bfbc48d0e672c944aa0b4257d97dee8b932 /tests/unit/java/android/net/ConnectivityManagerTest.java | |
| parent | 7ece4bb71e277599c445a5f7d81d85ffdf301d04 (diff) | |
Increase timeouts for loopers
In coverage tests this seems to randomly fail, which suggests
some delay. Have a constant for timeout and increase its value
significantly where it makes no functional difference.
Test: FrameworksNetTests
Change-Id: I035d865f01688daf3bce30c5130ce550fa84b885
Diffstat (limited to 'tests/unit/java/android/net/ConnectivityManagerTest.java')
| -rw-r--r-- | tests/unit/java/android/net/ConnectivityManagerTest.java | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/tests/unit/java/android/net/ConnectivityManagerTest.java b/tests/unit/java/android/net/ConnectivityManagerTest.java index c475419b8a..f324630bd2 100644 --- a/tests/unit/java/android/net/ConnectivityManagerTest.java +++ b/tests/unit/java/android/net/ConnectivityManagerTest.java @@ -47,6 +47,7 @@ import static org.mockito.ArgumentMatchers.anyBoolean; import static org.mockito.ArgumentMatchers.eq; import static org.mockito.ArgumentMatchers.nullable; import static org.mockito.Mockito.CALLS_REAL_METHODS; +import static org.mockito.Mockito.after; import static org.mockito.Mockito.any; import static org.mockito.Mockito.anyInt; import static org.mockito.Mockito.mock; @@ -85,6 +86,8 @@ import org.mockito.MockitoAnnotations; @SmallTest @DevSdkIgnoreRule.IgnoreUpTo(VERSION_CODES.R) public class ConnectivityManagerTest { + private static final int TIMEOUT_MS = 30_000; + private static final int SHORT_TIMEOUT_MS = 150; @Mock Context mCtx; @Mock IConnectivityManager mService; @@ -233,7 +236,7 @@ public class ConnectivityManagerTest { // callback triggers captor.getValue().send(makeMessage(request, ConnectivityManager.CALLBACK_AVAILABLE)); - verify(callback, timeout(500).times(1)).onAvailable(any(Network.class), + verify(callback, timeout(TIMEOUT_MS).times(1)).onAvailable(any(Network.class), any(NetworkCapabilities.class), any(LinkProperties.class), anyBoolean()); // unregister callback @@ -242,7 +245,7 @@ public class ConnectivityManagerTest { // callback does not trigger anymore. captor.getValue().send(makeMessage(request, ConnectivityManager.CALLBACK_LOSING)); - verify(callback, timeout(500).times(0)).onLosing(any(), anyInt()); + verify(callback, after(SHORT_TIMEOUT_MS).never()).onLosing(any(), anyInt()); } @Test @@ -262,7 +265,7 @@ public class ConnectivityManagerTest { // callback triggers captor.getValue().send(makeMessage(req1, ConnectivityManager.CALLBACK_AVAILABLE)); - verify(callback, timeout(100).times(1)).onAvailable(any(Network.class), + verify(callback, timeout(TIMEOUT_MS).times(1)).onAvailable(any(Network.class), any(NetworkCapabilities.class), any(LinkProperties.class), anyBoolean()); // unregister callback @@ -271,7 +274,7 @@ public class ConnectivityManagerTest { // callback does not trigger anymore. captor.getValue().send(makeMessage(req1, ConnectivityManager.CALLBACK_LOSING)); - verify(callback, timeout(100).times(0)).onLosing(any(), anyInt()); + verify(callback, after(SHORT_TIMEOUT_MS).never()).onLosing(any(), anyInt()); // callback can be registered again when(mService.requestNetwork(anyInt(), any(), anyInt(), captor.capture(), anyInt(), any(), @@ -280,7 +283,7 @@ public class ConnectivityManagerTest { // callback triggers captor.getValue().send(makeMessage(req2, ConnectivityManager.CALLBACK_LOST)); - verify(callback, timeout(100).times(1)).onLost(any()); + verify(callback, timeout(TIMEOUT_MS).times(1)).onLost(any()); // unregister callback manager.unregisterNetworkCallback(callback); |
