diff options
Diffstat (limited to 'Tethering/common/TetheringLib/src/android/net/TetheringManager.java')
| -rw-r--r-- | Tethering/common/TetheringLib/src/android/net/TetheringManager.java | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/Tethering/common/TetheringLib/src/android/net/TetheringManager.java b/Tethering/common/TetheringLib/src/android/net/TetheringManager.java index c137b4924d..9e6e34ee69 100644 --- a/Tethering/common/TetheringLib/src/android/net/TetheringManager.java +++ b/Tethering/common/TetheringLib/src/android/net/TetheringManager.java @@ -290,6 +290,23 @@ public class TetheringManager { getConnector(c -> c.registerTetheringEventCallback(mCallback, pkgName)); } + /** @hide */ + @Override + protected void finalize() throws Throwable { + final String pkgName = mContext.getOpPackageName(); + Log.i(TAG, "unregisterTetheringEventCallback:" + pkgName); + // 1. It's generally not recommended to perform long operations in finalize, but while + // unregisterTetheringEventCallback does an IPC, it's a oneway IPC so should not block. + // 2. If the connector is not yet connected, TetheringManager is impossible to finalize + // because the connector polling thread strong reference the TetheringManager object. So + // it's guaranteed that registerTetheringEventCallback was already called before calling + // unregisterTetheringEventCallback in finalize. + if (mConnector == null) Log.wtf(TAG, "null connector in finalize!"); + getConnector(c -> c.unregisterTetheringEventCallback(mCallback, pkgName)); + + super.finalize(); + } + private void startPollingForConnector() { new Thread(() -> { while (true) { |