diff options
| author | Maciej Żenczykowski <maze@google.com> | 2020-04-21 18:22:31 -0700 |
|---|---|---|
| committer | Maciej Żenczykowski <maze@google.com> | 2020-04-22 07:29:20 +0000 |
| commit | 2c7944838f634272dc45a9393ee41f87ebaf6cd3 (patch) | |
| tree | 001598b38dc096ee7eec408193cc3862eb6e3153 /server/BandwidthController.cpp | |
| parent | acdc0871463d4aff9bbf4856dfe6794ae14d76be (diff) | |
BandwidthController - fix bugprone-suspicious-missing-comma warnings
Fixes:
system/netd/server/BandwidthController.cpp:230:13: warning: suspicious string literal, probably missing a comma [bugprone-suspicious-missing-comma]
(and fixing that reveals more that I'm also fixing)
Note: Using parenthesis seems better than marking with
// NOLINTNEXTLINE(bugprone-suspicious-missing-comma)
Test: builds
Bug: 153035880
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I95d3b1cda93e5a55504e6cd94a795e259863d47f
Diffstat (limited to 'server/BandwidthController.cpp')
| -rw-r--r-- | server/BandwidthController.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/server/BandwidthController.cpp b/server/BandwidthController.cpp index 363cba01..cddaa961 100644 --- a/server/BandwidthController.cpp +++ b/server/BandwidthController.cpp @@ -227,7 +227,7 @@ const std::vector<std::string> getBasicAccountingCommands(const bool useBpf) { "-A bw_OUTPUT -j bw_global_alert", // Prevents IPSec double counting (Tunnel mode and Transport mode, // respectively) - "-A bw_OUTPUT -o " IPSEC_IFACE_PREFIX "+ -j RETURN", + ("-A bw_OUTPUT -o " IPSEC_IFACE_PREFIX "+ -j RETURN"), "-A bw_OUTPUT -m policy --pol ipsec --dir out -j RETURN", useBpf ? "" : "-A bw_OUTPUT -m owner --socket-exists", @@ -241,7 +241,7 @@ const std::vector<std::string> getBasicAccountingCommands(const bool useBpf) { "*raw", // Prevents IPSec double counting (Tunnel mode and Transport mode, // respectively) - "-A bw_raw_PREROUTING -i " IPSEC_IFACE_PREFIX "+ -j RETURN", + ("-A bw_raw_PREROUTING -i " IPSEC_IFACE_PREFIX "+ -j RETURN"), "-A bw_raw_PREROUTING -m policy --pol ipsec --dir in -j RETURN", useBpf ? StringPrintf("-A bw_raw_PREROUTING -m bpf --object-pinned %s", XT_BPF_INGRESS_PROG_PATH) @@ -251,7 +251,7 @@ const std::vector<std::string> getBasicAccountingCommands(const bool useBpf) { "*mangle", // Prevents IPSec double counting (Tunnel mode and Transport mode, // respectively) - "-A bw_mangle_POSTROUTING -o " IPSEC_IFACE_PREFIX "+ -j RETURN", + ("-A bw_mangle_POSTROUTING -o " IPSEC_IFACE_PREFIX "+ -j RETURN"), "-A bw_mangle_POSTROUTING -m policy --pol ipsec --dir out -j RETURN", useBpf ? "" : "-A bw_mangle_POSTROUTING -m owner --socket-exists", StringPrintf("-A bw_mangle_POSTROUTING -j MARK --set-mark 0x0/0x%x", |